All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: gregkh@suse.de, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH 2/2] TTY: remove tty_locked
Date: Thu, 14 Jul 2011 14:18:30 +0200	[thread overview]
Message-ID: <4E1EDE96.8070700@gmail.com> (raw)
In-Reply-To: <1310553086-27427-2-git-send-email-jslaby@suse.cz>

On 07/13/2011 12:31 PM, Jiri Slaby wrote:
> --- a/drivers/tty/tty_mutex.c
> +++ b/drivers/tty/tty_mutex.c
...
> @@ -25,10 +23,7 @@ void __lockfunc tty_lock(void)
>  {
>  	struct task_struct *task = current;

Hmm I overlooked it generates a warning:
drivers/tty/tty_mutex.c: In function ‘tty_lock’:
drivers/tty/tty_mutex.c:24:22: warning: unused variable ‘task’
drivers/tty/tty_mutex.c: In function ‘tty_unlock’:
drivers/tty/tty_mutex.c:32:22: warning: unused variable ‘task’

> -	WARN_ON(__big_tty_mutex_owner == task);
> -
>  	mutex_lock(&big_tty_mutex);
> -	__big_tty_mutex_owner = task;
>  }

I will send whole series as v2 since it is confusing enough.

thanks,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@gmail.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: gregkh@suse.de, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH 2/2] TTY: remove tty_locked
Date: Thu, 14 Jul 2011 14:18:30 +0200	[thread overview]
Message-ID: <4E1EDE96.8070700@gmail.com> (raw)
In-Reply-To: <1310553086-27427-2-git-send-email-jslaby@suse.cz>

On 07/13/2011 12:31 PM, Jiri Slaby wrote:
> --- a/drivers/tty/tty_mutex.c
> +++ b/drivers/tty/tty_mutex.c
...
> @@ -25,10 +23,7 @@ void __lockfunc tty_lock(void)
>  {
>  	struct task_struct *task = current;

Hmm I overlooked it generates a warning:
drivers/tty/tty_mutex.c: In function ‘tty_lock’:
drivers/tty/tty_mutex.c:24:22: warning: unused variable ‘task’
drivers/tty/tty_mutex.c: In function ‘tty_unlock’:
drivers/tty/tty_mutex.c:32:22: warning: unused variable ‘task’

> -	WARN_ON(__big_tty_mutex_owner == task);
> -
>  	mutex_lock(&big_tty_mutex);
> -	__big_tty_mutex_owner = task;
>  }

I will send whole series as v2 since it is confusing enough.

thanks,
-- 
js

  parent reply	other threads:[~2011-07-14 12:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-12 20:43 [PATCH 1/3] TTY: serial, remove BTM from wait_until_sent Jiri Slaby
2011-07-12 20:43 ` [PATCH 2/3] TTY: msm_serial, remove unneeded console set Jiri Slaby
2011-07-12 20:43 ` [PATCH 3/3] TTY: serial, remove tasklet for tty_wakeup Jiri Slaby
2011-07-12 21:08   ` Arnd Bergmann
2011-07-12 21:25 ` [PATCH 1/3] TTY: serial, remove BTM from wait_until_sent Arnd Bergmann
2011-07-13 10:31   ` [PATCH 1/2] TTY: ami_serial, " Jiri Slaby
2011-07-13 10:31     ` [PATCH 2/2] TTY: remove tty_locked Jiri Slaby
2011-07-13 12:56       ` Arnd Bergmann
2011-07-14 12:18       ` Jiri Slaby [this message]
2011-07-14 12:18         ` Jiri Slaby
2011-07-13 12:56     ` [PATCH 1/2] TTY: ami_serial, remove BTM from wait_until_sent Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1EDE96.8070700@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=alan@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@suse.de \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.