From: Arnd Bergmann <arnd@arndb.de>
To: Jiri Slaby <jslaby@suse.cz>
Cc: gregkh@suse.de, jirislaby@gmail.com,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Cox <alan@linux.intel.com>, Andreas Bombe <aeb@debian.org>
Subject: Re: [PATCH 1/2] TTY: ami_serial, remove BTM from wait_until_sent
Date: Wed, 13 Jul 2011 14:56:28 +0200 [thread overview]
Message-ID: <201107131456.28333.arnd@arndb.de> (raw)
In-Reply-To: <1310553086-27427-1-git-send-email-jslaby@suse.cz>
On Wednesday 13 July 2011, Jiri Slaby wrote:
> The same as in "TTY: serial, remove BTM from wait_until_sent" we don't
> need to take BTM in wait_until_sent of ami_serial. Exactly the same
> as serial, ami_serial accesses some "info" members (xmit_fifo_size,
> timeout), but their assignment on other places in the code is not
> protected by BTM anyway.
>
> So the BTM protects nothing here. This removal helps us to get rid of
> tty_locked() and __big_tty_mutex_owner in the following patch. This
> was suggested by Arnd.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Cc: Alan Cox <alan@linux.intel.com>
> Cc: Andreas Bombe <aeb@debian.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2011-07-13 12:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 20:43 [PATCH 1/3] TTY: serial, remove BTM from wait_until_sent Jiri Slaby
2011-07-12 20:43 ` [PATCH 2/3] TTY: msm_serial, remove unneeded console set Jiri Slaby
2011-07-12 20:43 ` [PATCH 3/3] TTY: serial, remove tasklet for tty_wakeup Jiri Slaby
2011-07-12 21:08 ` Arnd Bergmann
2011-07-12 21:25 ` [PATCH 1/3] TTY: serial, remove BTM from wait_until_sent Arnd Bergmann
2011-07-13 10:31 ` [PATCH 1/2] TTY: ami_serial, " Jiri Slaby
2011-07-13 10:31 ` [PATCH 2/2] TTY: remove tty_locked Jiri Slaby
2011-07-13 12:56 ` Arnd Bergmann
2011-07-14 12:18 ` Jiri Slaby
2011-07-14 12:18 ` Jiri Slaby
2011-07-13 12:56 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107131456.28333.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=aeb@debian.org \
--cc=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.