[PATCH] checkpatch.pl: Update $logFunctions

[PATCH] checkpatch.pl: Update $logFunctions

[Joe Perches]

Allow numbers in leading prefix.
Add logging functions with _once and _ratelimit.
Add <prefix>_printk.

Signed-off-by: Joe Perches <joe@perches.com>
---
 scripts/checkpatch.pl |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 75d3199..6bc2caf 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -256,9 +256,9 @@ our $typeTypedefs = qr{(?x:
 )};
 
 our $logFunctions = qr{(?x:
-	printk|
-	[a-z]+_(emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)|
-	WARN|
+	printk(?:_ratelimited|_once|)|
+	[a-z0-9]+_(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
+	WARN(?:_RATELIMIT|_ONCE|)|
 	panic|
 	MODULE_[A-Z_]+
 )};
-- 
1.7.6.131.g99019

Re: [PATCH] checkpatch.pl: Update $logFunctions

[Andrew Morton]

On Wed, 13 Jul 2011 09:05:47 -0700
Joe Perches <joe@perches.com> wrote:

> Allow numbers in leading prefix.
> Add logging functions with _once and _ratelimit.
> Add <prefix>_printk.
> 

I look at this description wondering "hm, what does this do to
checkpatch behaviour" and realize I have not a clue.

Oh well, I'll trust you ;)

Re: [PATCH] checkpatch.pl: Update $logFunctions

[Joe Perches]

On Wed, 2011-07-13 at 16:16 -0700, Andrew Morton wrote:
> On Wed, 13 Jul 2011 09:05:47 -0700
> Joe Perches <joe@perches.com> wrote:
> > Allow numbers in leading prefix.
> > Add logging functions with _once and _ratelimit.
> > Add <prefix>_printk.
> I look at this description wondering "hm, what does this do to
> checkpatch behaviour" and realize I have not a clue.
> Oh well, I'll trust you ;)

Not necessarily a good plan...

Perhaps this description instead:

[PATCH] checkpatch.pl: Allow more printk types (<prefix>_<level>) to be > 80 cols

Previous behavior allowed only alphabetic prefixes
like pr_info to exceed the 80 column line length limit.

ath6kl wants to add a digit into the prefix, so allow
numbers as well as digits in the <prefix>_<level> printks.

<prefix>_<level>_ratelimited and <prefix>_<level>_once
and WARN_RATELIMIT and WARN_ONCE may now exceed 80 cols.

Add missing <prefix>_printk type for completeness.