irq_enter/irq_exit undeclared in efi/runtime.c

irq_enter/irq_exit undeclared in efi/runtime.c

[Olaf Hering]

Current xen-unstable fails to compile with gcc 4.6:

runtime.c: In function 'efi_rs_enter':
runtime.c:45:5: error: implicit declaration of function 'irq_enter' [-Werror=implicit-function-declaration]
runtime.c:45:5: error: nested extern declaration of 'irq_enter' [-Werror=nested-externs]
runtime.c: In function 'efi_rs_leave':
runtime.c:75:5: error: implicit declaration of function 'irq_exit' [-Werror=implicit-function-declaration]
runtime.c:75:5: error: nested extern declaration of 'irq_exit' [-Werror=nested-externs]

Olaf

Re: irq_enter/irq_exit undeclared in efi/runtime.c

[Keir Fraser]

On 14/07/2011 11:28, "Olaf Hering" <olaf@aepfle.de> wrote:

> 
> Current xen-unstable fails to compile with gcc 4.6:

Builds for me with 4.6.

 -- Keir

> runtime.c: In function 'efi_rs_enter':
> runtime.c:45:5: error: implicit declaration of function 'irq_enter'
> [-Werror=implicit-function-declaration]
> runtime.c:45:5: error: nested extern declaration of 'irq_enter'
> [-Werror=nested-externs]
> runtime.c: In function 'efi_rs_leave':
> runtime.c:75:5: error: implicit declaration of function 'irq_exit'
> [-Werror=implicit-function-declaration]
> runtime.c:75:5: error: nested extern declaration of 'irq_exit'
> [-Werror=nested-externs]
> 
> Olaf
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

Re: irq_enter/irq_exit undeclared in efi/runtime.c

[Olaf Hering]

On Thu, Jul 14, Keir Fraser wrote:

> On 14/07/2011 11:28, "Olaf Hering" <olaf@aepfle.de> wrote:
> 
> > 
> > Current xen-unstable fails to compile with gcc 4.6:
> 
> Builds for me with 4.6.

Does your build have -Wall? The xen.spec I use has this before the make
call:

export 'CFLAGS=-fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables'

Olaf

Re: irq_enter/irq_exit undeclared in efi/runtime.c

[Keir Fraser]

On 14/07/2011 13:04, "Olaf Hering" <olaf@aepfle.de> wrote:

> On Thu, Jul 14, Keir Fraser wrote:
> 
>> On 14/07/2011 11:28, "Olaf Hering" <olaf@aepfle.de> wrote:
>> 
>>> 
>>> Current xen-unstable fails to compile with gcc 4.6:
>> 
>> Builds for me with 4.6.
> 
> Does your build have -Wall? The xen.spec I use has this before the make
> call:
> 
> export 'CFLAGS=-fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2
> -fstack-protector -funwind-tables -fasynchronous-unwind-tables'

Yes, we always build -Wall. It could be the _FORTIFY_SOURCE=2? I think
that's caused warnings/errors before.

Anyway, in short I think you'll have to send us a sensible-looking patch
that works for you, and we'll apply it.

 -- Keir

> Olaf