From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/6] ARM: make mach/hardware.h optional
Date: Thu, 14 Jul 2011 17:22:19 +0200 [thread overview]
Message-ID: <201107141722.19407.arnd@arndb.de> (raw)
In-Reply-To: <1310489612-8625-1-git-send-email-robherring2@gmail.com>
On Tuesday 12 July 2011, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> Currently, all ARM platforms must have a mach/hardware.h include. This is
> because it is ultimately included by linux/pci.h which is included in many
> places even for !CONFIG_PCI.
>
> This could be fixed simply with an ifdef around the include of mach/hardware.h
> in asm/pci.h. However, in the interest of fixing this for single kernel
> binary builds, this series removes the include of mach/hardware.h outside of
> mach-* and plat-*. What's used from hardware.h is a couple of PCI defines.
> Converting them to variables allows each platform to set the values as needed.
>
> This does not address the inclusion of mach/hardware.h under drivers/*. This
> appears to be mostly older platforms. There could also be some indirect
> inclusions from other mach/* headers.
>
> I've compile tested on most affected ARM platforms.
>
> Changes from v2:
> - Incorporated compile fixes for microblaze from Michal Simek.
> - Added conversion of powerpc to generic pci flag functions.
> - Combined powerpc and microblaze conversion to use
> asm-generic/pci-bridge.h into one commit. Renaming of powerpc pci
> flags functions is separate commit.
> - Changed defaults for PCIBIOS_MIN_IO and PCIBIOS_MIN_MEM to 0x1000 and
> 0x1000000, respectively.
> - Dropped commit moving ARCH_HAS_DMA_SET_COHERENT_MASK defines into
> memory.h. This conflicts with other clean-up work by Nicolas Pitre.
Looks good to me, I'll apply it as soon as I hear back from Russell.
Russell, do you have an opinion on the changes to arch/arm/{include,lib} ?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Rob Herring <robherring2@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Michal Simek <monstr@monstr.eu>,
nico@fluxnic.net, Jesse Barnes <jbarnes@virtuousgeek.org>,
Rob Herring <rob.herring@calxeda.com>,
"Russell King - ARM Linux" <linux@arm.linux.org.uk>
Subject: Re: [PATCH v3 0/6] ARM: make mach/hardware.h optional
Date: Thu, 14 Jul 2011 17:22:19 +0200 [thread overview]
Message-ID: <201107141722.19407.arnd@arndb.de> (raw)
In-Reply-To: <1310489612-8625-1-git-send-email-robherring2@gmail.com>
On Tuesday 12 July 2011, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> Currently, all ARM platforms must have a mach/hardware.h include. This is
> because it is ultimately included by linux/pci.h which is included in many
> places even for !CONFIG_PCI.
>
> This could be fixed simply with an ifdef around the include of mach/hardware.h
> in asm/pci.h. However, in the interest of fixing this for single kernel
> binary builds, this series removes the include of mach/hardware.h outside of
> mach-* and plat-*. What's used from hardware.h is a couple of PCI defines.
> Converting them to variables allows each platform to set the values as needed.
>
> This does not address the inclusion of mach/hardware.h under drivers/*. This
> appears to be mostly older platforms. There could also be some indirect
> inclusions from other mach/* headers.
>
> I've compile tested on most affected ARM platforms.
>
> Changes from v2:
> - Incorporated compile fixes for microblaze from Michal Simek.
> - Added conversion of powerpc to generic pci flag functions.
> - Combined powerpc and microblaze conversion to use
> asm-generic/pci-bridge.h into one commit. Renaming of powerpc pci
> flags functions is separate commit.
> - Changed defaults for PCIBIOS_MIN_IO and PCIBIOS_MIN_MEM to 0x1000 and
> 0x1000000, respectively.
> - Dropped commit moving ARCH_HAS_DMA_SET_COHERENT_MASK defines into
> memory.h. This conflicts with other clean-up work by Nicolas Pitre.
Looks good to me, I'll apply it as soon as I hear back from Russell.
Russell, do you have an opinion on the changes to arch/arm/{include,lib} ?
Arnd
next prev parent reply other threads:[~2011-07-14 15:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 16:53 [PATCH v3 0/6] ARM: make mach/hardware.h optional Rob Herring
2011-07-12 16:53 ` Rob Herring
2011-07-12 16:53 ` [PATCH 1/6] powerpc: rename ppc_pci_*_flags to pci_*_flags Rob Herring
2011-07-12 16:53 ` Rob Herring
2011-07-12 16:53 ` [PATCH 2/6] pci: move microblaze and powerpc pci flag functions into asm-generic Rob Herring
2011-07-12 16:53 ` Rob Herring
2011-07-12 16:53 ` [PATCH 3/6] ARM: remove unnecessary mach/hardware.h includes Rob Herring
2011-07-12 16:53 ` Rob Herring
2011-07-12 16:53 ` [PATCH 4/6] ARM: pci: make pcibios_assign_all_busses use pci_has_flag Rob Herring
2011-07-12 16:53 ` Rob Herring
2011-07-22 15:53 ` Jesse Barnes
2011-07-22 15:53 ` Jesse Barnes
2011-07-12 16:53 ` [PATCH 5/6] ARM: convert PCI defines to variables Rob Herring
2011-07-12 16:53 ` Rob Herring
2011-07-12 16:53 ` [PATCH 6/6] ARM: set vga memory base at run-time Rob Herring
2011-07-12 16:53 ` Rob Herring
2011-07-14 15:22 ` Arnd Bergmann [this message]
2011-07-14 15:22 ` [PATCH v3 0/6] ARM: make mach/hardware.h optional Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107141722.19407.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.