From: Mel Gorman <mgorman@suse.de>
To: Pekka Enberg <penberg@kernel.org>
Cc: Christoph Lameter <cl@linux.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Matt Mackall <mpm@selenic.com>
Subject: Re: [PATCH] mm-slab: allocate kmem_cache with __GFP_REPEAT
Date: Wed, 20 Jul 2011 20:09:33 +0100 [thread overview]
Message-ID: <20110720190933.GN5349@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1107202040240.2847@tiger>
On Wed, Jul 20, 2011 at 08:41:12PM +0300, Pekka Enberg wrote:
> On Wed, 20 Jul 2011, Pekka Enberg wrote:
> >>On Wed, 20 Jul 2011, Eric Dumazet wrote:
> >>>>[PATCH v2] slab: shrinks sizeof(struct kmem_cache)
> >>
> >>On Wed, 20 Jul 2011, Christoph Lameter wrote:
> >>>This will solve the issue for small nr_cpu_ids but those with 4k cpus will
> >>>still have the issue.
> >>>
> >>>Acked-by: Christoph Lameter <cl@linux.com>
> >>
> >>Applied, thanks! Do we still want the __GFP_REPEAT patch from Konstantin
> >>though?
>
> On Wed, 20 Jul 2011, Christoph Lameter wrote:
> >Those with 4k cpus will be thankful I guess.
>
> OTOH, I'm slightly worried that it might mask a real problem with
> GFP_KERNEL not being aggressive enough. Mel?
>
The reproduction case was while memory was under heavy pressure
(swapout was active) and even then only 1 in a 1000 containers were
failing to create due to an order-4 allocation failure. I'm not
convinced we need to increase how aggressive the allocator is for
PAGE_ALLOC_COSTLY_ORDER in general based on this.
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Pekka Enberg <penberg@kernel.org>
Cc: Christoph Lameter <cl@linux.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Matt Mackall <mpm@selenic.com>
Subject: Re: [PATCH] mm-slab: allocate kmem_cache with __GFP_REPEAT
Date: Wed, 20 Jul 2011 20:09:33 +0100 [thread overview]
Message-ID: <20110720190933.GN5349@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1107202040240.2847@tiger>
On Wed, Jul 20, 2011 at 08:41:12PM +0300, Pekka Enberg wrote:
> On Wed, 20 Jul 2011, Pekka Enberg wrote:
> >>On Wed, 20 Jul 2011, Eric Dumazet wrote:
> >>>>[PATCH v2] slab: shrinks sizeof(struct kmem_cache)
> >>
> >>On Wed, 20 Jul 2011, Christoph Lameter wrote:
> >>>This will solve the issue for small nr_cpu_ids but those with 4k cpus will
> >>>still have the issue.
> >>>
> >>>Acked-by: Christoph Lameter <cl@linux.com>
> >>
> >>Applied, thanks! Do we still want the __GFP_REPEAT patch from Konstantin
> >>though?
>
> On Wed, 20 Jul 2011, Christoph Lameter wrote:
> >Those with 4k cpus will be thankful I guess.
>
> OTOH, I'm slightly worried that it might mask a real problem with
> GFP_KERNEL not being aggressive enough. Mel?
>
The reproduction case was while memory was under heavy pressure
(swapout was active) and even then only 1 in a 1000 containers were
failing to create due to an order-4 allocation failure. I'm not
convinced we need to increase how aggressive the allocator is for
PAGE_ALLOC_COSTLY_ORDER in general based on this.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-07-20 19:09 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 12:16 [PATCH] mm-slab: allocate kmem_cache with __GFP_REPEAT Konstantin Khlebnikov
2011-07-20 12:16 ` Konstantin Khlebnikov
2011-07-20 13:14 ` Pekka Enberg
2011-07-20 13:14 ` Pekka Enberg
2011-07-20 13:28 ` Konstantin Khlebnikov
2011-07-20 13:28 ` Konstantin Khlebnikov
2011-07-20 13:42 ` Pekka Enberg
2011-07-20 13:42 ` Pekka Enberg
2011-07-20 13:50 ` Konstantin Khlebnikov
2011-07-20 13:50 ` Konstantin Khlebnikov
2011-07-20 13:53 ` Pekka Enberg
2011-07-20 13:53 ` Pekka Enberg
2011-07-20 15:36 ` Christoph Lameter
2011-07-20 15:36 ` Christoph Lameter
2011-07-20 13:59 ` Konstantin Khlebnikov
2011-07-20 13:59 ` Konstantin Khlebnikov
2011-07-20 13:54 ` Christoph Lameter
2011-07-20 13:54 ` Christoph Lameter
2011-07-20 14:20 ` Mel Gorman
2011-07-20 14:20 ` Mel Gorman
2011-07-20 14:32 ` Konstantin Khlebnikov
2011-07-20 14:32 ` Konstantin Khlebnikov
2011-07-20 14:40 ` Eric Dumazet
2011-07-20 14:40 ` Eric Dumazet
2011-07-20 14:47 ` Konstantin Khlebnikov
2011-07-20 14:47 ` Konstantin Khlebnikov
2011-07-20 13:43 ` Mel Gorman
2011-07-20 13:43 ` Mel Gorman
2011-07-20 13:56 ` Christoph Lameter
2011-07-20 13:56 ` Christoph Lameter
2011-07-20 14:08 ` Eric Dumazet
2011-07-20 14:08 ` Eric Dumazet
2011-07-20 14:52 ` Christoph Lameter
2011-07-20 14:52 ` Christoph Lameter
2011-07-20 15:09 ` Eric Dumazet
2011-07-20 15:09 ` Eric Dumazet
2011-07-20 15:34 ` Christoph Lameter
2011-07-20 15:34 ` Christoph Lameter
2011-07-20 15:56 ` Eric Dumazet
2011-07-20 15:56 ` Eric Dumazet
2011-07-20 16:17 ` Christoph Lameter
2011-07-20 16:17 ` Christoph Lameter
2011-07-20 16:31 ` Eric Dumazet
2011-07-20 16:31 ` Eric Dumazet
2011-07-20 17:04 ` Eric Dumazet
2011-07-20 17:04 ` Eric Dumazet
2011-07-20 17:13 ` Christoph Lameter
2011-07-20 17:13 ` Christoph Lameter
2011-07-20 17:28 ` Pekka Enberg
2011-07-20 17:28 ` Pekka Enberg
2011-07-20 17:37 ` Christoph Lameter
2011-07-20 17:37 ` Christoph Lameter
2011-07-20 17:41 ` Pekka Enberg
2011-07-20 17:41 ` Pekka Enberg
2011-07-20 18:07 ` Matt Mackall
2011-07-20 18:07 ` Matt Mackall
2011-07-21 7:18 ` Konstantin Khlebnikov
2011-07-21 7:18 ` Konstantin Khlebnikov
2011-07-20 19:09 ` Mel Gorman [this message]
2011-07-20 19:09 ` Mel Gorman
2011-07-31 11:41 ` Konstantin Khlebnikov
2011-07-31 11:41 ` Konstantin Khlebnikov
2011-07-31 11:44 ` Pekka Enberg
2011-07-31 11:44 ` Pekka Enberg
2011-07-21 8:43 ` Eric Dumazet
2011-07-21 8:43 ` Eric Dumazet
2011-07-21 15:27 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110720190933.GN5349@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=eric.dumazet@gmail.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.