All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Huang Shijie <b32955@freescale.com>
Cc: arnd@arndb.de, dedekind1@gmail.com,
	linux-mtd@lists.infradead.org, shijie8@gmail.com,
	linux-arm-kernel@lists.infradead.org, LW@KARO-electronics.de
Subject: Re: [PATCH v8 0/3] add the GPMI controller driver for IMX23/IMX28
Date: Thu, 21 Jul 2011 23:50:20 +0200	[thread overview]
Message-ID: <20110721215020.GA25344@pengutronix.de> (raw)
In-Reply-To: <1311230846-26437-1-git-send-email-b32955@freescale.com>

[-- Attachment #1: Type: text/plain, Size: 1974 bytes --]

> The general-purpose media interface(GPMI) controller is a flexible interface
> to up to several NAND flashs.
...
> To Walfram & Artem:
>     About how to disable the JFFS2 to use the OOB:
>     I read the code, and I still have no idea about how to use the ecclayout
>     to do the job. Could you give me some hint? thanks.

Have you checked mxc_nand.c for example? There is

static struct nand_ecclayout nandv1_hw_eccoob_smallpage = {
        .eccbytes = 5,
        .eccpos = {6, 7, 8, 9, 10},
        .oobfree = {{0, 5}, {12, 4}, }
}

defined as one layout. Now, you could define one where oobfree is empty and
eccbytes as big as the oob-area.

> The driver depends on another GPMI-NAND device patch set, you can find them at :
> 	[1] http://lists.infradead.org/pipermail/linux-mtd/2011-July/037033.html
> 	[2] http://lists.infradead.org/pipermail/linux-mtd/2011-July/037031.html
> 	[3] http://lists.infradead.org/pipermail/linux-mtd/2011-July/037032.html
> 	[4] http://lists.infradead.org/pipermail/linux-mtd/2011-July/037034.html
> 
> The driver also depends on another DMA patch by Shawn:
> 	[0] http://lists.infradead.org/pipermail/linux-mtd/2011-June/036820.html

This makes it difficult for testers/reviewers. Please try to get a git-branch
from Freescale or Linaro.

> 	[4] DMA timeout issue. I use the .config created by `make mxs_defconfig`
> 	    and the bug never occur. It seems some other module has impact to the
> 	    DMA.

Sadly, I can't confirm that. DMA timeout happens with my config as well as with
the mxs_defconfig. ubiformat breaks immediately when trying to write.

Problem is that I am away from my dev-machine for a few days. I can do limited
tests remotely but not develop actively right now. But if you need logs...

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 0/3] add the GPMI controller driver for IMX23/IMX28
Date: Thu, 21 Jul 2011 23:50:20 +0200	[thread overview]
Message-ID: <20110721215020.GA25344@pengutronix.de> (raw)
In-Reply-To: <1311230846-26437-1-git-send-email-b32955@freescale.com>

> The general-purpose media interface(GPMI) controller is a flexible interface
> to up to several NAND flashs.
...
> To Walfram & Artem:
>     About how to disable the JFFS2 to use the OOB:
>     I read the code, and I still have no idea about how to use the ecclayout
>     to do the job. Could you give me some hint? thanks.

Have you checked mxc_nand.c for example? There is

static struct nand_ecclayout nandv1_hw_eccoob_smallpage = {
        .eccbytes = 5,
        .eccpos = {6, 7, 8, 9, 10},
        .oobfree = {{0, 5}, {12, 4}, }
}

defined as one layout. Now, you could define one where oobfree is empty and
eccbytes as big as the oob-area.

> The driver depends on another GPMI-NAND device patch set, you can find them at :
> 	[1] http://lists.infradead.org/pipermail/linux-mtd/2011-July/037033.html
> 	[2] http://lists.infradead.org/pipermail/linux-mtd/2011-July/037031.html
> 	[3] http://lists.infradead.org/pipermail/linux-mtd/2011-July/037032.html
> 	[4] http://lists.infradead.org/pipermail/linux-mtd/2011-July/037034.html
> 
> The driver also depends on another DMA patch by Shawn:
> 	[0] http://lists.infradead.org/pipermail/linux-mtd/2011-June/036820.html

This makes it difficult for testers/reviewers. Please try to get a git-branch
from Freescale or Linaro.

> 	[4] DMA timeout issue. I use the .config created by `make mxs_defconfig`
> 	    and the bug never occur. It seems some other module has impact to the
> 	    DMA.

Sadly, I can't confirm that. DMA timeout happens with my config as well as with
the mxs_defconfig. ubiformat breaks immediately when trying to write.

Problem is that I am away from my dev-machine for a few days. I can do limited
tests remotely but not develop actively right now. But if you need logs...

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110721/77ffac8f/attachment-0001.sig>

  parent reply	other threads:[~2011-07-21 21:50 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-21  6:47 [PATCH v8 0/3] add the GPMI controller driver for IMX23/IMX28 Huang Shijie
2011-07-21  6:47 ` Huang Shijie
2011-07-21  6:47 ` [PATCH v8 1/3] MTD : add the common code for GPMI-NAND controller driver Huang Shijie
2011-07-21  6:47   ` Huang Shijie
2011-07-21  6:47 ` [PATCH v8 2/3] MTD : add helper functions library and header files for GPMI NAND driver Huang Shijie
2011-07-21  6:47   ` Huang Shijie
2011-07-21  6:47 ` [PATCH v8 3/3] MTD : add GPMI-NAND driver in the config and Makefile Huang Shijie
2011-07-21  6:47   ` Huang Shijie
2011-07-21 21:50 ` Wolfram Sang [this message]
2011-07-21 21:50   ` [PATCH v8 0/3] add the GPMI controller driver for IMX23/IMX28 Wolfram Sang
2011-07-22  3:30   ` Huang Shijie
2011-07-22  3:30     ` Huang Shijie
2011-07-22  5:57     ` Shawn Guo
2011-07-22  5:57       ` Shawn Guo
2011-07-22  8:07       ` Huang Shijie
2011-07-22  8:07         ` Huang Shijie
2011-07-26 14:29         ` Koen Beel
2011-07-26 14:29           ` Koen Beel
2011-07-27  1:53           ` Huang Shijie
2011-07-27  1:53             ` Huang Shijie
2011-07-28  9:38             ` Koen Beel
2011-07-28  9:38               ` Koen Beel
2011-07-29  7:20               ` Lothar Waßmann
2011-07-29  7:20                 ` Lothar Waßmann
2011-07-29  7:40                 ` Koen Beel
2011-07-29  7:40                   ` Koen Beel
2011-07-29  7:49                   ` Lothar Waßmann
2011-07-29  7:49                     ` Lothar Waßmann
2011-07-29  9:49                   ` Huang Shijie
2011-07-29  9:49                     ` Huang Shijie
2011-07-29 11:48                     ` Koen Beel
2011-07-29 11:48                       ` Koen Beel
2011-08-02  6:19                       ` Huang Shijie
2011-08-02  6:19                         ` Huang Shijie
2011-08-02  7:16                         ` Shawn Guo
2011-08-02  7:16                           ` Shawn Guo
2011-08-02  8:11                         ` Shawn Guo
2011-08-02  8:11                           ` Shawn Guo
2011-08-02  8:12                         ` Shawn Guo
2011-08-02  8:12                           ` Shawn Guo
2011-08-02  8:22                           ` Huang Shijie
2011-08-02  8:22                             ` Huang Shijie
2011-07-29 12:41                   ` Lothar Waßmann
2011-07-29 12:41                     ` Lothar Waßmann
2011-07-29 15:00                     ` Koen Beel
2011-07-29 15:00                       ` Koen Beel
2011-07-31 13:51                       ` Marek Vasut
2011-07-31 13:51                         ` Marek Vasut
2011-08-01 15:14                         ` Koen Beel
2011-08-01 15:14                           ` Koen Beel
2011-08-02  6:37                           ` Huang Shijie
2011-08-02  6:37                             ` Huang Shijie
2011-08-02  7:33                             ` Koen Beel
2011-08-02  7:33                               ` Koen Beel
2011-08-02  7:44                               ` Huang Shijie
2011-08-02  7:44                                 ` Huang Shijie
2011-08-02  8:55                                 ` Koen Beel
2011-08-02  8:55                                   ` Koen Beel
2011-08-02  8:49                               ` Huang Shijie
2011-08-02  8:49                                 ` Huang Shijie
2011-08-02  9:29                                 ` Koen Beel
2011-08-02  9:29                                   ` Koen Beel
2011-08-02 10:37                                   ` Huang Shijie
2011-08-02 10:37                                     ` Huang Shijie
2011-08-02 12:32                                     ` Koen Beel
2011-08-02 12:32                                       ` Koen Beel
2011-08-02  6:21                       ` Huang Shijie
2011-08-02  6:21                         ` Huang Shijie
2011-08-03 10:37                   ` Wolfram Sang
2011-08-03 10:37                     ` Wolfram Sang
2011-08-03 12:00                     ` Koen Beel
2011-08-03 12:00                       ` Koen Beel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110721215020.GA25344@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=LW@KARO-electronics.de \
    --cc=arnd@arndb.de \
    --cc=b32955@freescale.com \
    --cc=dedekind1@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=shijie8@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.