All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Borislav Petkov <bp@amd64.org>
Cc: Ray Lee <ray-lk@madrabbit.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	"Przywara, Andre" <Andre.Przywara@amd.com>,
	"Pohlack, Martin" <Martin.Pohlack@amd.com>
Subject: Re: [PATCH] x86, AMD: Correct F15h IC aliasing issue
Date: Tue, 26 Jul 2011 20:47:44 +0200	[thread overview]
Message-ID: <20110726184744.GA8422@elte.hu> (raw)
In-Reply-To: <20110726183935.GG32536@aftab>


* Borislav Petkov <bp@amd64.org> wrote:

> > Was this done with a stock kernel, or with the simple patch 
> > applied?
> 
> with the simplest version of Linus' patch:
> 
> diff --git a/arch/x86/mm/mmap.c b/arch/x86/mm/mmap.c
> index 1dab519..6b1094d 100644
> --- a/arch/x86/mm/mmap.c
> +++ b/arch/x86/mm/mmap.c
> @@ -90,6 +90,8 @@ static unsigned long mmap_rnd(void)
>                         rnd = (long)get_random_int() % (1<<8);
>                 else
>                         rnd = (long)(get_random_int() % (1<<28));
> +
> +               rnd &= ~0x7;

So, unless i got the stats right, unmodified kernel has like a 75% 
mis-aligned rate, while with the simple fix this goes down to 30%?

Have you run the numbers on the stock, unmodified kernel by any 
chance, just to make sure the stats are ok?

Thanks,

	Ingo

  reply	other threads:[~2011-07-26 18:48 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22 13:15 [PATCH] x86, AMD: Correct F15h IC aliasing issue Borislav Petkov
2011-07-24 11:13 ` Ingo Molnar
2011-07-24 13:40   ` Borislav Petkov
2011-07-24 13:47     ` Ingo Molnar
2011-07-24 16:16     ` Andrew Morton
2011-07-26 18:33     ` Borislav Petkov
2011-07-24 16:04 ` Linus Torvalds
2011-07-24 17:22   ` Borislav Petkov
2011-07-24 17:39     ` Linus Torvalds
2011-07-24 18:12       ` Ingo Molnar
2011-07-24 18:23       ` Borislav Petkov
2011-07-24 18:30         ` Ingo Molnar
2011-07-24 19:07           ` Borislav Petkov
2011-07-24 20:44             ` Ingo Molnar
2011-07-25 20:00               ` Borislav Petkov
2011-07-25 20:06                 ` Ingo Molnar
2011-07-25 21:53                   ` Borislav Petkov
2011-07-26  5:58                     ` Ray Lee
2011-07-26 17:28                       ` Borislav Petkov
2011-07-26 18:34                         ` Ingo Molnar
2011-07-26 18:39                           ` Borislav Petkov
2011-07-26 18:47                             ` Ingo Molnar [this message]
2011-07-26 19:33                               ` Borislav Petkov
2011-07-27 17:10       ` Borislav Petkov
2011-07-27 17:16         ` H. Peter Anvin
2011-07-28 13:44           ` Borislav Petkov
2011-07-28 14:02             ` H. Peter Anvin
2011-07-28 14:13               ` Borislav Petkov
2011-07-28 14:18                 ` H. Peter Anvin
2011-07-28 14:35                   ` Borislav Petkov
2011-07-26 17:59 ` Avi Kivity
2011-07-26 18:13   ` Borislav Petkov
2011-07-26 18:16     ` H. Peter Anvin
2011-07-26 18:37       ` Borislav Petkov
2011-07-26 18:38         ` H. Peter Anvin
2011-07-26 19:42           ` Andre Przywara
2011-07-26 22:34             ` H. Peter Anvin
2011-07-27  4:14             ` Avi Kivity
2011-07-27  6:21               ` Borislav Petkov
2011-07-27  6:59                 ` Ingo Molnar
2011-07-27  9:30                   ` Avi Kivity
2011-07-27 15:37                     ` Borislav Petkov
2011-07-27 15:45                       ` Avi Kivity
2011-07-27 15:49                         ` Borislav Petkov
2011-07-27 15:57                           ` Avi Kivity
2011-07-27 16:42                             ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110726184744.GA8422@elte.hu \
    --to=mingo@elte.hu \
    --cc=Andre.Przywara@amd.com \
    --cc=Martin.Pohlack@amd.com \
    --cc=bp@amd64.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ray-lk@madrabbit.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.