All of lore.kernel.org
 help / color / mirror / Atom feed
From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/3] dt: irq: add interrupt controller descriptor struct
Date: Wed, 10 Aug 2011 14:14:28 +0100	[thread overview]
Message-ID: <20110810131428.GF2680@pulham.picochip.com> (raw)
In-Reply-To: <1312921020-6820-2-git-send-email-robherring2@gmail.com>

On Tue, Aug 09, 2011 at 03:16:58PM -0500, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
> 
> In preparation to scan and initialize interrupt controllers from a
> device-tree, create struct to pass to interrupt controller initialization
> functions.
> 
> irq_base should go away with dynamic linux irq assignment.
> 
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> ---
>  include/linux/of_irq.h |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h
> index cd2e61c..de91ff9 100644
> --- a/include/linux/of_irq.h
> +++ b/include/linux/of_irq.h
> @@ -33,6 +33,12 @@ struct of_irq {
>  	u32 specifier[OF_MAX_IRQ_SPEC]; /* Specifier copy */
>  };
>  
> +struct of_intc_desc {
> +	struct device_node *controller;
> +	struct device_node *parent;

Do we need parent here?  I think that of_irq_find_parent() will do the 
job.

Other than that nit the series looks nice to me.

Jamie

WARNING: multiple messages have this Message-ID (diff)
From: Jamie Iles <jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
To: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [RFC PATCH 1/3] dt: irq: add interrupt controller descriptor struct
Date: Wed, 10 Aug 2011 14:14:28 +0100	[thread overview]
Message-ID: <20110810131428.GF2680@pulham.picochip.com> (raw)
In-Reply-To: <1312921020-6820-2-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Tue, Aug 09, 2011 at 03:16:58PM -0500, Rob Herring wrote:
> From: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> 
> In preparation to scan and initialize interrupt controllers from a
> device-tree, create struct to pass to interrupt controller initialization
> functions.
> 
> irq_base should go away with dynamic linux irq assignment.
> 
> Signed-off-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> ---
>  include/linux/of_irq.h |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h
> index cd2e61c..de91ff9 100644
> --- a/include/linux/of_irq.h
> +++ b/include/linux/of_irq.h
> @@ -33,6 +33,12 @@ struct of_irq {
>  	u32 specifier[OF_MAX_IRQ_SPEC]; /* Specifier copy */
>  };
>  
> +struct of_intc_desc {
> +	struct device_node *controller;
> +	struct device_node *parent;

Do we need parent here?  I think that of_irq_find_parent() will do the 
job.

Other than that nit the series looks nice to me.

Jamie

  reply	other threads:[~2011-08-10 13:14 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09 20:16 [RFC PATCH 0/3] Yet another GIC OF binding series Rob Herring
2011-08-09 20:16 ` Rob Herring
2011-08-09 20:16 ` [RFC PATCH 1/3] dt: irq: add interrupt controller descriptor struct Rob Herring
2011-08-09 20:16   ` Rob Herring
2011-08-10 13:14   ` Jamie Iles [this message]
2011-08-10 13:14     ` Jamie Iles
2011-08-10 13:23     ` Rob Herring
2011-08-10 13:23       ` Rob Herring
2011-08-09 20:16 ` [RFC PATCH 2/3] ARM: gic: allow irq_start to be 0 Rob Herring
2011-08-09 20:16   ` Rob Herring
2011-08-09 20:17 ` [RFC PATCH 3/3] ARM: gic: add OF based initialization Rob Herring
2011-08-09 20:17   ` Rob Herring
2011-08-10  8:08   ` Marc Zyngier
2011-08-10  8:08     ` Marc Zyngier
2011-08-10 18:30     ` Rob Herring
2011-08-10 18:30       ` Rob Herring
2011-08-25 21:49 ` [PATCH v2] " Rob Herring
2011-08-25 21:49   ` Rob Herring
2011-08-26  2:37   ` Rob Herring
2011-08-26  2:37     ` Rob Herring
2011-08-30  3:26 ` [RFC PATCH 0/3] Yet another GIC OF binding series Shawn Guo
2011-08-30  3:26   ` Shawn Guo
2011-09-03 13:34 ` Thomas Abraham
2011-09-03 13:34   ` Thomas Abraham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110810131428.GF2680@pulham.picochip.com \
    --to=jamie@jamieiles.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.