All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	balbi-l0cyMroinI0@public.gmane.org
Cc: "Hilman, Kevin" <khilman-l0cyMroinI0@public.gmane.org>,
	Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>,
	"Cousson, Benoit" <b-cousson-l0cyMroinI0@public.gmane.org>,
	"G, Manjunath Kondaiah" <manjugk-l0cyMroinI0@public.gmane.org>,
	"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	linux-omap <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: How to handle named resources with DT?
Date: Fri, 12 Aug 2011 16:35:42 +0200	[thread overview]
Message-ID: <201108121635.42953.arnd@arndb.de> (raw)
In-Reply-To: <20110812084106.GC19467-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>

On Friday 12 August 2011, Felipe Balbi wrote:
> On Fri, Aug 12, 2011 at 01:02:18PM +1000, David Gibson wrote:
> 
> the whole point of using *byname() is for the driver to not care about
> the order of the resources. So if driver has to provided an ordered list
> of names, what's the benefit ? Sounds really stupid to provide an
> ordered list of names to an ordered list of resources, just to use
> *byname() instead of just assuming the list of resources is already
> ordered.

It only make sense for drivers that support both device tree probing
and legacy probing of static platform devices.

Note how almost all drivers use only platform_get_resource and not
platform_get_resource_byname:

arnd@ocdc-kvm:~/linux-arm$ git grep -wl platform_get_resource | wc -l
565
arnd@ocdc-kvm:~/linux-arm$ git grep -wl platform_get_resource_byname | wc -l
41
arnd@ocdc-kvm:~/linux-arm$ git grep -wl platform_get_resource_byname | xargs grep -wL platform_get_resource | wc -l # both
28
arnd@ocdc-kvm:~/linux-arm$ git grep -wl platform_get_resource_byname | xargs grep -wl platform_get_resource  | wc -l # only _byname
13

I think it's much easier to change the existing users of _byname over
to fixed indexes than to come up with a new scheme that is better.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: How to handle named resources with DT?
Date: Fri, 12 Aug 2011 16:35:42 +0200	[thread overview]
Message-ID: <201108121635.42953.arnd@arndb.de> (raw)
In-Reply-To: <20110812084106.GC19467@legolas.emea.dhcp.ti.com>

On Friday 12 August 2011, Felipe Balbi wrote:
> On Fri, Aug 12, 2011 at 01:02:18PM +1000, David Gibson wrote:
> 
> the whole point of using *byname() is for the driver to not care about
> the order of the resources. So if driver has to provided an ordered list
> of names, what's the benefit ? Sounds really stupid to provide an
> ordered list of names to an ordered list of resources, just to use
> *byname() instead of just assuming the list of resources is already
> ordered.

It only make sense for drivers that support both device tree probing
and legacy probing of static platform devices.

Note how almost all drivers use only platform_get_resource and not
platform_get_resource_byname:

arnd at ocdc-kvm:~/linux-arm$ git grep -wl platform_get_resource | wc -l
565
arnd at ocdc-kvm:~/linux-arm$ git grep -wl platform_get_resource_byname | wc -l
41
arnd at ocdc-kvm:~/linux-arm$ git grep -wl platform_get_resource_byname | xargs grep -wL platform_get_resource | wc -l # both
28
arnd at ocdc-kvm:~/linux-arm$ git grep -wl platform_get_resource_byname | xargs grep -wl platform_get_resource  | wc -l # only _byname
13

I think it's much easier to change the existing users of _byname over
to fixed indexes than to come up with a new scheme that is better.

	Arnd

  parent reply	other threads:[~2011-08-12 14:35 UTC|newest]

Thread overview: 141+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09  9:23 How to handle named resources with DT? Cousson, Benoit
2011-08-09  9:23 ` Cousson, Benoit
2011-08-09 16:29 ` G, Manjunath Kondaiah
2011-08-09 16:29   ` G, Manjunath Kondaiah
2011-08-09 16:57   ` Cousson, Benoit
2011-08-09 16:57     ` Cousson, Benoit
2011-08-09 17:23     ` Grant Likely
2011-08-09 17:23       ` Grant Likely
2011-08-09 17:47       ` Cousson, Benoit
2011-08-09 17:47         ` Cousson, Benoit
2011-08-09 17:52         ` Matt Porter
2011-08-09 17:52           ` Matt Porter
2011-08-09 18:26         ` Scott Wood
2011-08-09 18:26           ` Scott Wood
2011-08-09 20:57           ` Grant Likely
2011-08-09 20:57             ` Grant Likely
     [not found]             ` <20110809205723.GE11568-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-08-09 21:08               ` Cousson, Benoit
2011-08-09 21:08                 ` Cousson, Benoit
2011-08-09 21:17                 ` Grant Likely
2011-08-09 21:17                   ` Grant Likely
2011-08-09 21:44                   ` Cousson, Benoit
2011-08-09 21:44                     ` Cousson, Benoit
2011-08-09 21:49                     ` Grant Likely
2011-08-09 21:49                       ` Grant Likely
2011-08-09 21:53                       ` Cousson, Benoit
2011-08-09 21:53                         ` Cousson, Benoit
2011-08-10  1:52                         ` David Gibson
2011-08-10  1:52                           ` David Gibson
2011-08-10  7:11                           ` Paul Walmsley
2011-08-10  7:11                             ` Paul Walmsley
     [not found]                           ` <20110810015214.GD23511-787xzQ0H9iQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2011-08-10 15:01                             ` Cousson, Benoit
2011-08-10 15:01                               ` Cousson, Benoit
2011-08-10 15:18                           ` Scott Wood
2011-08-10 15:18                             ` Scott Wood
     [not found]                             ` <4E42A14B.9050308-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-08-10 15:21                               ` Cousson, Benoit
2011-08-10 15:21                                 ` Cousson, Benoit
2011-08-10 19:22                           ` Grant Likely
2011-08-10 19:22                             ` Grant Likely
2011-08-10 19:57                             ` David Brown
2011-08-10 19:57                               ` David Brown
2011-08-10 20:12                               ` Grant Likely
2011-08-10 20:12                                 ` Grant Likely
2011-08-11 12:28                             ` Cousson, Benoit
2011-08-11 12:28                               ` Cousson, Benoit
2011-08-12  3:02                               ` David Gibson
2011-08-12  3:02                                 ` David Gibson
     [not found]                                 ` <20110812030218.GP30552-787xzQ0H9iQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2011-08-12  8:14                                   ` Cousson, Benoit
2011-08-12  8:14                                     ` Cousson, Benoit
2011-08-12  8:41                                 ` Felipe Balbi
2011-08-12  8:41                                   ` Felipe Balbi
     [not found]                                   ` <20110812084106.GC19467-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-08-12 14:35                                     ` Arnd Bergmann [this message]
2011-08-12 14:35                                       ` Arnd Bergmann
2011-08-12 15:09                                       ` Cousson, Benoit
2011-08-12 15:09                                         ` Cousson, Benoit
2011-08-12 17:21                                         ` Grant Likely
2011-08-12 17:21                                           ` Grant Likely
2011-08-24 19:15                                           ` Kevin Hilman
2011-08-24 19:15                                             ` Kevin Hilman
2011-08-24 23:16                                             ` Felipe Balbi
2011-08-24 23:16                                               ` Felipe Balbi
     [not found]                                               ` <20110824231613.GC19890-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-08-25 10:28                                                 ` Russell King - ARM Linux
2011-08-25 10:28                                                   ` Russell King - ARM Linux
     [not found]                                                   ` <20110825102824.GB10405-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2011-08-25 15:05                                                     ` Arnd Bergmann
2011-08-25 15:05                                                       ` Arnd Bergmann
2011-08-25 18:16                                                       ` Kevin Hilman
2011-08-25 18:16                                                         ` Kevin Hilman
2011-08-25 21:02                                                         ` Arnd Bergmann
2011-08-25 21:02                                                           ` Arnd Bergmann
2011-08-26 11:01                                                           ` Removing platform_get_resource_byname() (was Re: How to handle named resources with DT?) Paul Walmsley
2011-08-26 11:01                                                             ` Paul Walmsley
2011-08-26 11:01                                                             ` Paul Walmsley
2011-08-26  4:12                                                         ` How to handle named resources with DT? David Gibson
2011-08-26  4:12                                                           ` David Gibson
     [not found]                                                           ` <20110826041200.GD2308-787xzQ0H9iQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2011-08-26 10:58                                                             ` Arnd Bergmann
2011-08-26 10:58                                                               ` Arnd Bergmann
2011-08-26 13:06                                                               ` David Gibson
2011-08-26 13:06                                                                 ` David Gibson
2011-08-26 15:35                                                                 ` Arnd Bergmann
2011-08-26 15:35                                                                   ` Arnd Bergmann
     [not found]                                                                   ` <201108261735.55412.arnd-r2nGTMty4D4@public.gmane.org>
2011-08-26 15:41                                                                     ` Arnd Bergmann
2011-08-26 15:41                                                                       ` Arnd Bergmann
2011-08-27 14:37                                                                       ` David Gibson
2011-08-27 14:37                                                                         ` David Gibson
2011-08-27 18:13                                                                         ` Arnd Bergmann
2011-08-27 18:13                                                                           ` Arnd Bergmann
2011-08-27 19:31                                                                           ` Paul Walmsley
2011-08-27 19:31                                                                             ` Paul Walmsley
2011-08-29 17:16                                                                             ` Arnd Bergmann
2011-08-29 17:16                                                                               ` Arnd Bergmann
2011-08-28  8:39                                                                           ` David Gibson
2011-08-28  8:39                                                                             ` David Gibson
2011-08-28 23:06                                                                             ` Paul Walmsley
2011-08-28 23:06                                                                               ` Paul Walmsley
     [not found]                                                                               ` <alpine.DEB.2.00.1108281100150.23968-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2011-08-28 23:43                                                                                 ` Russell King - ARM Linux
2011-08-28 23:43                                                                                   ` Russell King - ARM Linux
2011-08-29  1:57                                                                               ` Paul Walmsley
2011-08-29  1:57                                                                                 ` Paul Walmsley
2011-08-29 17:18                                                                             ` Arnd Bergmann
2011-08-29 17:18                                                                               ` Arnd Bergmann
2011-08-27 21:47                                                                 ` Paul Walmsley
2011-08-27 21:47                                                                   ` Paul Walmsley
     [not found]                                                                   ` <alpine.DEB.2.00.1108271444240.23968-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2011-08-29 21:54                                                                     ` Mark Brown
2011-08-29 21:54                                                                       ` Mark Brown
2011-08-26 14:13                                                               ` Cousson, Benoit
2011-08-26 14:13                                                                 ` Cousson, Benoit
2011-08-30  2:29                                                                 ` David Gibson
2011-08-30  2:29                                                                   ` David Gibson
2011-08-30  9:27                                                                   ` Felipe Balbi
2011-08-30  9:27                                                                     ` Felipe Balbi
     [not found]                                                                     ` <20110830092722.GG23907-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-08-31  2:32                                                                       ` David Gibson
2011-08-31  2:32                                                                         ` David Gibson
2011-08-27 20:00                                                               ` Paul Walmsley
2011-08-27 20:00                                                                 ` Paul Walmsley
2011-08-25 17:38                                                   ` Cousson, Benoit
2011-08-25 17:38                                                     ` Cousson, Benoit
2011-08-09 21:52                     ` Scott Wood
2011-08-09 21:52                       ` Scott Wood
2011-08-09 20:55         ` Grant Likely
2011-08-09 20:55           ` Grant Likely
2011-08-09 21:06           ` Cousson, Benoit
2011-08-09 21:06             ` Cousson, Benoit
2011-08-09 21:16             ` Grant Likely
2011-08-09 21:16               ` Grant Likely
2011-08-09 21:37               ` Cousson, Benoit
2011-08-09 21:37                 ` Cousson, Benoit
2011-08-12  4:10                 ` Shawn Guo
2011-08-12  4:10                   ` Shawn Guo
2011-08-12  8:56                   ` Cousson, Benoit
2011-08-12  8:56                     ` Cousson, Benoit
2011-08-12 11:47                     ` Shawn Guo
2011-08-12 11:47                       ` Shawn Guo
2011-08-12 14:40                     ` Arnd Bergmann
2011-08-12 14:40                       ` Arnd Bergmann
2011-08-10  1:29       ` David Gibson
2011-08-10  1:29         ` David Gibson
2011-08-10  6:08         ` Paul Walmsley
2011-08-10  6:08           ` Paul Walmsley
2011-08-09 19:51 ` Russell King - ARM Linux
2011-08-09 19:51   ` Russell King - ARM Linux
2011-08-09 20:59   ` Cousson, Benoit
2011-08-09 20:59     ` Cousson, Benoit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108121635.42953.arnd@arndb.de \
    --to=arnd-r2ngtmty4d4@public.gmane.org \
    --cc=b-cousson-l0cyMroinI0@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=khilman-l0cyMroinI0@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=manjugk-l0cyMroinI0@public.gmane.org \
    --cc=paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org \
    --cc=scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.