* [PATCH] staging: rtl8712: remove r8712_cmd_thread()->daemonize()
@ 2011-08-16 18:50 Oleg Nesterov
2011-08-16 19:35 ` Tejun Heo
2011-08-16 21:30 ` Matt Fleming
0 siblings, 2 replies; 4+ messages in thread
From: Oleg Nesterov @ 2011-08-16 18:50 UTC (permalink / raw)
To: Andrew Morton, Larry Finger, Florian Schilhabel,
Greg Kroah-Hartman
Cc: Matt Fleming, Tejun Heo, linux-kernel
daemonize() is only needed when a user-space task does kernel_thread().
r8712_cmd_thread() is kthread_create()'ed and thus it doesn't need
the soon-to-be-deprecated daemonize(). It is the only caller of
thread_enter() which actually does the call.
Note:
- we are going to remove the sigdelset(blocked) code from
allow_signal(), this means that without this patch
thread_enter() can't work after that. Not to mention
daemonize() should be deprecated.
- as a side effect, this patch changes ->comm. Hopefully
this is fine, and padapter->pnetdev->name probably makes
more sense anyway.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
drivers/staging/rtl8712/osdep_service.h | 1 -
1 file changed, 1 deletion(-)
--- 3.1/drivers/staging/rtl8712/osdep_service.h~2_daemonize_rtl8712 2011-07-28 14:06:57.000000000 +0200
+++ 3.1/drivers/staging/rtl8712/osdep_service.h 2011-08-16 20:36:39.000000000 +0200
@@ -203,7 +203,6 @@ static inline unsigned char _cancel_time
static inline void thread_enter(void *context)
{
- daemonize("%s", "RTKTHREAD");
allow_signal(SIGTERM);
}
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: rtl8712: remove r8712_cmd_thread()->daemonize()
2011-08-16 18:50 [PATCH] staging: rtl8712: remove r8712_cmd_thread()->daemonize() Oleg Nesterov
@ 2011-08-16 19:35 ` Tejun Heo
2011-08-16 20:27 ` Larry Finger
2011-08-16 21:30 ` Matt Fleming
1 sibling, 1 reply; 4+ messages in thread
From: Tejun Heo @ 2011-08-16 19:35 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andrew Morton, Larry Finger, Florian Schilhabel,
Greg Kroah-Hartman, Matt Fleming, linux-kernel
On Tue, Aug 16, 2011 at 08:50:57PM +0200, Oleg Nesterov wrote:
> daemonize() is only needed when a user-space task does kernel_thread().
>
> r8712_cmd_thread() is kthread_create()'ed and thus it doesn't need
> the soon-to-be-deprecated daemonize(). It is the only caller of
> thread_enter() which actually does the call.
>
> Note:
> - we are going to remove the sigdelset(blocked) code from
> allow_signal(), this means that without this patch
> thread_enter() can't work after that. Not to mention
> daemonize() should be deprecated.
>
> - as a side effect, this patch changes ->comm. Hopefully
> this is fine, and padapter->pnetdev->name probably makes
> more sense anyway.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: remove r8712_cmd_thread()->daemonize()
2011-08-16 19:35 ` Tejun Heo
@ 2011-08-16 20:27 ` Larry Finger
0 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2011-08-16 20:27 UTC (permalink / raw)
To: Tejun Heo
Cc: Oleg Nesterov, Andrew Morton, Florian Schilhabel,
Greg Kroah-Hartman, Matt Fleming, linux-kernel
On 08/16/2011 02:35 PM, Tejun Heo wrote:
> On Tue, Aug 16, 2011 at 08:50:57PM +0200, Oleg Nesterov wrote:
>> daemonize() is only needed when a user-space task does kernel_thread().
>>
>> r8712_cmd_thread() is kthread_create()'ed and thus it doesn't need
>> the soon-to-be-deprecated daemonize(). It is the only caller of
>> thread_enter() which actually does the call.
>>
>> Note:
>> - we are going to remove the sigdelset(blocked) code from
>> allow_signal(), this means that without this patch
>> thread_enter() can't work after that. Not to mention
>> daemonize() should be deprecated.
>>
>> - as a side effect, this patch changes ->comm. Hopefully
>> this is fine, and padapter->pnetdev->name probably makes
>> more sense anyway.
>>
>> Signed-off-by: Oleg Nesterov<oleg@redhat.com>
>
> Acked-by: Tejun Heo<tj@kernel.org>
Acked-and-tested-by: Larry Finger <Larry.Finger@lwfinger.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: remove r8712_cmd_thread()->daemonize()
2011-08-16 18:50 [PATCH] staging: rtl8712: remove r8712_cmd_thread()->daemonize() Oleg Nesterov
2011-08-16 19:35 ` Tejun Heo
@ 2011-08-16 21:30 ` Matt Fleming
1 sibling, 0 replies; 4+ messages in thread
From: Matt Fleming @ 2011-08-16 21:30 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andrew Morton, Larry Finger, Florian Schilhabel,
Greg Kroah-Hartman, Tejun Heo, linux-kernel
On Tue, 2011-08-16 at 20:50 +0200, Oleg Nesterov wrote:
> daemonize() is only needed when a user-space task does kernel_thread().
>
> r8712_cmd_thread() is kthread_create()'ed and thus it doesn't need
> the soon-to-be-deprecated daemonize(). It is the only caller of
> thread_enter() which actually does the call.
>
> Note:
> - we are going to remove the sigdelset(blocked) code from
> allow_signal(), this means that without this patch
> thread_enter() can't work after that. Not to mention
> daemonize() should be deprecated.
>
> - as a side effect, this patch changes ->comm. Hopefully
> this is fine, and padapter->pnetdev->name probably makes
> more sense anyway.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Matt Fleming <matt.fleming@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-08-16 21:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-16 18:50 [PATCH] staging: rtl8712: remove r8712_cmd_thread()->daemonize() Oleg Nesterov
2011-08-16 19:35 ` Tejun Heo
2011-08-16 20:27 ` Larry Finger
2011-08-16 21:30 ` Matt Fleming
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.