From: Johannes Weiner <jweiner@redhat.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>, Mel Gorman <mgorman@suse.de>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 3/3] compaction accouting fix
Date: Wed, 31 Aug 2011 17:03:00 +0200 [thread overview]
Message-ID: <20110831150300.GC19122@redhat.com> (raw)
In-Reply-To: <20110831145651.GA2198@barrios-desktop>
On Wed, Aug 31, 2011 at 11:56:51PM +0900, Minchan Kim wrote:
> On Wed, Aug 31, 2011 at 01:37:10PM +0200, Johannes Weiner wrote:
> > It's a teensy-bit awkward that isolate_migratepages() can return
> > success without actually isolating any new pages, just because there
> > are still some pages left from a previous run (cc->nr_migratepages is
> > maintained across isolation calls).
>
> If migrate_pages fails, we reset cc->nr_migratepages to zero in compact_zone.
> Am I missing something?
Brainfart on my side, sorry. It's all good, then :)
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <jweiner@redhat.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>, Mel Gorman <mgorman@suse.de>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 3/3] compaction accouting fix
Date: Wed, 31 Aug 2011 17:03:00 +0200 [thread overview]
Message-ID: <20110831150300.GC19122@redhat.com> (raw)
In-Reply-To: <20110831145651.GA2198@barrios-desktop>
On Wed, Aug 31, 2011 at 11:56:51PM +0900, Minchan Kim wrote:
> On Wed, Aug 31, 2011 at 01:37:10PM +0200, Johannes Weiner wrote:
> > It's a teensy-bit awkward that isolate_migratepages() can return
> > success without actually isolating any new pages, just because there
> > are still some pages left from a previous run (cc->nr_migratepages is
> > maintained across isolation calls).
>
> If migrate_pages fails, we reset cc->nr_migratepages to zero in compact_zone.
> Am I missing something?
Brainfart on my side, sorry. It's all good, then :)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-31 15:03 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-12 16:37 [PATCH 0/3] Fix compaction about mlocked pages Minchan Kim
2011-11-12 16:37 ` Minchan Kim
2011-08-29 16:43 ` [PATCH 3/3] compaction accouting fix Minchan Kim
2011-08-29 16:43 ` [PATCH 1/3] Correct isolate_mode_t bitwise type Minchan Kim
2011-08-29 16:43 ` [PATCH 2/3] compaction: compact unevictable page Minchan Kim
2011-10-06 21:54 ` [PATCH 0/3] Fix compaction about mlocked pages Andrew Morton
2011-10-06 21:54 ` Andrew Morton
2011-10-06 23:07 ` Minchan Kim
2011-10-06 23:07 ` Minchan Kim
2011-11-12 16:37 ` [PATCH 1/3] Correct isolate_mode_t bitwise type Minchan Kim
2011-11-12 16:37 ` Minchan Kim
2011-08-30 17:51 ` Rik van Riel
2011-08-30 17:51 ` Rik van Riel
2011-08-31 11:13 ` Johannes Weiner
2011-08-31 11:13 ` Johannes Weiner
2011-09-01 13:05 ` Mel Gorman
2011-09-01 13:05 ` Mel Gorman
2011-09-02 3:29 ` Minchan Kim
2011-09-02 3:29 ` Minchan Kim
2011-11-12 16:37 ` [PATCH 2/3] compaction: compact unevictable page Minchan Kim
2011-11-12 16:37 ` Minchan Kim
2011-08-31 1:09 ` Rik van Riel
2011-08-31 1:09 ` Rik van Riel
2011-08-31 11:19 ` Johannes Weiner
2011-08-31 11:19 ` Johannes Weiner
2011-08-31 14:41 ` Minchan Kim
2011-08-31 14:41 ` Minchan Kim
2011-09-01 14:02 ` Mel Gorman
2011-09-01 14:02 ` Mel Gorman
2011-09-02 4:48 ` Minchan Kim
2011-09-02 4:48 ` Minchan Kim
2011-09-02 13:34 ` Mel Gorman
2011-09-02 13:34 ` Mel Gorman
2011-11-12 16:37 ` [PATCH 3/3] compaction accouting fix Minchan Kim
2011-11-12 16:37 ` Minchan Kim
2011-08-31 11:37 ` Johannes Weiner
2011-08-31 11:37 ` Johannes Weiner
2011-08-31 14:56 ` Minchan Kim
2011-08-31 14:56 ` Minchan Kim
2011-08-31 15:03 ` Johannes Weiner [this message]
2011-08-31 15:03 ` Johannes Weiner
2011-09-01 14:20 ` Mel Gorman
2011-09-01 14:20 ` Mel Gorman
2011-09-02 5:09 ` Minchan Kim
2011-09-02 5:09 ` Minchan Kim
2011-09-02 13:36 ` Mel Gorman
2011-09-02 13:36 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110831150300.GC19122@redhat.com \
--to=jweiner@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.