From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Mans Rullgard <mans.rullgard@linaro.org>
Cc: alsa-devel@alsa-project.org,
Russell King <linux@arm.linux.org.uk>,
Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
linaro-dev@lists.linaro.org, linux-omap@vger.kernel.org,
Liam Girdwood <lrg@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: omap: convert per-board modules to platform drivers
Date: Thu, 8 Sep 2011 09:13:42 -0700 [thread overview]
Message-ID: <20110908161341.GA3098@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1315494354-17597-1-git-send-email-mans.rullgard@linaro.org>
On Thu, Sep 08, 2011 at 04:05:53PM +0100, Mans Rullgard wrote:
> +static struct platform_device omap_soc_audio = {
> + .name = "omap-soc-audio",
> + .id = -1,
> +};
> +
This isn't really accomplishing anything as you're using the same device
name for all boards, it's essentially the same thing as soc-audio just
an OMAP version of that device. Each machine driver should be a
separate platform driver.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: omap: convert per-board modules to platform drivers
Date: Thu, 8 Sep 2011 09:13:42 -0700 [thread overview]
Message-ID: <20110908161341.GA3098@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1315494354-17597-1-git-send-email-mans.rullgard@linaro.org>
On Thu, Sep 08, 2011 at 04:05:53PM +0100, Mans Rullgard wrote:
> +static struct platform_device omap_soc_audio = {
> + .name = "omap-soc-audio",
> + .id = -1,
> +};
> +
This isn't really accomplishing anything as you're using the same device
name for all boards, it's essentially the same thing as soc-audio just
an OMAP version of that device. Each machine driver should be a
separate platform driver.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Mans Rullgard <mans.rullgard@linaro.org>
Cc: linux-omap@vger.kernel.org, linaro-dev@lists.linaro.org,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Jarkko Nikula <jhnikula@gmail.com>, Liam Girdwood <lrg@ti.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: omap: convert per-board modules to platform drivers
Date: Thu, 8 Sep 2011 09:13:42 -0700 [thread overview]
Message-ID: <20110908161341.GA3098@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1315494354-17597-1-git-send-email-mans.rullgard@linaro.org>
On Thu, Sep 08, 2011 at 04:05:53PM +0100, Mans Rullgard wrote:
> +static struct platform_device omap_soc_audio = {
> + .name = "omap-soc-audio",
> + .id = -1,
> +};
> +
This isn't really accomplishing anything as you're using the same device
name for all boards, it's essentially the same thing as soc-audio just
an OMAP version of that device. Each machine driver should be a
separate platform driver.
next prev parent reply other threads:[~2011-09-08 16:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 15:05 [PATCH] ASoC: omap: convert per-board modules to platform drivers Mans Rullgard
2011-09-08 15:05 ` Mans Rullgard
2011-09-08 15:05 ` Mans Rullgard
2011-09-08 15:15 ` Lars-Peter Clausen
2011-09-08 15:15 ` [alsa-devel] " Lars-Peter Clausen
2011-09-08 15:15 ` Lars-Peter Clausen
2011-09-08 15:41 ` Mans Rullgard
2011-09-08 15:41 ` [alsa-devel] " Mans Rullgard
2011-09-08 16:37 ` Mark Brown
2011-09-08 16:37 ` [alsa-devel] " Mark Brown
2011-09-08 16:37 ` Mark Brown
2011-09-08 17:36 ` Mans Rullgard
2011-09-08 17:36 ` [alsa-devel] " Mans Rullgard
2011-09-08 17:36 ` Mans Rullgard
2011-09-08 16:13 ` Mark Brown [this message]
2011-09-08 16:13 ` Mark Brown
2011-09-08 16:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110908161341.GA3098@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lrg@ti.com \
--cc=mans.rullgard@linaro.org \
--cc=tiwai@suse.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.