From: Andrew Morton <akpm@linux-foundation.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Vasiliy Kulikov <segoon@openwall.com>, Tejun Heo <tj@kernel.org>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
containers@lists.osdl.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Nathan Lynch <ntl@pobox.com>,
kernel-hardening@lists.openwall.com,
Oren Laadan <orenl@cs.columbia.edu>,
Daniel Lezcano <dlezcano@fr.ibm.com>,
Glauber Costa <glommer@parallels.com>,
James Bottomley <jbottomley@parallels.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Al Viro <viro@ZenIV.linux.org.uk>,
Pavel Emelyanov <xemul@parallels.com>
Subject: Re: [patch 2/2] fs, proc: Introduce the /proc/<pid>/map_files/ directory v6
Date: Thu, 8 Sep 2011 23:00:20 -0700 [thread overview]
Message-ID: <20110908230020.11f306be.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110909054819.GN28162@sun>
On Fri, 9 Sep 2011 09:48:19 +0400 Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> >
> > <looks at the warning>
> >
> > fs/proc/base.c: In function 'proc_map_files_instantiate':
> > fs/proc/base.c:2348: warning: assignment from incompatible pointer type
> >
> > err, that code will crash at runtime and it isn't trivial to fix.
> > How could this happen?
> >
>
> Hmm. I never saw this warning. (Andrew, I'm still unable to fetch
> your current -mm tree, is there some place other than kernel.org?
Nope, sorry - we're dead in the water at present.
> So the patch is done on top of 3.1-rc3). I guess this warrning is
> from p = flex_array_get(fa, i); ? (since I don't have any warning
> at all).
The warning is from
ei->op.proc_get_link = proc_map_files_get_link;
The lhs has type
union proc_op {
int (*proc_get_link)(struct inode *, struct path *);
and the rhs has type
static int proc_map_files_get_link(struct dentry *dentry, struct path *path)
So we end up passing an inode* to a function which expects a dentry*.
That's in 3.1-rc4. proc_op.proc_get_link() hasn't changed since 3.0 (at least).
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Vasiliy Kulikov <segoon@openwall.com>, Tejun Heo <tj@kernel.org>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
containers@lists.osdl.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Nathan Lynch <ntl@pobox.com>,
kernel-hardening@lists.openwall.com,
Oren Laadan <orenl@cs.columbia.edu>,
Daniel Lezcano <dlezcano@fr.ibm.com>,
Glauber Costa <glommer@parallels.com>,
James Bottomley <jbottomley@parallels.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Al Viro <viro@ZenIV.linux.org.uk>,
Pavel Emelyanov <xemul@parallels.com>
Subject: [kernel-hardening] Re: [patch 2/2] fs, proc: Introduce the /proc/<pid>/map_files/ directory v6
Date: Thu, 8 Sep 2011 23:00:20 -0700 [thread overview]
Message-ID: <20110908230020.11f306be.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110909054819.GN28162@sun>
On Fri, 9 Sep 2011 09:48:19 +0400 Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> >
> > <looks at the warning>
> >
> > fs/proc/base.c: In function 'proc_map_files_instantiate':
> > fs/proc/base.c:2348: warning: assignment from incompatible pointer type
> >
> > err, that code will crash at runtime and it isn't trivial to fix.
> > How could this happen?
> >
>
> Hmm. I never saw this warning. (Andrew, I'm still unable to fetch
> your current -mm tree, is there some place other than kernel.org?
Nope, sorry - we're dead in the water at present.
> So the patch is done on top of 3.1-rc3). I guess this warrning is
> from p = flex_array_get(fa, i); ? (since I don't have any warning
> at all).
The warning is from
ei->op.proc_get_link = proc_map_files_get_link;
The lhs has type
union proc_op {
int (*proc_get_link)(struct inode *, struct path *);
and the rhs has type
static int proc_map_files_get_link(struct dentry *dentry, struct path *path)
So we end up passing an inode* to a function which expects a dentry*.
That's in 3.1-rc4. proc_op.proc_get_link() hasn't changed since 3.0 (at least).
next prev parent reply other threads:[~2011-09-09 6:00 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 7:58 [patch 0/2] Introduce /proc/pid/map_files v6 Cyrill Gorcunov
2011-08-31 7:58 ` [patch 1/2] fs, proc: Make proc_get_link to use dentry instead of inode Cyrill Gorcunov
2011-08-31 7:58 ` [patch 2/2] fs, proc: Introduce the /proc/<pid>/map_files/ directory v6 Cyrill Gorcunov
2011-08-31 9:06 ` Vasiliy Kulikov
2011-08-31 10:12 ` Cyrill Gorcunov
2011-08-31 11:26 ` Cyrill Gorcunov
2011-08-31 14:04 ` Kirill A. Shutemov
2011-08-31 14:09 ` Cyrill Gorcunov
2011-08-31 14:26 ` Cyrill Gorcunov
2011-08-31 22:10 ` Andrew Morton
2011-09-01 3:07 ` Kyle Moffett
2011-09-01 3:07 ` Kyle Moffett
2011-09-01 7:58 ` Pavel Emelyanov
2011-09-01 11:50 ` Tejun Heo
2011-09-01 12:13 ` Pavel Emelyanov
2011-09-01 17:13 ` Tejun Heo
2011-09-02 19:15 ` Matt Helsley
2011-09-02 0:09 ` Matt Helsley
2011-09-01 8:05 ` Cyrill Gorcunov
2011-09-02 16:37 ` Vasiliy Kulikov
2011-09-02 16:37 ` [kernel-hardening] " Vasiliy Kulikov
2011-09-05 18:53 ` Vasiliy Kulikov
2011-09-05 18:53 ` [kernel-hardening] " Vasiliy Kulikov
2011-09-05 19:20 ` Cyrill Gorcunov
2011-09-05 19:20 ` [kernel-hardening] " Cyrill Gorcunov
2011-09-05 19:49 ` Vasiliy Kulikov
2011-09-05 19:49 ` [kernel-hardening] " Vasiliy Kulikov
2011-09-05 20:36 ` Cyrill Gorcunov
2011-09-05 20:36 ` [kernel-hardening] " Cyrill Gorcunov
2011-09-06 10:15 ` Vasiliy Kulikov
2011-09-06 10:15 ` [kernel-hardening] " Vasiliy Kulikov
2011-09-06 16:51 ` Tejun Heo
2011-09-06 16:51 ` [kernel-hardening] " Tejun Heo
2011-09-06 17:29 ` Vasiliy Kulikov
2011-09-06 17:29 ` [kernel-hardening] " Vasiliy Kulikov
2011-09-06 17:33 ` Tejun Heo
2011-09-06 17:33 ` [kernel-hardening] " Tejun Heo
2011-09-06 18:15 ` Cyrill Gorcunov
2011-09-06 18:15 ` [kernel-hardening] " Cyrill Gorcunov
[not found] ` <20110906173341.GM18425-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2011-09-07 11:23 ` Vasiliy Kulikov
2011-09-07 11:23 ` [kernel-hardening] " Vasiliy Kulikov
2011-09-07 21:53 ` Cyrill Gorcunov
2011-09-07 21:53 ` [kernel-hardening] " Cyrill Gorcunov
2011-09-07 22:13 ` Andrew Morton
2011-09-07 22:13 ` Andrew Morton
2011-09-07 22:13 ` [kernel-hardening] " Andrew Morton
2011-09-07 22:42 ` Cyrill Gorcunov
2011-09-07 22:42 ` [kernel-hardening] " Cyrill Gorcunov
2011-09-07 22:53 ` Andrew Morton
2011-09-07 22:53 ` Andrew Morton
2011-09-07 22:53 ` [kernel-hardening] " Andrew Morton
2011-09-08 5:48 ` Cyrill Gorcunov
2011-09-08 5:48 ` [kernel-hardening] " Cyrill Gorcunov
2011-09-08 5:50 ` Cyrill Gorcunov
2011-09-08 5:50 ` [kernel-hardening] " Cyrill Gorcunov
2011-09-08 6:04 ` Cyrill Gorcunov
2011-09-08 6:04 ` [kernel-hardening] " Cyrill Gorcunov
2011-09-08 23:52 ` Andrew Morton
2011-09-08 23:52 ` Andrew Morton
2011-09-08 23:52 ` [kernel-hardening] " Andrew Morton
2011-09-09 0:24 ` Pavel Emelyanov
2011-09-09 0:24 ` [kernel-hardening] " Pavel Emelyanov
2011-09-09 5:48 ` Cyrill Gorcunov
2011-09-09 5:48 ` [kernel-hardening] " Cyrill Gorcunov
2011-09-09 6:00 ` Andrew Morton [this message]
2011-09-09 6:00 ` Andrew Morton
2011-09-09 6:22 ` Cyrill Gorcunov
2011-09-09 6:22 ` [kernel-hardening] " Cyrill Gorcunov
2011-09-10 13:21 ` Vasiliy Kulikov
2011-09-10 13:49 ` Cyrill Gorcunov
2011-09-01 10:46 ` Cyrill Gorcunov
2011-09-01 22:49 ` Andrew Morton
2011-09-01 23:04 ` Tejun Heo
2011-09-02 5:54 ` Cyrill Gorcunov
2011-09-02 5:53 ` Cyrill Gorcunov
2011-08-31 22:50 ` Andrew Morton
2011-09-02 1:54 ` Nicholas Miell
2011-09-02 1:58 ` Tejun Heo
2011-09-02 2:04 ` Nicholas Miell
2011-09-02 2:29 ` Tejun Heo
2011-09-02 8:07 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110908230020.11f306be.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=containers@lists.osdl.org \
--cc=dlezcano@fr.ibm.com \
--cc=glommer@parallels.com \
--cc=gorcunov@gmail.com \
--cc=jbottomley@parallels.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntl@pobox.com \
--cc=orenl@cs.columbia.edu \
--cc=segoon@openwall.com \
--cc=tj@kernel.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.