From: Wolfram Sang <w.sang@pengutronix.de>
To: Roy Zang <tie-fei.zang@freescale.com>
Cc: linux-mmc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
akpm@linux-foundation.org, cbouatmailru@gmail.com,
Xu lei <B33228@freescale.com>,
Kumar Gala <galak@kernel.crashing.org>
Subject: Re: [PATCH] eSDHC: Access Freescale eSDHC registers by 32-bit
Date: Fri, 9 Sep 2011 13:40:04 +0200 [thread overview]
Message-ID: <20110909114004.GP1912@pengutronix.de> (raw)
In-Reply-To: <1315569946-21386-1-git-send-email-tie-fei.zang@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]
Hi,
On Fri, Sep 09, 2011 at 08:05:46PM +0800, Roy Zang wrote:
> From: Xu lei <B33228@freescale.com>
>
> Freescale eSDHC registers only support 32-bit accesses,
> this patch ensures that all Freescale eSDHC register accesses
> are 32-bit.
So, what about the byte-swapping that Anton needed? You are simply
removing that if I am not mistaken.
> Signed-off-by: Xu lei <B33228@freescale.com>
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> This is a patch resend
> http://patchwork.ozlabs.org/patch/106245/
> based on latest Linus tree.
>
> Andrew,
> Could you help to pick up this patch first?
mmc-list is not dead, it must go via Chris, I'd think.
> drivers/mmc/host/sdhci-of-esdhc.c | 18 ++++++++++++++----
> 1 files changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index fe604df..40036f6 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -1,7 +1,7 @@
> /*
> * Freescale eSDHC controller driver.
> *
> - * Copyright (c) 2007 Freescale Semiconductor, Inc.
> + * Copyright (c) 2007, 2010 Freescale Semiconductor, Inc.
I wonder if such a small change has impact on the copyright.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <w.sang@pengutronix.de>
To: Roy Zang <tie-fei.zang@freescale.com>
Cc: Xu lei <B33228@freescale.com>,
linux-mmc@vger.kernel.org, akpm@linux-foundation.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] eSDHC: Access Freescale eSDHC registers by 32-bit
Date: Fri, 9 Sep 2011 13:40:04 +0200 [thread overview]
Message-ID: <20110909114004.GP1912@pengutronix.de> (raw)
In-Reply-To: <1315569946-21386-1-git-send-email-tie-fei.zang@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]
Hi,
On Fri, Sep 09, 2011 at 08:05:46PM +0800, Roy Zang wrote:
> From: Xu lei <B33228@freescale.com>
>
> Freescale eSDHC registers only support 32-bit accesses,
> this patch ensures that all Freescale eSDHC register accesses
> are 32-bit.
So, what about the byte-swapping that Anton needed? You are simply
removing that if I am not mistaken.
> Signed-off-by: Xu lei <B33228@freescale.com>
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> This is a patch resend
> http://patchwork.ozlabs.org/patch/106245/
> based on latest Linus tree.
>
> Andrew,
> Could you help to pick up this patch first?
mmc-list is not dead, it must go via Chris, I'd think.
> drivers/mmc/host/sdhci-of-esdhc.c | 18 ++++++++++++++----
> 1 files changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index fe604df..40036f6 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -1,7 +1,7 @@
> /*
> * Freescale eSDHC controller driver.
> *
> - * Copyright (c) 2007 Freescale Semiconductor, Inc.
> + * Copyright (c) 2007, 2010 Freescale Semiconductor, Inc.
I wonder if such a small change has impact on the copyright.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-09-09 11:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 12:05 [PATCH] eSDHC: Access Freescale eSDHC registers by 32-bit Roy Zang
2011-09-09 12:05 ` Roy Zang
2011-09-09 11:40 ` Wolfram Sang [this message]
2011-09-09 11:40 ` Wolfram Sang
2011-09-09 12:16 ` Zang Roy-R61911
2011-09-09 12:16 ` Zang Roy-R61911
2011-09-09 12:23 ` Zang Roy-R61911
2011-09-09 12:23 ` Zang Roy-R61911
2011-09-09 12:33 ` Wolfram Sang
2011-09-09 12:33 ` Wolfram Sang
2011-09-09 12:48 ` Zang Roy-R61911
2011-09-09 12:48 ` Zang Roy-R61911
2011-09-09 13:08 ` Wolfram Sang
2011-09-09 13:08 ` Wolfram Sang
2011-09-13 4:10 ` Zang Roy-R61911
2011-09-13 4:10 ` Zang Roy-R61911
2011-09-09 14:07 ` Anton Vorontsov
2011-09-09 14:07 ` Anton Vorontsov
2011-09-09 16:00 ` Zang Roy-R61911
2011-09-09 16:00 ` Zang Roy-R61911
2011-09-21 17:53 ` Chris Ball
2011-09-21 17:53 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110909114004.GP1912@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=B33228@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=cbouatmailru@gmail.com \
--cc=galak@kernel.crashing.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tie-fei.zang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.