From: Wolfram Sang <w.sang@pengutronix.de>
To: Zang Roy-R61911 <r61911@freescale.com>
Cc: "cjb@laptop.org" <cjb@laptop.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"cbouatmailru@gmail.com" <cbouatmailru@gmail.com>,
Xu Lei-B33228 <B33228@freescale.com>,
Kumar Gala <galak@kernel.crashing.org>
Subject: Re: [PATCH] eSDHC: Access Freescale eSDHC registers by 32-bit
Date: Fri, 9 Sep 2011 15:08:55 +0200 [thread overview]
Message-ID: <20110909130855.GR1912@pengutronix.de> (raw)
In-Reply-To: <2239AC579C7D3646A720227A37E026811A2311@039-SN1MPN1-005.039d.mgd.msft.net>
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
> Previously, I sent this patch together with another one. But
> technically they are separated patches. I got some comments from
> Anton about the patch. I will try to address the comment. but for this
> one, it is a stand along patch. I'd like to push it first.
Okay.
> I do not see any comment about byte swapping about this patch.
> you may have mis-understanding here.
I was misguided, yes, sorry. BE/LE issues with additional byteswapping
are a mind twister :/ Having a second look, it looks okay to me. One
could think about putting this into sdhci_platform as well, but this can
be done later if needed. Sadly, I currently don't have hardware to test
it.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <w.sang@pengutronix.de>
To: Zang Roy-R61911 <r61911@freescale.com>
Cc: Xu Lei-B33228 <B33228@freescale.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"cjb@laptop.org" <cjb@laptop.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] eSDHC: Access Freescale eSDHC registers by 32-bit
Date: Fri, 9 Sep 2011 15:08:55 +0200 [thread overview]
Message-ID: <20110909130855.GR1912@pengutronix.de> (raw)
In-Reply-To: <2239AC579C7D3646A720227A37E026811A2311@039-SN1MPN1-005.039d.mgd.msft.net>
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
> Previously, I sent this patch together with another one. But
> technically they are separated patches. I got some comments from
> Anton about the patch. I will try to address the comment. but for this
> one, it is a stand along patch. I'd like to push it first.
Okay.
> I do not see any comment about byte swapping about this patch.
> you may have mis-understanding here.
I was misguided, yes, sorry. BE/LE issues with additional byteswapping
are a mind twister :/ Having a second look, it looks okay to me. One
could think about putting this into sdhci_platform as well, but this can
be done later if needed. Sadly, I currently don't have hardware to test
it.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-09-09 13:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 12:05 [PATCH] eSDHC: Access Freescale eSDHC registers by 32-bit Roy Zang
2011-09-09 12:05 ` Roy Zang
2011-09-09 11:40 ` Wolfram Sang
2011-09-09 11:40 ` Wolfram Sang
2011-09-09 12:16 ` Zang Roy-R61911
2011-09-09 12:16 ` Zang Roy-R61911
2011-09-09 12:23 ` Zang Roy-R61911
2011-09-09 12:23 ` Zang Roy-R61911
2011-09-09 12:33 ` Wolfram Sang
2011-09-09 12:33 ` Wolfram Sang
2011-09-09 12:48 ` Zang Roy-R61911
2011-09-09 12:48 ` Zang Roy-R61911
2011-09-09 13:08 ` Wolfram Sang [this message]
2011-09-09 13:08 ` Wolfram Sang
2011-09-13 4:10 ` Zang Roy-R61911
2011-09-13 4:10 ` Zang Roy-R61911
2011-09-09 14:07 ` Anton Vorontsov
2011-09-09 14:07 ` Anton Vorontsov
2011-09-09 16:00 ` Zang Roy-R61911
2011-09-09 16:00 ` Zang Roy-R61911
2011-09-21 17:53 ` Chris Ball
2011-09-21 17:53 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110909130855.GR1912@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=B33228@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=cbouatmailru@gmail.com \
--cc=cjb@laptop.org \
--cc=galak@kernel.crashing.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r61911@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.