From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: Avi Kivity <avi@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] KVM: emulate lapic tsc deadline timer for hvm
Date: Fri, 9 Sep 2011 09:56:35 -0300 [thread overview]
Message-ID: <20110909125635.GA10198@amt.cnet> (raw)
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E24C6E20682@shsmsx502.ccr.corp.intel.com>
On Fri, Sep 09, 2011 at 01:12:51AM +0800, Liu, Jinsong wrote:
> >>> --- a/arch/x86/include/asm/msr-index.h
> >>> +++ b/arch/x86/include/asm/msr-index.h
> >>> @@ -229,6 +229,8 @@
> >>> #define MSR_IA32_APICBASE_ENABLE (1<<11)
> >>> #define MSR_IA32_APICBASE_BASE (0xfffff<<12)
> >>>
> >>> +#define MSR_IA32_TSCDEADLINE 0x000006e0
> >>> +
> >>> #define MSR_IA32_UCODE_WRITE 0x00000079
> >>> #define MSR_IA32_UCODE_REV 0x0000008b
> >>
> >> Need to add to msrs_to_save so live migration works.
> >
> > MSR must be explicitly listed in qemu, also.
> >
>
> Marcelo, seems MSR don't need explicitly list in qemu?
> KVM side adding MSR_IA32_TSCDEADLINE to msrs_to_save is enough. Qemu will get it through KVM_GET_MSR_INDEX_LIST.
> Do I miss something?
Notice in target-i386/kvm.c the KVM_GET_MSR_INDEX_LIST list is only used
for MSR_STAR/MSR_HSAVE_PA presence detection.
Do you do need to explicitly add MSR_IA32_TSCDEADLINE to
kvm_get_msrs/kvm_put_msrs routines.
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: Avi Kivity <avi@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm
Date: Fri, 9 Sep 2011 09:56:35 -0300 [thread overview]
Message-ID: <20110909125635.GA10198@amt.cnet> (raw)
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E24C6E20682@shsmsx502.ccr.corp.intel.com>
On Fri, Sep 09, 2011 at 01:12:51AM +0800, Liu, Jinsong wrote:
> >>> --- a/arch/x86/include/asm/msr-index.h
> >>> +++ b/arch/x86/include/asm/msr-index.h
> >>> @@ -229,6 +229,8 @@
> >>> #define MSR_IA32_APICBASE_ENABLE (1<<11)
> >>> #define MSR_IA32_APICBASE_BASE (0xfffff<<12)
> >>>
> >>> +#define MSR_IA32_TSCDEADLINE 0x000006e0
> >>> +
> >>> #define MSR_IA32_UCODE_WRITE 0x00000079
> >>> #define MSR_IA32_UCODE_REV 0x0000008b
> >>
> >> Need to add to msrs_to_save so live migration works.
> >
> > MSR must be explicitly listed in qemu, also.
> >
>
> Marcelo, seems MSR don't need explicitly list in qemu?
> KVM side adding MSR_IA32_TSCDEADLINE to msrs_to_save is enough. Qemu will get it through KVM_GET_MSR_INDEX_LIST.
> Do I miss something?
Notice in target-i386/kvm.c the KVM_GET_MSR_INDEX_LIST list is only used
for MSR_STAR/MSR_HSAVE_PA presence detection.
Do you do need to explicitly add MSR_IA32_TSCDEADLINE to
kvm_get_msrs/kvm_put_msrs routines.
next prev parent reply other threads:[~2011-09-09 12:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 4:19 [PATCH] KVM: emulate lapic tsc deadline timer for hvm Liu, Jinsong
2011-08-17 4:19 ` [Qemu-devel] " Liu, Jinsong
2011-08-22 9:18 ` Avi Kivity
2011-08-22 9:18 ` [Qemu-devel] " Avi Kivity
2011-08-23 10:47 ` Marcelo Tosatti
2011-08-23 10:47 ` [Qemu-devel] " Marcelo Tosatti
2011-08-29 6:47 ` Tian, Kevin
2011-08-29 6:47 ` [Qemu-devel] " Tian, Kevin
2011-09-06 11:21 ` Liu, Jinsong
2011-09-06 11:21 ` [Qemu-devel] " Liu, Jinsong
2011-09-08 17:12 ` Liu, Jinsong
2011-09-08 17:12 ` [Qemu-devel] " Liu, Jinsong
2011-09-09 12:56 ` Marcelo Tosatti [this message]
2011-09-09 12:56 ` Marcelo Tosatti
2011-09-09 18:11 ` Liu, Jinsong
2011-09-09 18:11 ` [Qemu-devel] " Liu, Jinsong
2011-09-09 18:36 ` Marcelo Tosatti
2011-09-09 18:36 ` [Qemu-devel] " Marcelo Tosatti
2011-09-09 18:47 ` Liu, Jinsong
2011-09-09 18:47 ` [Qemu-devel] " Liu, Jinsong
2011-09-09 18:21 ` Liu, Jinsong
2011-09-09 18:21 ` [Qemu-devel] " Liu, Jinsong
2011-09-06 11:18 ` Liu, Jinsong
2011-09-06 11:18 ` [Qemu-devel] " Liu, Jinsong
2011-09-06 11:26 ` Avi Kivity
2011-09-06 11:26 ` [Qemu-devel] " Avi Kivity
2011-09-07 16:45 ` Liu, Jinsong
2011-09-07 16:45 ` [Qemu-devel] " Liu, Jinsong
2011-09-07 17:06 ` Avi Kivity
2011-09-07 17:06 ` [Qemu-devel] " Avi Kivity
2011-09-07 17:33 ` Liu, Jinsong
2011-09-07 17:33 ` [Qemu-devel] " Liu, Jinsong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110909125635.GA10198@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=jinsong.liu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.