From: Avi Kivity <avi@redhat.com>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: emulate lapic tsc deadline timer for hvm
Date: Wed, 07 Sep 2011 20:06:00 +0300 [thread overview]
Message-ID: <4E67A478.9030505@redhat.com> (raw)
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E24C18D2696@shsmsx502.ccr.corp.intel.com>
On 09/07/2011 07:45 PM, Liu, Jinsong wrote:
> Avi Kivity wrote:
> >>
> >> --- a/arch/x86/include/asm/msr-index.h
> >> +++ b/arch/x86/include/asm/msr-index.h
> >> @@ -229,6 +229,8 @@
> >> #define MSR_IA32_APICBASE_ENABLE (1<<11)
> >> #define MSR_IA32_APICBASE_BASE (0xfffff<<12)
> >>
> >> +#define MSR_IA32_TSCDEADLINE 0x000006e0
> >> +
> >> #define MSR_IA32_UCODE_WRITE 0x00000079
> >> #define MSR_IA32_UCODE_REV 0x0000008b
> >>
> >
> > Need to add to msrs_to_save so live migration works.
> >
>
> 2 questions:
> 1). how about add to emulated_msrs instead of msrs_to_save? msrs_to_save modified at runtime and depend on capacibility of host cpu.
Look at kvm_init_msrs_list(), it does the checks.
> 2). do we need add code at qemu (kvm_get_msrs/ kvm_put_msrs) to expose MSR_IA32_TSCDEADLINE to userspace?
>
It should be automatic. Better check it though that you can
live-migrate a guest that uses TSC deadline. Please add a testcase to
kvm-unit-tests.git (there's x86/apic.c, can probably be added there easily).
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm
Date: Wed, 07 Sep 2011 20:06:00 +0300 [thread overview]
Message-ID: <4E67A478.9030505@redhat.com> (raw)
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E24C18D2696@shsmsx502.ccr.corp.intel.com>
On 09/07/2011 07:45 PM, Liu, Jinsong wrote:
> Avi Kivity wrote:
> >>
> >> --- a/arch/x86/include/asm/msr-index.h
> >> +++ b/arch/x86/include/asm/msr-index.h
> >> @@ -229,6 +229,8 @@
> >> #define MSR_IA32_APICBASE_ENABLE (1<<11)
> >> #define MSR_IA32_APICBASE_BASE (0xfffff<<12)
> >>
> >> +#define MSR_IA32_TSCDEADLINE 0x000006e0
> >> +
> >> #define MSR_IA32_UCODE_WRITE 0x00000079
> >> #define MSR_IA32_UCODE_REV 0x0000008b
> >>
> >
> > Need to add to msrs_to_save so live migration works.
> >
>
> 2 questions:
> 1). how about add to emulated_msrs instead of msrs_to_save? msrs_to_save modified at runtime and depend on capacibility of host cpu.
Look at kvm_init_msrs_list(), it does the checks.
> 2). do we need add code at qemu (kvm_get_msrs/ kvm_put_msrs) to expose MSR_IA32_TSCDEADLINE to userspace?
>
It should be automatic. Better check it though that you can
live-migrate a guest that uses TSC deadline. Please add a testcase to
kvm-unit-tests.git (there's x86/apic.c, can probably be added there easily).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-09-07 17:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 4:19 [PATCH] KVM: emulate lapic tsc deadline timer for hvm Liu, Jinsong
2011-08-17 4:19 ` [Qemu-devel] " Liu, Jinsong
2011-08-22 9:18 ` Avi Kivity
2011-08-22 9:18 ` [Qemu-devel] " Avi Kivity
2011-08-23 10:47 ` Marcelo Tosatti
2011-08-23 10:47 ` [Qemu-devel] " Marcelo Tosatti
2011-08-29 6:47 ` Tian, Kevin
2011-08-29 6:47 ` [Qemu-devel] " Tian, Kevin
2011-09-06 11:21 ` Liu, Jinsong
2011-09-06 11:21 ` [Qemu-devel] " Liu, Jinsong
2011-09-08 17:12 ` Liu, Jinsong
2011-09-08 17:12 ` [Qemu-devel] " Liu, Jinsong
2011-09-09 12:56 ` Marcelo Tosatti
2011-09-09 12:56 ` [Qemu-devel] " Marcelo Tosatti
2011-09-09 18:11 ` Liu, Jinsong
2011-09-09 18:11 ` [Qemu-devel] " Liu, Jinsong
2011-09-09 18:36 ` Marcelo Tosatti
2011-09-09 18:36 ` [Qemu-devel] " Marcelo Tosatti
2011-09-09 18:47 ` Liu, Jinsong
2011-09-09 18:47 ` [Qemu-devel] " Liu, Jinsong
2011-09-09 18:21 ` Liu, Jinsong
2011-09-09 18:21 ` [Qemu-devel] " Liu, Jinsong
2011-09-06 11:18 ` Liu, Jinsong
2011-09-06 11:18 ` [Qemu-devel] " Liu, Jinsong
2011-09-06 11:26 ` Avi Kivity
2011-09-06 11:26 ` [Qemu-devel] " Avi Kivity
2011-09-07 16:45 ` Liu, Jinsong
2011-09-07 16:45 ` [Qemu-devel] " Liu, Jinsong
2011-09-07 17:06 ` Avi Kivity [this message]
2011-09-07 17:06 ` Avi Kivity
2011-09-07 17:33 ` Liu, Jinsong
2011-09-07 17:33 ` [Qemu-devel] " Liu, Jinsong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E67A478.9030505@redhat.com \
--to=avi@redhat.com \
--cc=jinsong.liu@intel.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.