From: Arnd Bergmann <arnd@arndb.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: alsa-devel@alsa-project.org,
Jassi Brar <jassisinghbrar@gmail.com>,
linaro-dev@lists.linaro.org, Tony Lindgren <tony@atomide.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-kernel@vger.kernel.org,
Mans Rullgard <mans.rullgard@linaro.org>,
Grant Likely <grant.likely@secretlab.ca>,
Takashi Iwai <tiwai@suse.de>,
linux-omap@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ASoC: omap: convert per-board modules to platform drivers
Date: Sat, 10 Sep 2011 22:37:15 +0200 [thread overview]
Message-ID: <201109102237.15193.arnd@arndb.de> (raw)
In-Reply-To: <20110909205645.GA16355@n2100.arm.linux.org.uk>
On Friday 09 September 2011, Russell King - ARM Linux wrote:
> That's just twisted and utterly insane - adding more code for precisely
> zero benefit what so ever. Think about it - the device tree is already
> creating platform devices for entries in the device tree file. What's
> the point of having this special ASoC code look up the platform compatible
> property in a table of strings to find a different string to manually
> create a device with. Why not just add the bloody device to the DT
> file in the first place? That's partly what DT is there for - to create
> platform specific struct devices.
Exactly. No driver or (worse) user program should ever need to look at
the top-level compatible property. When you want information about a
localized part of the system (e.g. the ASoC components), you should
look up the information for that component.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ASoC: omap: convert per-board modules to platform drivers
Date: Sat, 10 Sep 2011 22:37:15 +0200 [thread overview]
Message-ID: <201109102237.15193.arnd@arndb.de> (raw)
In-Reply-To: <20110909205645.GA16355@n2100.arm.linux.org.uk>
On Friday 09 September 2011, Russell King - ARM Linux wrote:
> That's just twisted and utterly insane - adding more code for precisely
> zero benefit what so ever. Think about it - the device tree is already
> creating platform devices for entries in the device tree file. What's
> the point of having this special ASoC code look up the platform compatible
> property in a table of strings to find a different string to manually
> create a device with. Why not just add the bloody device to the DT
> file in the first place? That's partly what DT is there for - to create
> platform specific struct devices.
Exactly. No driver or (worse) user program should ever need to look at
the top-level compatible property. When you want information about a
localized part of the system (e.g. the ASoC components), you should
look up the information for that component.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: "Russell King - ARM Linux" <linux@arm.linux.org.uk>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Grant Likely <grant.likely@secretlab.ca>,
alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
Tony Lindgren <tony@atomide.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>, Jarkko Nikula <jhnikula@gmail.com>,
linaro-dev@lists.linaro.org, linux-omap@vger.kernel.org,
Mans Rullgard <mans.rullgard@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ASoC: omap: convert per-board modules to platform drivers
Date: Sat, 10 Sep 2011 22:37:15 +0200 [thread overview]
Message-ID: <201109102237.15193.arnd@arndb.de> (raw)
In-Reply-To: <20110909205645.GA16355@n2100.arm.linux.org.uk>
On Friday 09 September 2011, Russell King - ARM Linux wrote:
> That's just twisted and utterly insane - adding more code for precisely
> zero benefit what so ever. Think about it - the device tree is already
> creating platform devices for entries in the device tree file. What's
> the point of having this special ASoC code look up the platform compatible
> property in a table of strings to find a different string to manually
> create a device with. Why not just add the bloody device to the DT
> file in the first place? That's partly what DT is there for - to create
> platform specific struct devices.
Exactly. No driver or (worse) user program should ever need to look at
the top-level compatible property. When you want information about a
localized part of the system (e.g. the ASoC components), you should
look up the information for that component.
Arnd
next prev parent reply other threads:[~2011-09-10 20:37 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 17:34 [PATCH v2] ASoC: omap: convert per-board modules to platform drivers Mans Rullgard
2011-09-08 17:34 ` Mans Rullgard
2011-09-08 17:34 ` Mans Rullgard
2011-09-08 18:17 ` Jassi Brar
2011-09-08 18:17 ` Jassi Brar
2011-09-08 18:18 ` Mark Brown
2011-09-08 18:18 ` Mark Brown
2011-09-08 18:18 ` Mark Brown
2011-09-08 18:35 ` Jassi Brar
2011-09-08 18:35 ` Jassi Brar
2011-09-08 19:08 ` Mans Rullgard
2011-09-08 19:08 ` Mans Rullgard
2011-09-08 19:05 ` Mans Rullgard
2011-09-08 19:05 ` Mans Rullgard
2011-09-08 19:17 ` Jassi Brar
2011-09-08 19:17 ` Jassi Brar
2011-09-08 19:26 ` Mans Rullgard
2011-09-08 19:26 ` Mans Rullgard
2011-09-08 19:26 ` Mans Rullgard
2011-09-08 20:28 ` Arnd Bergmann
2011-09-08 20:28 ` Arnd Bergmann
2011-09-08 20:28 ` Arnd Bergmann
2011-09-08 22:29 ` Mark Brown
2011-09-08 22:29 ` Mark Brown
2011-09-08 22:29 ` Mark Brown
2011-09-08 22:37 ` Russell King - ARM Linux
2011-09-08 22:37 ` Russell King - ARM Linux
2011-09-08 22:37 ` Russell King - ARM Linux
2011-09-08 22:47 ` Mark Brown
2011-09-08 22:47 ` Mark Brown
2011-09-08 22:47 ` Mark Brown
2011-09-08 23:01 ` Russell King - ARM Linux
2011-09-08 23:01 ` Russell King - ARM Linux
2011-09-08 23:01 ` Russell King - ARM Linux
2011-09-08 23:59 ` Mark Brown
2011-09-08 23:59 ` Mark Brown
2011-09-08 23:59 ` Mark Brown
2011-09-09 8:48 ` Jassi Brar
2011-09-09 8:48 ` Jassi Brar
2011-09-09 9:41 ` Russell King - ARM Linux
2011-09-09 9:41 ` Russell King - ARM Linux
2011-09-09 9:41 ` Russell King - ARM Linux
2011-09-09 16:11 ` Mark Brown
2011-09-09 16:11 ` Mark Brown
2011-09-09 16:11 ` Mark Brown
2011-09-09 19:01 ` Russell King - ARM Linux
2011-09-09 19:01 ` Russell King - ARM Linux
2011-09-09 19:01 ` Russell King - ARM Linux
2011-09-09 19:30 ` Mark Brown
2011-09-09 19:30 ` Mark Brown
2011-09-09 19:30 ` Mark Brown
2011-09-09 20:56 ` Russell King - ARM Linux
2011-09-09 20:56 ` Russell King - ARM Linux
2011-09-09 20:56 ` Russell King - ARM Linux
2011-09-10 20:37 ` Arnd Bergmann [this message]
2011-09-10 20:37 ` Arnd Bergmann
2011-09-10 20:37 ` Arnd Bergmann
2011-09-10 21:43 ` Mark Brown
2011-09-10 21:43 ` Mark Brown
2011-09-10 21:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109102237.15193.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=grant.likely@secretlab.ca \
--cc=jassisinghbrar@gmail.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lrg@ti.com \
--cc=mans.rullgard@linaro.org \
--cc=tiwai@suse.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.