From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
Scott Jiang <scott.jiang.linux@gmail.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] alsa-lib: if card driver name is empty string, use card name instead
Date: Tue, 20 Sep 2011 11:14:34 +0100 [thread overview]
Message-ID: <20110920101434.GD2387@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <s5haa9zspcb.wl%tiwai@suse.de>
On Tue, Sep 20, 2011 at 08:24:52AM +0200, Takashi Iwai wrote:
> Scott Jiang wrote:
> > Some drivers don't have a card driver name, but they have a nice card name containing enough info.
> > So we can use card name to search card config if we found driver name is not valid.
> It's rather a bug of driver, no?
> I don't think we need to work around it.
This was introduced by your commit 873bd4 (ASoC: don't set invalid name
string to snd_card->driver field) which means we no longer provide a
driver name for any ASoC cards as they're all relying on using the card
name as the driver name. We should be doing something like replacing '
' by '_' in the driver name we generate rather than just not generating
a name.
I have to confess I didn't review the patch at the time as it was
applied too quickly after it was mailed out for me to have a chance to
see it. Sorry about that.
next prev parent reply other threads:[~2011-09-20 10:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 17:15 [PATCH] alsa-lib: if card driver name is empty string, use card name instead Scott Jiang
2011-09-20 6:24 ` Takashi Iwai
2011-09-20 6:37 ` Scott Jiang
2011-09-20 6:39 ` Takashi Iwai
2011-09-20 6:55 ` Scott Jiang
2011-09-20 7:12 ` Takashi Iwai
2011-09-20 10:03 ` Mark Brown
2011-09-20 10:36 ` Scott Jiang
2011-09-20 10:53 ` Mark Brown
2011-09-20 10:14 ` Mark Brown [this message]
2011-09-20 10:33 ` Takashi Iwai
2011-09-20 10:51 ` Mark Brown
2011-09-20 10:58 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920101434.GD2387@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=scott.jiang.linux@gmail.com \
--cc=tiwai@suse.de \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.