From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
Scott Jiang <scott.jiang.linux@gmail.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] alsa-lib: if card driver name is empty string, use card name instead
Date: Tue, 20 Sep 2011 11:51:57 +0100 [thread overview]
Message-ID: <20110920105156.GF2387@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <s5hy5xj1p16.wl%tiwai@suse.de>
On Tue, Sep 20, 2011 at 12:33:41PM +0200, Takashi Iwai wrote:
> Well, you can follow a short history from the commit: the commit above
> was really a fix to get back to the old good behavior. Until 3.0,
> ASoC had no way to set card->driver field. The method to set
No - older versions of ASoC always automatically generated a driver
name (badly but that's a separate story). I guess that got broken with
multi-component but didn't bother checking.
> But, this was no good move, too. The card->driver field is to be a
> concise string without special letters while card->name contains more
> flexible string. So, I changed the way back to the state before 3.0
> there, the commit 873bd4.
Which unfortunately restored the original problem which was being fixed
by Jarkko.
> Of course, it'd be nice to implement a logic in ASoC core to
> automatically generate some valid driver-name string. But, the driver
> name string is at most 15 letters, and card->name is an arbitrary
> string, so you'd need to do it a bit carefully.
I think the card name is fine, people don't tend to write anything
terribly long there and very little actually cares about the driver name
- alsa-lib's config loading thing is the only thing I'm aware of (and
that's not being terribly useful really, one driver can easily support
multiple cards). If it's a problem people can always explicitly set
something.
next prev parent reply other threads:[~2011-09-20 10:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 17:15 [PATCH] alsa-lib: if card driver name is empty string, use card name instead Scott Jiang
2011-09-20 6:24 ` Takashi Iwai
2011-09-20 6:37 ` Scott Jiang
2011-09-20 6:39 ` Takashi Iwai
2011-09-20 6:55 ` Scott Jiang
2011-09-20 7:12 ` Takashi Iwai
2011-09-20 10:03 ` Mark Brown
2011-09-20 10:36 ` Scott Jiang
2011-09-20 10:53 ` Mark Brown
2011-09-20 10:14 ` Mark Brown
2011-09-20 10:33 ` Takashi Iwai
2011-09-20 10:51 ` Mark Brown [this message]
2011-09-20 10:58 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920105156.GF2387@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=scott.jiang.linux@gmail.com \
--cc=tiwai@suse.de \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.