From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
Scott Jiang <scott.jiang.linux@gmail.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] alsa-lib: if card driver name is empty string, use card name instead
Date: Tue, 20 Sep 2011 11:03:15 +0100 [thread overview]
Message-ID: <20110920100314.GB2387@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <s5hwrd3r8ks.wl%tiwai@suse.de>
On Tue, Sep 20, 2011 at 09:12:19AM +0200, Takashi Iwai wrote:
> Scott Jiang wrote:
> > I agree with you, but my driver patch has been rejected by Mark.
> That's bad. But it's a rule since over 10 years ago: the driver
> should set driver field.
Scott, as I've said every time you've posted your patch there's several
problems with your patch:
- The name you've chosen is really not at all suitable, it doesn't
identify the system at all.
- This clearly isn't something that affects only one driver - no ASoC
driver sets a driver name - so a change to a single driver is clearly
not a good solution even for just Blackfin.
You need to address these issues, they're both blocking.
next prev parent reply other threads:[~2011-09-20 10:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 17:15 [PATCH] alsa-lib: if card driver name is empty string, use card name instead Scott Jiang
2011-09-20 6:24 ` Takashi Iwai
2011-09-20 6:37 ` Scott Jiang
2011-09-20 6:39 ` Takashi Iwai
2011-09-20 6:55 ` Scott Jiang
2011-09-20 7:12 ` Takashi Iwai
2011-09-20 10:03 ` Mark Brown [this message]
2011-09-20 10:36 ` Scott Jiang
2011-09-20 10:53 ` Mark Brown
2011-09-20 10:14 ` Mark Brown
2011-09-20 10:33 ` Takashi Iwai
2011-09-20 10:51 ` Mark Brown
2011-09-20 10:58 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920100314.GB2387@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=scott.jiang.linux@gmail.com \
--cc=tiwai@suse.de \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.