All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] drivers/hwmon/w83791d.c: rename prototype
Date: Wed, 21 Sep 2011 13:55:31 +0000	[thread overview]
Message-ID: <20110921135531.GA26958@ericsson.com> (raw)
In-Reply-To: <1316068246-3275-1-git-send-email-cpeterso@cpeterso.com>

On Wed, Sep 21, 2011 at 07:41:29AM -0400, Marc Hulsman wrote:
> Hi Chris,
> 
> (lm-sensors CC-ed) 
> 
> On Thursday 15 September 2011 08:30:46 Chris Peterson wrote:
> > gcc -Wextra warns "‘register’ is not at beginning of declaration" because
> > the compiler thinks the parameter has been marked as a 'register'
> > variable, but the function prototype intended to name the parameter
> > "register" (which is a reserved keyword).
> > 
> > Signed-off-by: Chris Peterson <cpeterso@cpeterso.com>
> > ---
> >  drivers/hwmon/w83791d.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/hwmon/w83791d.c b/drivers/hwmon/w83791d.c
> > index 17cf1ab..8c2844e 100644
> > --- a/drivers/hwmon/w83791d.c
> > +++ b/drivers/hwmon/w83791d.c
> > @@ -329,8 +329,8 @@ static int w83791d_detect(struct i2c_client *client,
> >  			  struct i2c_board_info *info);
> >  static int w83791d_remove(struct i2c_client *client);
> > 
> > -static int w83791d_read(struct i2c_client *client, u8 register);
> > -static int w83791d_write(struct i2c_client *client, u8 register, u8 value);
> > +static int w83791d_read(struct i2c_client *client, u8 reg);
> > +static int w83791d_write(struct i2c_client *client, u8 reg, u8 value);
> >  static struct w83791d_data *w83791d_update_device(struct device *dev);
> > 
> >  #ifdef DEBUG
> 
> Thanks! Patch looks (and works) fine. 
> 
> Acked-by: Marc Hulsman <m.hulsman@tudelft.nl>
> 
> Guenter or Jean, can you pick up this patch? Original mail was not posted to lm_sensors,
> but can be found here: 
> http://www.spinics.net/lists/linux-kernel-janitors/msg09690.html 
> or see below for a copy of the patch without the >.
> 
Applied.

Thanks,
Guenter

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] drivers/hwmon/w83791d.c: rename prototype
Date: Wed, 21 Sep 2011 13:55:31 +0000	[thread overview]
Message-ID: <20110921135531.GA26958@ericsson.com> (raw)
In-Reply-To: <1316068246-3275-1-git-send-email-cpeterso@cpeterso.com>

On Wed, Sep 21, 2011 at 07:41:29AM -0400, Marc Hulsman wrote:
> Hi Chris,
> 
> (lm-sensors CC-ed) 
> 
> On Thursday 15 September 2011 08:30:46 Chris Peterson wrote:
> > gcc -Wextra warns "‘register’ is not at beginning of declaration" because
> > the compiler thinks the parameter has been marked as a 'register'
> > variable, but the function prototype intended to name the parameter
> > "register" (which is a reserved keyword).
> > 
> > Signed-off-by: Chris Peterson <cpeterso@cpeterso.com>
> > ---
> >  drivers/hwmon/w83791d.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/hwmon/w83791d.c b/drivers/hwmon/w83791d.c
> > index 17cf1ab..8c2844e 100644
> > --- a/drivers/hwmon/w83791d.c
> > +++ b/drivers/hwmon/w83791d.c
> > @@ -329,8 +329,8 @@ static int w83791d_detect(struct i2c_client *client,
> >  			  struct i2c_board_info *info);
> >  static int w83791d_remove(struct i2c_client *client);
> > 
> > -static int w83791d_read(struct i2c_client *client, u8 register);
> > -static int w83791d_write(struct i2c_client *client, u8 register, u8 value);
> > +static int w83791d_read(struct i2c_client *client, u8 reg);
> > +static int w83791d_write(struct i2c_client *client, u8 reg, u8 value);
> >  static struct w83791d_data *w83791d_update_device(struct device *dev);
> > 
> >  #ifdef DEBUG
> 
> Thanks! Patch looks (and works) fine. 
> 
> Acked-by: Marc Hulsman <m.hulsman@tudelft.nl>
> 
> Guenter or Jean, can you pick up this patch? Original mail was not posted to lm_sensors,
> but can be found here: 
> http://www.spinics.net/lists/linux-kernel-janitors/msg09690.html 
> or see below for a copy of the patch without the >.
> 
Applied.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2011-09-21 13:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15  6:30 [PATCH] drivers/hwmon/w83791d.c: rename prototype parameter from 'register' to 'reg' Chris Peterson
2011-09-21 11:41 ` Marc Hulsman
2011-09-21 11:41   ` [lm-sensors] [PATCH] drivers/hwmon/w83791d.c: rename prototype Marc Hulsman
2011-09-21 13:55 ` Guenter Roeck [this message]
2011-09-21 13:55   ` Guenter Roeck
2011-09-27 15:05 ` Jean Delvare
2011-09-27 15:05   ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110921135531.GA26958@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.