* Re: [PATCH] drivers/hwmon/w83791d.c: rename prototype parameter from 'register' to 'reg'
2011-09-15 6:30 [PATCH] drivers/hwmon/w83791d.c: rename prototype parameter from 'register' to 'reg' Chris Peterson
@ 2011-09-21 11:41 ` Marc Hulsman
2011-09-21 13:55 ` Guenter Roeck
2011-09-27 15:05 ` Jean Delvare
2 siblings, 0 replies; 7+ messages in thread
From: Marc Hulsman @ 2011-09-21 11:41 UTC (permalink / raw)
To: kernel-janitors
Hi Chris,
(lm-sensors CC-ed)
On Thursday 15 September 2011 08:30:46 Chris Peterson wrote:
> gcc -Wextra warns "‘register’ is not at beginning of declaration" because
> the compiler thinks the parameter has been marked as a 'register'
> variable, but the function prototype intended to name the parameter
> "register" (which is a reserved keyword).
>
> Signed-off-by: Chris Peterson <cpeterso@cpeterso.com>
> ---
> drivers/hwmon/w83791d.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/w83791d.c b/drivers/hwmon/w83791d.c
> index 17cf1ab..8c2844e 100644
> --- a/drivers/hwmon/w83791d.c
> +++ b/drivers/hwmon/w83791d.c
> @@ -329,8 +329,8 @@ static int w83791d_detect(struct i2c_client *client,
> struct i2c_board_info *info);
> static int w83791d_remove(struct i2c_client *client);
>
> -static int w83791d_read(struct i2c_client *client, u8 register);
> -static int w83791d_write(struct i2c_client *client, u8 register, u8 value);
> +static int w83791d_read(struct i2c_client *client, u8 reg);
> +static int w83791d_write(struct i2c_client *client, u8 reg, u8 value);
> static struct w83791d_data *w83791d_update_device(struct device *dev);
>
> #ifdef DEBUG
Thanks! Patch looks (and works) fine.
Acked-by: Marc Hulsman <m.hulsman@tudelft.nl>
Guenter or Jean, can you pick up this patch? Original mail was not posted to lm_sensors,
but can be found here:
http://www.spinics.net/lists/linux-kernel-janitors/msg09690.html
or see below for a copy of the patch without the >.
Cheers,
Marc
gcc -Wextra warns "‘register’ is not at beginning of declaration" because the
compiler thinks the parameter has been marked as a 'register' variable, but
the function prototype intended to name the parameter "register" (which is a
reserved keyword).
Signed-off-by: Chris Peterson <cpeterso@cpeterso.com>
---
drivers/hwmon/w83791d.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/w83791d.c b/drivers/hwmon/w83791d.c
index 17cf1ab..8c2844e 100644
--- a/drivers/hwmon/w83791d.c
+++ b/drivers/hwmon/w83791d.c
@@ -329,8 +329,8 @@ static int w83791d_detect(struct i2c_client *client,
struct i2c_board_info *info);
static int w83791d_remove(struct i2c_client *client);
-static int w83791d_read(struct i2c_client *client, u8 register);
-static int w83791d_write(struct i2c_client *client, u8 register, u8 value);
+static int w83791d_read(struct i2c_client *client, u8 reg);
+static int w83791d_write(struct i2c_client *client, u8 reg, u8 value);
static struct w83791d_data *w83791d_update_device(struct device *dev);
#ifdef DEBUG
--
1.7.4.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [lm-sensors] [PATCH] drivers/hwmon/w83791d.c: rename prototype
@ 2011-09-21 11:41 ` Marc Hulsman
0 siblings, 0 replies; 7+ messages in thread
From: Marc Hulsman @ 2011-09-21 11:41 UTC (permalink / raw)
To: kernel-janitors
Hi Chris,
(lm-sensors CC-ed)
On Thursday 15 September 2011 08:30:46 Chris Peterson wrote:
> gcc -Wextra warns "‘register’ is not at beginning of declaration" because
> the compiler thinks the parameter has been marked as a 'register'
> variable, but the function prototype intended to name the parameter
> "register" (which is a reserved keyword).
>
> Signed-off-by: Chris Peterson <cpeterso@cpeterso.com>
> ---
> drivers/hwmon/w83791d.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/w83791d.c b/drivers/hwmon/w83791d.c
> index 17cf1ab..8c2844e 100644
> --- a/drivers/hwmon/w83791d.c
> +++ b/drivers/hwmon/w83791d.c
> @@ -329,8 +329,8 @@ static int w83791d_detect(struct i2c_client *client,
> struct i2c_board_info *info);
> static int w83791d_remove(struct i2c_client *client);
>
> -static int w83791d_read(struct i2c_client *client, u8 register);
> -static int w83791d_write(struct i2c_client *client, u8 register, u8 value);
> +static int w83791d_read(struct i2c_client *client, u8 reg);
> +static int w83791d_write(struct i2c_client *client, u8 reg, u8 value);
> static struct w83791d_data *w83791d_update_device(struct device *dev);
>
> #ifdef DEBUG
Thanks! Patch looks (and works) fine.
Acked-by: Marc Hulsman <m.hulsman@tudelft.nl>
Guenter or Jean, can you pick up this patch? Original mail was not posted to lm_sensors,
but can be found here:
http://www.spinics.net/lists/linux-kernel-janitors/msg09690.html
or see below for a copy of the patch without the >.
Cheers,
Marc
gcc -Wextra warns "‘register’ is not at beginning of declaration" because the
compiler thinks the parameter has been marked as a 'register' variable, but
the function prototype intended to name the parameter "register" (which is a
reserved keyword).
Signed-off-by: Chris Peterson <cpeterso@cpeterso.com>
---
drivers/hwmon/w83791d.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/w83791d.c b/drivers/hwmon/w83791d.c
index 17cf1ab..8c2844e 100644
--- a/drivers/hwmon/w83791d.c
+++ b/drivers/hwmon/w83791d.c
@@ -329,8 +329,8 @@ static int w83791d_detect(struct i2c_client *client,
struct i2c_board_info *info);
static int w83791d_remove(struct i2c_client *client);
-static int w83791d_read(struct i2c_client *client, u8 register);
-static int w83791d_write(struct i2c_client *client, u8 register, u8 value);
+static int w83791d_read(struct i2c_client *client, u8 reg);
+static int w83791d_write(struct i2c_client *client, u8 reg, u8 value);
static struct w83791d_data *w83791d_update_device(struct device *dev);
#ifdef DEBUG
--
1.7.4.1
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [lm-sensors] [PATCH] drivers/hwmon/w83791d.c: rename prototype
2011-09-15 6:30 [PATCH] drivers/hwmon/w83791d.c: rename prototype parameter from 'register' to 'reg' Chris Peterson
@ 2011-09-21 13:55 ` Guenter Roeck
2011-09-21 13:55 ` Guenter Roeck
2011-09-27 15:05 ` Jean Delvare
2 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2011-09-21 13:55 UTC (permalink / raw)
To: kernel-janitors
On Wed, Sep 21, 2011 at 07:41:29AM -0400, Marc Hulsman wrote:
> Hi Chris,
>
> (lm-sensors CC-ed)
>
> On Thursday 15 September 2011 08:30:46 Chris Peterson wrote:
> > gcc -Wextra warns "‘register’ is not at beginning of declaration" because
> > the compiler thinks the parameter has been marked as a 'register'
> > variable, but the function prototype intended to name the parameter
> > "register" (which is a reserved keyword).
> >
> > Signed-off-by: Chris Peterson <cpeterso@cpeterso.com>
> > ---
> > drivers/hwmon/w83791d.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/hwmon/w83791d.c b/drivers/hwmon/w83791d.c
> > index 17cf1ab..8c2844e 100644
> > --- a/drivers/hwmon/w83791d.c
> > +++ b/drivers/hwmon/w83791d.c
> > @@ -329,8 +329,8 @@ static int w83791d_detect(struct i2c_client *client,
> > struct i2c_board_info *info);
> > static int w83791d_remove(struct i2c_client *client);
> >
> > -static int w83791d_read(struct i2c_client *client, u8 register);
> > -static int w83791d_write(struct i2c_client *client, u8 register, u8 value);
> > +static int w83791d_read(struct i2c_client *client, u8 reg);
> > +static int w83791d_write(struct i2c_client *client, u8 reg, u8 value);
> > static struct w83791d_data *w83791d_update_device(struct device *dev);
> >
> > #ifdef DEBUG
>
> Thanks! Patch looks (and works) fine.
>
> Acked-by: Marc Hulsman <m.hulsman@tudelft.nl>
>
> Guenter or Jean, can you pick up this patch? Original mail was not posted to lm_sensors,
> but can be found here:
> http://www.spinics.net/lists/linux-kernel-janitors/msg09690.html
> or see below for a copy of the patch without the >.
>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [lm-sensors] [PATCH] drivers/hwmon/w83791d.c: rename prototype
@ 2011-09-21 13:55 ` Guenter Roeck
0 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2011-09-21 13:55 UTC (permalink / raw)
To: kernel-janitors
On Wed, Sep 21, 2011 at 07:41:29AM -0400, Marc Hulsman wrote:
> Hi Chris,
>
> (lm-sensors CC-ed)
>
> On Thursday 15 September 2011 08:30:46 Chris Peterson wrote:
> > gcc -Wextra warns "‘register’ is not at beginning of declaration" because
> > the compiler thinks the parameter has been marked as a 'register'
> > variable, but the function prototype intended to name the parameter
> > "register" (which is a reserved keyword).
> >
> > Signed-off-by: Chris Peterson <cpeterso@cpeterso.com>
> > ---
> > drivers/hwmon/w83791d.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/hwmon/w83791d.c b/drivers/hwmon/w83791d.c
> > index 17cf1ab..8c2844e 100644
> > --- a/drivers/hwmon/w83791d.c
> > +++ b/drivers/hwmon/w83791d.c
> > @@ -329,8 +329,8 @@ static int w83791d_detect(struct i2c_client *client,
> > struct i2c_board_info *info);
> > static int w83791d_remove(struct i2c_client *client);
> >
> > -static int w83791d_read(struct i2c_client *client, u8 register);
> > -static int w83791d_write(struct i2c_client *client, u8 register, u8 value);
> > +static int w83791d_read(struct i2c_client *client, u8 reg);
> > +static int w83791d_write(struct i2c_client *client, u8 reg, u8 value);
> > static struct w83791d_data *w83791d_update_device(struct device *dev);
> >
> > #ifdef DEBUG
>
> Thanks! Patch looks (and works) fine.
>
> Acked-by: Marc Hulsman <m.hulsman@tudelft.nl>
>
> Guenter or Jean, can you pick up this patch? Original mail was not posted to lm_sensors,
> but can be found here:
> http://www.spinics.net/lists/linux-kernel-janitors/msg09690.html
> or see below for a copy of the patch without the >.
>
Applied.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [lm-sensors] [PATCH] drivers/hwmon/w83791d.c: rename prototype
2011-09-15 6:30 [PATCH] drivers/hwmon/w83791d.c: rename prototype parameter from 'register' to 'reg' Chris Peterson
@ 2011-09-27 15:05 ` Jean Delvare
2011-09-21 13:55 ` Guenter Roeck
2011-09-27 15:05 ` Jean Delvare
2 siblings, 0 replies; 7+ messages in thread
From: Jean Delvare @ 2011-09-27 15:05 UTC (permalink / raw)
To: kernel-janitors
On Wed, 21 Sep 2011 06:55:31 -0700, Guenter Roeck wrote:
> On Wed, Sep 21, 2011 at 07:41:29AM -0400, Marc Hulsman wrote:
> > Hi Chris,
> >
> > (lm-sensors CC-ed)
> >
> > On Thursday 15 September 2011 08:30:46 Chris Peterson wrote:
> > > gcc -Wextra warns "‘register’ is not at beginning of declaration" because
> > > the compiler thinks the parameter has been marked as a 'register'
> > > variable, but the function prototype intended to name the parameter
> > > "register" (which is a reserved keyword).
> > >
> > > Signed-off-by: Chris Peterson <cpeterso@cpeterso.com>
> > > ---
> > > drivers/hwmon/w83791d.c | 4 ++--
> > > 1 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/hwmon/w83791d.c b/drivers/hwmon/w83791d.c
> > > index 17cf1ab..8c2844e 100644
> > > --- a/drivers/hwmon/w83791d.c
> > > +++ b/drivers/hwmon/w83791d.c
> > > @@ -329,8 +329,8 @@ static int w83791d_detect(struct i2c_client *client,
> > > struct i2c_board_info *info);
> > > static int w83791d_remove(struct i2c_client *client);
> > >
> > > -static int w83791d_read(struct i2c_client *client, u8 register);
> > > -static int w83791d_write(struct i2c_client *client, u8 register, u8 value);
> > > +static int w83791d_read(struct i2c_client *client, u8 reg);
> > > +static int w83791d_write(struct i2c_client *client, u8 reg, u8 value);
> > > static struct w83791d_data *w83791d_update_device(struct device *dev);
> > >
> > > #ifdef DEBUG
> >
> > Thanks! Patch looks (and works) fine.
> >
> > Acked-by: Marc Hulsman <m.hulsman@tudelft.nl>
> >
> > Guenter or Jean, can you pick up this patch? Original mail was not posted to lm_sensors,
> > but can be found here:
> > http://www.spinics.net/lists/linux-kernel-janitors/msg09690.html
> > or see below for a copy of the patch without the >.
>
> Applied.
I thought I had fixed all these years ago, but apparently I missed
w83791d :( Thanks Marc and Guenter.
--
Jean Delvare
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [lm-sensors] [PATCH] drivers/hwmon/w83791d.c: rename prototype
@ 2011-09-27 15:05 ` Jean Delvare
0 siblings, 0 replies; 7+ messages in thread
From: Jean Delvare @ 2011-09-27 15:05 UTC (permalink / raw)
To: kernel-janitors
On Wed, 21 Sep 2011 06:55:31 -0700, Guenter Roeck wrote:
> On Wed, Sep 21, 2011 at 07:41:29AM -0400, Marc Hulsman wrote:
> > Hi Chris,
> >
> > (lm-sensors CC-ed)
> >
> > On Thursday 15 September 2011 08:30:46 Chris Peterson wrote:
> > > gcc -Wextra warns "‘register’ is not at beginning of declaration" because
> > > the compiler thinks the parameter has been marked as a 'register'
> > > variable, but the function prototype intended to name the parameter
> > > "register" (which is a reserved keyword).
> > >
> > > Signed-off-by: Chris Peterson <cpeterso@cpeterso.com>
> > > ---
> > > drivers/hwmon/w83791d.c | 4 ++--
> > > 1 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/hwmon/w83791d.c b/drivers/hwmon/w83791d.c
> > > index 17cf1ab..8c2844e 100644
> > > --- a/drivers/hwmon/w83791d.c
> > > +++ b/drivers/hwmon/w83791d.c
> > > @@ -329,8 +329,8 @@ static int w83791d_detect(struct i2c_client *client,
> > > struct i2c_board_info *info);
> > > static int w83791d_remove(struct i2c_client *client);
> > >
> > > -static int w83791d_read(struct i2c_client *client, u8 register);
> > > -static int w83791d_write(struct i2c_client *client, u8 register, u8 value);
> > > +static int w83791d_read(struct i2c_client *client, u8 reg);
> > > +static int w83791d_write(struct i2c_client *client, u8 reg, u8 value);
> > > static struct w83791d_data *w83791d_update_device(struct device *dev);
> > >
> > > #ifdef DEBUG
> >
> > Thanks! Patch looks (and works) fine.
> >
> > Acked-by: Marc Hulsman <m.hulsman@tudelft.nl>
> >
> > Guenter or Jean, can you pick up this patch? Original mail was not posted to lm_sensors,
> > but can be found here:
> > http://www.spinics.net/lists/linux-kernel-janitors/msg09690.html
> > or see below for a copy of the patch without the >.
>
> Applied.
I thought I had fixed all these years ago, but apparently I missed
w83791d :( Thanks Marc and Guenter.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 7+ messages in thread