From: Johannes Weiner <jweiner@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Dave Chinner <david@fromorbit.com>,
Wu Fengguang <fengguang.wu@intel.com>, Jan Kara <jack@suse.cz>,
Minchan Kim <minchan.kim@gmail.com>,
Chris Mason <chris.mason@oracle.com>,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
xfs@oss.sgi.com, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin()
Date: Wed, 21 Sep 2011 16:09:35 +0200 [thread overview]
Message-ID: <20110921140935.GF22516@redhat.com> (raw)
In-Reply-To: <20110920184034.GA27353@infradead.org>
On Tue, Sep 20, 2011 at 02:40:34PM -0400, Christoph Hellwig wrote:
> On Tue, Sep 20, 2011 at 02:38:03PM -0400, Rik van Riel wrote:
> > On 09/20/2011 10:25 AM, Christoph Hellwig wrote:
> > >In addition to regular write shouldn't __do_fault and do_wp_page also
> > >calls this if they are called on file backed mappings?
> >
> > Probably not do_wp_page since it always creates an
> > anonymous page, which are not very relevant to the
> > dirty page cache accounting.
>
> Well, it doesn't always - but for the case where it doesn't we
> do not allocate a new page at all so you're right in the end :)
I think it could be useful to annotate write-fault allocations in
filemap_fault(), but these pages are mostly allocated in the readahead
code, so this could turn into a more invasive project.
It can be done incrementally, however, the series as it stands does
not require it to be useful.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <jweiner@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Rik van Riel <riel@redhat.com>,
linux-ext4@vger.kernel.org, Jan Kara <jack@suse.cz>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
xfs@oss.sgi.com, linux-mm@kvack.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Mel Gorman <mgorman@suse.de>,
linux-fsdevel@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>,
Chris Mason <chris.mason@oracle.com>,
Minchan Kim <minchan.kim@gmail.com>
Subject: Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin()
Date: Wed, 21 Sep 2011 16:09:35 +0200 [thread overview]
Message-ID: <20110921140935.GF22516@redhat.com> (raw)
In-Reply-To: <20110920184034.GA27353@infradead.org>
On Tue, Sep 20, 2011 at 02:40:34PM -0400, Christoph Hellwig wrote:
> On Tue, Sep 20, 2011 at 02:38:03PM -0400, Rik van Riel wrote:
> > On 09/20/2011 10:25 AM, Christoph Hellwig wrote:
> > >In addition to regular write shouldn't __do_fault and do_wp_page also
> > >calls this if they are called on file backed mappings?
> >
> > Probably not do_wp_page since it always creates an
> > anonymous page, which are not very relevant to the
> > dirty page cache accounting.
>
> Well, it doesn't always - but for the case where it doesn't we
> do not allocate a new page at all so you're right in the end :)
I think it could be useful to annotate write-fault allocations in
filemap_fault(), but these pages are mostly allocated in the readahead
code, so this could turn into a more invasive project.
It can be done incrementally, however, the series as it stands does
not require it to be useful.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <jweiner@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Dave Chinner <david@fromorbit.com>,
Wu Fengguang <fengguang.wu@intel.com>, Jan Kara <jack@suse.cz>,
Minchan Kim <minchan.kim@gmail.com>,
Chris Mason <chris.mason@oracle.com>,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
xfs@oss.sgi.com, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin()
Date: Wed, 21 Sep 2011 16:09:35 +0200 [thread overview]
Message-ID: <20110921140935.GF22516@redhat.com> (raw)
In-Reply-To: <20110920184034.GA27353@infradead.org>
On Tue, Sep 20, 2011 at 02:40:34PM -0400, Christoph Hellwig wrote:
> On Tue, Sep 20, 2011 at 02:38:03PM -0400, Rik van Riel wrote:
> > On 09/20/2011 10:25 AM, Christoph Hellwig wrote:
> > >In addition to regular write shouldn't __do_fault and do_wp_page also
> > >calls this if they are called on file backed mappings?
> >
> > Probably not do_wp_page since it always creates an
> > anonymous page, which are not very relevant to the
> > dirty page cache accounting.
>
> Well, it doesn't always - but for the case where it doesn't we
> do not allocate a new page at all so you're right in the end :)
I think it could be useful to annotate write-fault allocations in
filemap_fault(), but these pages are mostly allocated in the readahead
code, so this could turn into a more invasive project.
It can be done incrementally, however, the series as it stands does
not require it to be useful.
next prev parent reply other threads:[~2011-09-21 14:09 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 13:45 [patch 0/4] 50% faster writing to your USB drive!* Johannes Weiner
2011-09-20 13:45 ` Johannes Weiner
2011-09-20 13:45 ` Johannes Weiner
2011-09-20 13:45 ` [patch 1/4] mm: exclude reserved pages from dirtyable memory Johannes Weiner
2011-09-20 13:45 ` Johannes Weiner
2011-09-20 13:45 ` Johannes Weiner
2011-09-20 15:21 ` Rik van Riel
2011-09-20 15:21 ` Rik van Riel
2011-09-20 15:21 ` Rik van Riel
2011-09-21 14:04 ` Mel Gorman
2011-09-21 14:04 ` Mel Gorman
2011-09-21 14:04 ` Mel Gorman
2011-09-21 15:03 ` Mel Gorman
2011-09-21 15:03 ` Mel Gorman
2011-09-21 15:03 ` Mel Gorman
2011-09-22 9:03 ` Johannes Weiner
2011-09-22 9:03 ` Johannes Weiner
2011-09-22 9:03 ` Johannes Weiner
2011-09-22 10:54 ` Mel Gorman
2011-09-22 10:54 ` Mel Gorman
2011-09-22 10:54 ` Mel Gorman
2011-09-23 14:38 ` [patch 1/4 v2] " Johannes Weiner
2011-09-23 14:38 ` Johannes Weiner
2011-09-23 14:38 ` Johannes Weiner
2011-09-28 4:55 ` Minchan Kim
2011-09-28 4:55 ` Minchan Kim
2011-09-28 4:55 ` Minchan Kim
2011-09-28 7:50 ` Johannes Weiner
2011-09-28 7:50 ` Johannes Weiner
2011-09-28 7:50 ` Johannes Weiner
2011-09-28 18:35 ` Minchan Kim
2011-09-28 18:35 ` Minchan Kim
2011-09-28 18:35 ` Minchan Kim
2011-09-20 13:45 ` [patch 2/4] mm: writeback: distribute write pages across allowable zones Johannes Weiner
2011-09-20 13:45 ` Johannes Weiner
2011-09-20 13:45 ` Johannes Weiner
2011-09-20 18:36 ` Rik van Riel
2011-09-20 18:36 ` Rik van Riel
2011-09-20 18:36 ` Rik van Riel
2011-09-21 11:04 ` Shaohua Li
2011-09-21 11:04 ` Shaohua Li
2011-09-21 11:04 ` Shaohua Li
2011-09-21 13:35 ` Johannes Weiner
2011-09-21 13:35 ` Johannes Weiner
2011-09-21 13:35 ` Johannes Weiner
2011-09-21 14:30 ` Mel Gorman
2011-09-21 14:30 ` Mel Gorman
2011-09-21 14:30 ` Mel Gorman
2011-09-21 23:02 ` Andrew Morton
2011-09-21 23:02 ` Andrew Morton
2011-09-21 23:02 ` Andrew Morton
2011-09-22 8:52 ` Johannes Weiner
2011-09-22 8:52 ` Johannes Weiner
2011-09-22 8:52 ` Johannes Weiner
2011-09-23 14:41 ` [patch 1/2/4] mm: writeback: cleanups in preparation for per-zone dirty limits Johannes Weiner
2011-09-23 14:41 ` Johannes Weiner
2011-09-23 14:41 ` Johannes Weiner
2011-09-28 5:57 ` Minchan Kim
2011-09-28 5:57 ` Minchan Kim
2011-09-28 5:57 ` Minchan Kim
2011-09-28 9:27 ` Mel Gorman
2011-09-28 9:27 ` Mel Gorman
2011-09-28 9:27 ` Mel Gorman
2011-09-23 14:42 ` [patch 2/2/4] mm: try to distribute dirty pages fairly across zones Johannes Weiner
2011-09-23 14:42 ` Johannes Weiner
2011-09-23 14:42 ` Johannes Weiner
2011-09-28 5:56 ` Minchan Kim
2011-09-28 5:56 ` Minchan Kim
2011-09-28 5:56 ` Minchan Kim
2011-09-28 7:11 ` Johannes Weiner
2011-09-28 7:11 ` Johannes Weiner
2011-09-28 7:11 ` Johannes Weiner
2011-09-28 18:09 ` Minchan Kim
2011-09-28 18:09 ` Minchan Kim
2011-09-28 18:09 ` Minchan Kim
2011-09-28 9:36 ` Mel Gorman
2011-09-28 9:36 ` Mel Gorman
2011-09-28 9:36 ` Mel Gorman
2011-09-20 13:45 ` [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin() Johannes Weiner
2011-09-20 13:45 ` Johannes Weiner
2011-09-20 13:45 ` Johannes Weiner
2011-09-20 14:25 ` Christoph Hellwig
2011-09-20 14:25 ` Christoph Hellwig
2011-09-20 14:25 ` Christoph Hellwig
2011-09-20 18:38 ` Rik van Riel
2011-09-20 18:38 ` Rik van Riel
2011-09-20 18:38 ` Rik van Riel
2011-09-20 18:40 ` Christoph Hellwig
2011-09-20 18:40 ` Christoph Hellwig
2011-09-20 18:40 ` Christoph Hellwig
2011-09-21 14:09 ` Johannes Weiner [this message]
2011-09-21 14:09 ` Johannes Weiner
2011-09-21 14:09 ` Johannes Weiner
2011-09-20 18:40 ` Rik van Riel
2011-09-20 18:40 ` Rik van Riel
2011-09-20 18:40 ` Rik van Riel
2011-09-21 14:34 ` Mel Gorman
2011-09-21 14:34 ` Mel Gorman
2011-09-21 14:34 ` Mel Gorman
2011-09-28 6:02 ` Minchan Kim
2011-09-28 6:02 ` Minchan Kim
2011-09-28 6:02 ` Minchan Kim
2011-09-20 13:45 ` [patch 4/4] Btrfs: pass __GFP_WRITE for buffered write page allocations Johannes Weiner
2011-09-20 13:45 ` Johannes Weiner
2011-09-20 13:45 ` Johannes Weiner
2011-09-20 13:56 ` Johannes Weiner
2011-09-20 13:56 ` Johannes Weiner
2011-09-20 13:56 ` Johannes Weiner
2011-09-20 14:09 ` Josef Bacik
2011-09-20 14:09 ` Josef Bacik
2011-09-20 14:09 ` Josef Bacik
2011-09-20 14:14 ` Johannes Weiner
2011-09-20 14:14 ` Johannes Weiner
2011-09-20 14:14 ` Johannes Weiner
2011-09-20 18:41 ` Rik van Riel
2011-09-20 18:41 ` Rik van Riel
2011-09-20 18:41 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110921140935.GF22516@redhat.com \
--to=jweiner@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.