From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: gic: add OF based initialization
Date: Mon, 26 Sep 2011 23:29:18 +0100 [thread overview]
Message-ID: <20110926222918.GG9194@gallagher> (raw)
In-Reply-To: <1316550244-3655-4-git-send-email-robherring2@gmail.com>
Hi Rob,
Apologies for the noise! One minor comment below.
Jamie
On Tue, Sep 20, 2011 at 03:24:04PM -0500, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> This adds ARM gic interrupt controller initialization using device tree
> data.
>
> The initialization function is intended to be called by of_irq_init
> function like this:
>
> const static struct of_device_id irq_match[] = {
> { .compatible = "arm,cortex-a9-gic", .data = gic_of_init, },
> {}
> };
>
> static void __init init_irqs(void)
> {
> of_irq_init(irq_match);
> }
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> ---
[...]
> diff --git a/arch/arm/include/asm/hardware/gic.h b/arch/arm/include/asm/hardware/gic.h
> index 435d3f8..2862d0e 100644
> --- a/arch/arm/include/asm/hardware/gic.h
> +++ b/arch/arm/include/asm/hardware/gic.h
> @@ -33,10 +33,21 @@
> #define GIC_DIST_SOFTINT 0xf00
>
> #ifndef __ASSEMBLY__
> +#include <linux/irqdomain.h>
> +
> extern void __iomem *gic_cpu_base_addr;
> extern struct irq_chip gic_arch_extn;
>
> void gic_init(unsigned int, unsigned int, void __iomem *, void __iomem *);
> +#ifdef CONFIG_OF
> +int gic_of_init(struct device_node *node, struct device_node *parent);
> +#else
> +static inline void gic_of_init(struct device_node *node,
> + struct device_node *parent)
This should return int?
> +{
> + return -ENODEV;
> +}
> +#endif
WARNING: multiple messages have this Message-ID (diff)
From: Jamie Iles <jamie@jamieiles.com>
To: Rob Herring <robherring2@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, grant.likely@secretlab.ca,
marc.zyngier@arm.com, thomas.abraham@linaro.org,
jamie@jamieiles.com, b-cousson@ti.com, shawn.guo@linaro.org,
dave.martin@linaro.org, linux@arm.linux.org.uk,
Rob Herring <rob.herring@calxeda.com>
Subject: Re: [PATCH 3/3] ARM: gic: add OF based initialization
Date: Mon, 26 Sep 2011 23:29:18 +0100 [thread overview]
Message-ID: <20110926222918.GG9194@gallagher> (raw)
In-Reply-To: <1316550244-3655-4-git-send-email-robherring2@gmail.com>
Hi Rob,
Apologies for the noise! One minor comment below.
Jamie
On Tue, Sep 20, 2011 at 03:24:04PM -0500, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> This adds ARM gic interrupt controller initialization using device tree
> data.
>
> The initialization function is intended to be called by of_irq_init
> function like this:
>
> const static struct of_device_id irq_match[] = {
> { .compatible = "arm,cortex-a9-gic", .data = gic_of_init, },
> {}
> };
>
> static void __init init_irqs(void)
> {
> of_irq_init(irq_match);
> }
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> ---
[...]
> diff --git a/arch/arm/include/asm/hardware/gic.h b/arch/arm/include/asm/hardware/gic.h
> index 435d3f8..2862d0e 100644
> --- a/arch/arm/include/asm/hardware/gic.h
> +++ b/arch/arm/include/asm/hardware/gic.h
> @@ -33,10 +33,21 @@
> #define GIC_DIST_SOFTINT 0xf00
>
> #ifndef __ASSEMBLY__
> +#include <linux/irqdomain.h>
> +
> extern void __iomem *gic_cpu_base_addr;
> extern struct irq_chip gic_arch_extn;
>
> void gic_init(unsigned int, unsigned int, void __iomem *, void __iomem *);
> +#ifdef CONFIG_OF
> +int gic_of_init(struct device_node *node, struct device_node *parent);
> +#else
> +static inline void gic_of_init(struct device_node *node,
> + struct device_node *parent)
This should return int?
> +{
> + return -ENODEV;
> +}
> +#endif
WARNING: multiple messages have this Message-ID (diff)
From: Jamie Iles <jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
To: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 3/3] ARM: gic: add OF based initialization
Date: Mon, 26 Sep 2011 23:29:18 +0100 [thread overview]
Message-ID: <20110926222918.GG9194@gallagher> (raw)
In-Reply-To: <1316550244-3655-4-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi Rob,
Apologies for the noise! One minor comment below.
Jamie
On Tue, Sep 20, 2011 at 03:24:04PM -0500, Rob Herring wrote:
> From: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>
> This adds ARM gic interrupt controller initialization using device tree
> data.
>
> The initialization function is intended to be called by of_irq_init
> function like this:
>
> const static struct of_device_id irq_match[] = {
> { .compatible = "arm,cortex-a9-gic", .data = gic_of_init, },
> {}
> };
>
> static void __init init_irqs(void)
> {
> of_irq_init(irq_match);
> }
>
> Signed-off-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> ---
[...]
> diff --git a/arch/arm/include/asm/hardware/gic.h b/arch/arm/include/asm/hardware/gic.h
> index 435d3f8..2862d0e 100644
> --- a/arch/arm/include/asm/hardware/gic.h
> +++ b/arch/arm/include/asm/hardware/gic.h
> @@ -33,10 +33,21 @@
> #define GIC_DIST_SOFTINT 0xf00
>
> #ifndef __ASSEMBLY__
> +#include <linux/irqdomain.h>
> +
> extern void __iomem *gic_cpu_base_addr;
> extern struct irq_chip gic_arch_extn;
>
> void gic_init(unsigned int, unsigned int, void __iomem *, void __iomem *);
> +#ifdef CONFIG_OF
> +int gic_of_init(struct device_node *node, struct device_node *parent);
> +#else
> +static inline void gic_of_init(struct device_node *node,
> + struct device_node *parent)
This should return int?
> +{
> + return -ENODEV;
> +}
> +#endif
next prev parent reply other threads:[~2011-09-26 22:29 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 20:24 [PATCH 0/3] GIC OF bindings Rob Herring
2011-09-20 20:24 ` Rob Herring
2011-09-20 20:24 ` Rob Herring
2011-09-20 20:24 ` [PATCH 1/3] of/irq: of_irq_find_parent: check for parent equal to child Rob Herring
2011-09-20 20:24 ` Rob Herring
2011-09-20 20:24 ` Rob Herring
2011-09-20 21:01 ` Grant Likely
2011-09-20 21:01 ` Grant Likely
2011-09-20 21:01 ` Grant Likely
2011-09-20 20:24 ` [PATCH 2/3] of/irq: introduce of_irq_init Rob Herring
2011-09-20 20:24 ` Rob Herring
2011-09-20 20:24 ` Rob Herring
2011-09-20 23:00 ` Grant Likely
2011-09-20 23:00 ` Grant Likely
2011-09-21 10:01 ` Jamie Iles
2011-09-21 10:01 ` Jamie Iles
2011-09-21 10:01 ` Jamie Iles
2011-09-23 2:21 ` [PATCH v3] " Rob Herring
2011-09-23 2:21 ` Rob Herring
2011-09-23 2:21 ` Rob Herring
2011-09-23 5:14 ` Grant Likely
2011-09-23 5:14 ` Grant Likely
2011-09-23 5:14 ` Grant Likely
2011-09-26 19:24 ` [PATCH v4] " Rob Herring
2011-09-26 19:24 ` Rob Herring
2011-09-26 19:24 ` Rob Herring
2011-09-27 1:53 ` Grant Likely
2011-09-27 1:53 ` Grant Likely
2011-09-27 1:53 ` Grant Likely
2011-09-27 13:03 ` Rob Herring
2011-09-27 13:03 ` Rob Herring
2011-09-27 13:03 ` Rob Herring
2011-09-27 21:24 ` Grant Likely
2011-09-27 21:24 ` Grant Likely
2011-09-20 20:24 ` [PATCH 3/3] ARM: gic: add OF based initialization Rob Herring
2011-09-20 20:24 ` Rob Herring
2011-09-20 20:24 ` Rob Herring
2011-09-20 23:08 ` Grant Likely
2011-09-20 23:08 ` Grant Likely
2011-09-20 23:08 ` Grant Likely
2011-09-21 1:54 ` Rob Herring
2011-09-21 1:54 ` Rob Herring
2011-09-21 1:54 ` Rob Herring
2011-09-21 17:15 ` Cousson, Benoit
2011-09-21 17:15 ` Cousson, Benoit
2011-09-21 17:15 ` Cousson, Benoit
2011-09-21 17:55 ` Rob Herring
2011-09-21 17:55 ` Rob Herring
2011-09-21 17:55 ` Rob Herring
2011-09-21 19:28 ` Cousson, Benoit
2011-09-21 19:28 ` Cousson, Benoit
2011-09-21 19:28 ` Cousson, Benoit
2011-09-21 20:27 ` Cousson, Benoit
2011-09-21 20:27 ` Cousson, Benoit
2011-09-21 20:27 ` Cousson, Benoit
2011-09-26 19:57 ` Jamie Iles
2011-09-26 19:57 ` Jamie Iles
2011-09-26 19:57 ` Jamie Iles
2011-09-26 20:49 ` Rob Herring
2011-09-26 20:49 ` Rob Herring
2011-09-26 20:49 ` Rob Herring
2011-09-26 21:11 ` Jamie Iles
2011-09-26 21:11 ` Jamie Iles
2011-09-26 21:11 ` Jamie Iles
2011-09-26 21:32 ` Rob Herring
2011-09-26 21:32 ` Rob Herring
2011-09-26 21:32 ` Rob Herring
2011-09-26 22:00 ` Jamie Iles
2011-09-26 22:00 ` Jamie Iles
2011-09-26 22:29 ` Jamie Iles [this message]
2011-09-26 22:29 ` Jamie Iles
2011-09-26 22:29 ` Jamie Iles
2011-09-21 2:49 ` [PATCH 0/3] GIC OF bindings David Miller
2011-09-21 2:49 ` David Miller
2011-09-21 2:49 ` David Miller
2011-09-21 4:14 ` Grant Likely
2011-09-21 4:14 ` Grant Likely
2011-09-21 4:58 ` Mitch Bradley
2011-09-21 4:58 ` Mitch Bradley
2011-09-21 4:58 ` Mitch Bradley
2011-09-21 5:21 ` David Miller
2011-09-21 5:21 ` David Miller
2011-09-21 5:21 ` David Miller
2011-09-21 7:11 ` Mitch Bradley
2011-09-21 7:11 ` Mitch Bradley
2011-09-21 7:11 ` Mitch Bradley
2011-09-21 5:16 ` Segher Boessenkool
2011-09-21 5:16 ` Segher Boessenkool
2011-09-21 5:16 ` Segher Boessenkool
2011-09-21 9:43 ` Shawn Guo
2011-09-21 9:43 ` Shawn Guo
2011-09-21 9:43 ` Shawn Guo
-- strict thread matches above, loose matches on Subject: below --
2011-09-30 19:27 Rob Herring
2011-09-30 19:28 ` [PATCH 3/3] ARM: gic: add OF based initialization Rob Herring
2011-09-30 19:28 ` Rob Herring
2011-09-30 19:28 ` Rob Herring
2011-10-04 23:44 ` Grant Likely
2011-10-04 23:44 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926222918.GG9194@gallagher \
--to=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.