From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Daniel Drake <dsd@laptop.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
sameo@linux.intel.com, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, dilinger@queued.net
Subject: Re: [PATCH 1/3] mfd: allow mfd_cell association with device tree node
Date: Tue, 27 Sep 2011 19:26:36 +0100 [thread overview]
Message-ID: <20110927182636.GR4289@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAMLZHHSuoeAJ-AC9daxb83+EANV=YGK-aiYpQ_j2wFiyQa5ytw@mail.gmail.com>
On Tue, Sep 27, 2011 at 07:25:03PM +0100, Daniel Drake wrote:
> On Tue, Sep 27, 2011 at 7:14 PM, Mark Brown
> > Why not just kmemdup() the template you're using rather than modifying
> > it in place?
> Could do, but is there any point in this case? I'm not seeing it. The
> "template" is already being modified in this way in the current driver
> as well.
That seems like a bug that just happened to get noticed while reviewing
this change, though...
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Daniel Drake <dsd-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
dilinger-pFFUokh25LWsTnJN9+BGXg@public.gmane.org,
sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/3] mfd: allow mfd_cell association with device tree node
Date: Tue, 27 Sep 2011 19:26:36 +0100 [thread overview]
Message-ID: <20110927182636.GR4289@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAMLZHHSuoeAJ-AC9daxb83+EANV=YGK-aiYpQ_j2wFiyQa5ytw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tue, Sep 27, 2011 at 07:25:03PM +0100, Daniel Drake wrote:
> On Tue, Sep 27, 2011 at 7:14 PM, Mark Brown
> > Why not just kmemdup() the template you're using rather than modifying
> > it in place?
> Could do, but is there any point in this case? I'm not seeing it. The
> "template" is already being modified in this way in the current driver
> as well.
That seems like a bug that just happened to get noticed while reviewing
this change, though...
next prev parent reply other threads:[~2011-09-27 18:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 12:01 [PATCH 1/3] mfd: allow mfd_cell association with device tree node Daniel Drake
2011-09-21 12:01 ` Daniel Drake
2011-09-21 12:49 ` Mark Brown
2011-09-21 12:49 ` Mark Brown
2011-09-21 13:02 ` Daniel Drake
2011-09-21 13:02 ` Daniel Drake
2011-09-21 13:16 ` Mark Brown
2011-09-27 14:44 ` Daniel Drake
2011-09-27 15:05 ` Grant Likely
2011-09-27 15:18 ` Mark Brown
2011-09-27 16:44 ` Daniel Drake
2011-09-27 18:14 ` Mark Brown
2011-09-27 18:25 ` Daniel Drake
2011-09-27 18:26 ` Mark Brown [this message]
2011-09-27 18:26 ` Mark Brown
2011-09-27 18:28 ` Daniel Drake
2011-09-27 18:28 ` Daniel Drake
2011-09-27 18:38 ` Mark Brown
2011-09-27 18:38 ` Mark Brown
2011-09-28 9:07 ` Daniel Drake
2011-09-28 12:31 ` Mark Brown
2011-10-03 8:40 ` Daniel Drake
2011-10-03 10:28 ` Mark Brown
2011-10-03 10:39 ` Daniel Drake
2011-10-03 10:39 ` Daniel Drake
2011-10-03 12:16 ` Mark Brown
2011-10-03 12:30 ` Daniel Drake
2011-10-03 12:30 ` Daniel Drake
2011-10-03 12:40 ` Mark Brown
2011-10-03 12:40 ` Mark Brown
2011-10-03 12:53 ` Daniel Drake
2011-10-03 12:53 ` Daniel Drake
-- strict thread matches above, loose matches on Subject: below --
2011-09-21 12:01 Daniel Drake
2011-09-28 9:08 Daniel Drake
2011-09-28 9:08 Daniel Drake
2011-09-28 9:08 ` Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110927182636.GR4289@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dilinger@queued.net \
--cc=dsd@laptop.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.