From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Greg KH <greg@kroah.com>
Cc: "G, Manjunath Kondaiah" <manjugk@ti.com>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
Dilan Lee <dilee@nvidia.com>,
Manjunath GKondaiah <manjunath.gkondaiah@linaro.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/5] drivercore: add new error value for deferred probe
Date: Fri, 7 Oct 2011 11:00:22 +0100 [thread overview]
Message-ID: <20111007100022.GB19080@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20111007064349.GD27508@kroah.com>
On Thu, Oct 06, 2011 at 11:43:49PM -0700, Greg KH wrote:
> On Fri, Oct 07, 2011 at 10:33:06AM +0500, G, Manjunath Kondaiah wrote:
> > +#define EPROBE_DEFER 517 /* restart probe again after some time */
> Can we really do this? Isn't this some user/kernel api here?
> What's wrong with just "overloading" on top of an existing error code?
> Surely one of the other 516 types could be used here, right?
There was some discussion of this in the previous patch round before the
code was changed - it does end up adding an externally visible error
code but it doesn't really make any difference, especially if we don't
propagate it externally. We've already got some other codes in a
similar style, though I can't remember the examples that were quoted
offhand. Adding the new code avoids confusion about exactly what the
intent of the driver is.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] drivercore: add new error value for deferred probe
Date: Fri, 7 Oct 2011 11:00:22 +0100 [thread overview]
Message-ID: <20111007100022.GB19080@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20111007064349.GD27508@kroah.com>
On Thu, Oct 06, 2011 at 11:43:49PM -0700, Greg KH wrote:
> On Fri, Oct 07, 2011 at 10:33:06AM +0500, G, Manjunath Kondaiah wrote:
> > +#define EPROBE_DEFER 517 /* restart probe again after some time */
> Can we really do this? Isn't this some user/kernel api here?
> What's wrong with just "overloading" on top of an existing error code?
> Surely one of the other 516 types could be used here, right?
There was some discussion of this in the previous patch round before the
code was changed - it does end up adding an externally visible error
code but it doesn't really make any difference, especially if we don't
propagate it externally. We've already got some other codes in a
similar style, though I can't remember the examples that were quoted
offhand. Adding the new code avoids confusion about exactly what the
intent of the driver is.
next prev parent reply other threads:[~2011-10-07 10:00 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 5:33 [PATCH 0/5] Driver Probe Deferral Mechanism G, Manjunath Kondaiah
2011-10-07 5:33 ` [PATCH 1/5] drivercore: add new error value for deferred probe G, Manjunath Kondaiah
2011-10-07 6:43 ` Greg KH
2011-10-07 6:43 ` Greg KH
2011-10-07 10:00 ` Mark Brown [this message]
2011-10-07 10:00 ` Mark Brown
2011-10-07 22:12 ` Grant Likely
2011-10-07 22:12 ` Grant Likely
2011-10-07 23:28 ` Valdis.Kletnieks
2011-10-07 23:28 ` Valdis.Kletnieks
2011-10-07 23:28 ` Valdis.Kletnieks at vt.edu
2011-10-08 0:12 ` Greg KH
2011-10-08 0:12 ` Greg KH
2011-10-09 22:59 ` Grant Likely
2011-10-09 22:59 ` Grant Likely
2011-10-09 22:59 ` Grant Likely
2011-10-10 1:06 ` Greg KH
2011-10-10 1:06 ` Greg KH
2011-10-10 1:06 ` Greg KH
2011-10-12 6:18 ` G, Manjunath Kondaiah
2011-10-12 6:18 ` G, Manjunath Kondaiah
2011-10-13 4:10 ` Grant Likely
2011-10-13 4:10 ` Grant Likely
2011-10-07 5:33 ` [PATCH 2/5] drivercore: Add driver probe deferral mechanism G, Manjunath Kondaiah
2011-10-07 6:49 ` Greg KH
2011-10-07 6:49 ` Greg KH
2011-10-07 20:57 ` Josh Triplett
2011-10-07 20:57 ` Josh Triplett
2011-10-07 21:23 ` Greg KH
2011-10-07 21:23 ` Greg KH
2011-10-08 4:03 ` Josh Triplett
2011-10-08 4:03 ` Josh Triplett
2011-10-08 15:55 ` Greg KH
2011-10-08 15:55 ` Greg KH
2011-10-08 18:18 ` Josh Triplett
2011-10-08 18:18 ` Josh Triplett
2011-10-10 17:37 ` Andrei Warkentin
2011-10-10 17:37 ` Andrei Warkentin
2011-10-11 12:29 ` Ming Lei
2011-10-11 12:29 ` Ming Lei
2011-10-13 4:09 ` Grant Likely
2011-10-13 4:09 ` Grant Likely
2011-10-13 14:18 ` Ming Lei
2011-10-13 14:18 ` Ming Lei
2011-10-13 14:31 ` Alan Stern
2011-10-13 14:31 ` Alan Stern
2011-10-13 14:31 ` Alan Stern
2011-10-13 15:21 ` Ming Lei
2011-10-13 15:21 ` Ming Lei
2011-10-13 16:04 ` Alan Stern
2011-10-13 16:04 ` Alan Stern
2011-10-13 16:04 ` Alan Stern
2011-10-14 0:13 ` Ming Lei
2011-10-14 0:13 ` Ming Lei
2011-10-13 17:15 ` Grant Likely
2011-10-13 17:15 ` Grant Likely
2011-10-13 18:16 ` Alan Stern
2011-10-13 18:16 ` Alan Stern
2011-10-13 18:16 ` Alan Stern
2011-10-13 18:28 ` Grant Likely
2011-10-13 18:28 ` Grant Likely
2011-10-14 15:39 ` Alan Stern
2011-10-14 15:39 ` Alan Stern
2011-10-14 15:39 ` Alan Stern
2011-10-14 16:17 ` Grant Likely
2011-10-14 16:17 ` Grant Likely
2011-10-14 16:33 ` Alan Stern
2011-10-14 16:33 ` Alan Stern
2011-10-14 16:33 ` Alan Stern
2011-10-14 17:20 ` Grant Likely
2011-10-14 17:20 ` Grant Likely
2011-10-14 17:33 ` Alan Stern
2011-10-14 17:33 ` Alan Stern
2011-10-14 17:33 ` Alan Stern
2011-10-14 18:25 ` Grant Likely
2011-10-14 18:25 ` Grant Likely
2011-10-14 18:39 ` Alan Stern
2011-10-14 18:39 ` Alan Stern
2011-10-14 18:39 ` Alan Stern
2011-10-14 19:07 ` Grant Likely
2011-10-14 19:07 ` Grant Likely
2011-10-14 18:56 ` David Daney
2011-10-14 18:56 ` David Daney
2011-10-14 19:03 ` Grant Likely
2011-10-14 19:03 ` Grant Likely
2011-10-14 19:03 ` Grant Likely
2011-10-14 19:09 ` David Daney
2011-10-14 19:09 ` David Daney
2011-10-14 15:37 ` Alan Stern
2011-10-14 15:37 ` Alan Stern
2011-10-14 15:37 ` Alan Stern
2011-10-12 7:04 ` G, Manjunath Kondaiah
2011-10-12 7:04 ` G, Manjunath Kondaiah
2011-10-07 21:28 ` Grant Likely
2011-10-07 21:28 ` Grant Likely
2011-10-07 21:28 ` Grant Likely
2011-10-07 5:33 ` [PATCH 3/5] regulator: Support driver probe deferral G, Manjunath Kondaiah
2011-10-07 5:33 ` [PATCH 4/5] gpiolib: handle deferral probe error G, Manjunath Kondaiah
2011-10-07 10:06 ` Alan Cox
2011-10-07 10:06 ` Alan Cox
2011-10-07 10:06 ` Alan Cox
2011-10-07 22:09 ` Grant Likely
2011-10-07 22:09 ` Grant Likely
2011-10-12 6:14 ` G, Manjunath Kondaiah
2011-10-12 6:14 ` G, Manjunath Kondaiah
2011-10-12 6:14 ` G, Manjunath Kondaiah
2011-10-13 4:12 ` Grant Likely
2011-10-13 4:12 ` Grant Likely
2011-10-07 5:33 ` [PATCH 5/5] omap: hsmmc: use platform_driver_register G, Manjunath Kondaiah
2011-10-07 6:50 ` [PATCH 0/5] Driver Probe Deferral Mechanism Greg KH
2011-10-07 6:50 ` Greg KH
2011-10-07 6:50 ` Greg KH
2011-10-07 7:37 ` G, Manjunath Kondaiah
2011-10-07 7:37 ` G, Manjunath Kondaiah
2011-10-07 7:37 ` G, Manjunath Kondaiah
-- strict thread matches above, loose matches on Subject: below --
2011-10-07 5:05 G, Manjunath Kondaiah
2011-10-07 5:05 ` [PATCH 1/5] drivercore: add new error value for deferred probe G, Manjunath Kondaiah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111007100022.GB19080@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=dilee@nvidia.com \
--cc=grant.likely@secretlab.ca \
--cc=greg@kroah.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=manjugk@ti.com \
--cc=manjunath.gkondaiah@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.