All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: 'Ben Dooks' <ben-linux@fluff.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 0/8] S3C2416: Enable armdiv and armclk
Date: Fri, 14 Oct 2011 09:27:17 +0200	[thread overview]
Message-ID: <201110140927.18860.heiko@sntech.de> (raw)
In-Reply-To: <085f01cc8a40$df7af8a0$9e70e9e0$%kim@samsung.com>

Hi Kgene,

Am Freitag, 14. Oktober 2011, 09:14:11 schrieb Kukjin Kim:
> Heiko Stübner wrote:
[...]
> > Heiko Stuebner (8):
> >   S3C2416: Add armdiv_mask constant.
[...]
> As a note, if required, 1st patch which is fixing will be sent to stable.

I don't think this is really necessary.

The original code was essentially correct but hard to read.
The constant makes sense in the rework, as the armdiv_mask is is used in more 
places now and not contained in a single static function.

Heiko

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/8] S3C2416: Enable armdiv and armclk
Date: Fri, 14 Oct 2011 09:27:17 +0200	[thread overview]
Message-ID: <201110140927.18860.heiko@sntech.de> (raw)
In-Reply-To: <085f01cc8a40$df7af8a0$9e70e9e0$%kim@samsung.com>

Hi Kgene,

Am Freitag, 14. Oktober 2011, 09:14:11 schrieb Kukjin Kim:
> Heiko St?bner wrote:
[...]
> > Heiko Stuebner (8):
> >   S3C2416: Add armdiv_mask constant.
[...]
> As a note, if required, 1st patch which is fixing will be sent to stable.

I don't think this is really necessary.

The original code was essentially correct but hard to read.
The constant makes sense in the rework, as the armdiv_mask is is used in more 
places now and not contained in a single static function.

Heiko

  reply	other threads:[~2011-10-14  7:27 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-28 10:17 [PATCH 0/8] S3C2416: Enable armdiv and armclk Heiko Stübner
2011-09-28 10:17 ` Heiko Stübner
2011-09-28 10:18 ` [PATCH 1/8] S3C2416: Add armdiv_mask constant Heiko Stübner
2011-09-28 10:18   ` Heiko Stübner
2011-09-28 10:19 ` [PATCH 2/8] S3C2443: Add infrastructure to transmit armdiv to common code Heiko Stübner
2011-09-28 10:19   ` Heiko Stübner
2011-09-28 10:20 ` [PATCH 3/8] S3C2443: Move clk_arm and clk_armdiv " Heiko Stübner
2011-09-28 10:20   ` Heiko Stübner
2011-09-28 10:20 ` [PATCH 4/8] S3C2416: Add comment describing the armdiv/armclk Heiko Stübner
2011-09-28 10:20   ` Heiko Stübner
2011-09-28 10:21 ` [PATCH 5/8] S3C2443: Add get_rate operation for clk_armdiv Heiko Stübner
2011-09-28 10:21   ` Heiko Stübner
2011-09-28 10:22 ` [PATCH 6/8] S3C2443: handle unset armdiv values gracefully Heiko Stübner
2011-09-28 10:22   ` Heiko Stübner
2011-09-28 10:22 ` [PATCH 7/8] S3C2443: Accommodate cpufreq frequency scheme in armdiv Heiko Stübner
2011-09-28 10:22   ` Heiko Stübner
2011-09-28 10:23 ` [PATCH 8/8] S3C2443: use clk_get_rate to init fclk in common_setup_clocks Heiko Stübner
2011-09-28 10:23   ` Heiko Stübner
2011-10-14  7:14 ` [PATCH 0/8] S3C2416: Enable armdiv and armclk Kukjin Kim
2011-10-14  7:14   ` Kukjin Kim
2011-10-14  7:27   ` Heiko Stübner [this message]
2011-10-14  7:27     ` Heiko Stübner
2011-10-14  7:44     ` Kukjin Kim
2011-10-14  7:44       ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110140927.18860.heiko@sntech.de \
    --to=heiko@sntech.de \
    --cc=ben-linux@fluff.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.