* Re: Re: [PATCH] mtd m25p80: add support for Macronix MX25L12805D
@ 2011-10-16 0:32 Kevin Paul Herbert
2011-10-16 23:04 ` Lennert Buytenhek
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Paul Herbert @ 2011-10-16 0:32 UTC (permalink / raw)
To: buytenh; +Cc: linux-mtd
Is there a reason that you did not include SECT_4K for the MX25L12805D?
The chips that I have support it, and its in the data sheet. Was this
an oversight or is there a problem with some chips?
I searched the archives from May, 2009, and did not see any discussion
on this issue.
If there are no problems, do you see a problem with me submitting a patch
to change this?
Thanks,
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Re: [PATCH] mtd m25p80: add support for Macronix MX25L12805D
2011-10-16 0:32 Re: [PATCH] mtd m25p80: add support for Macronix MX25L12805D Kevin Paul Herbert
@ 2011-10-16 23:04 ` Lennert Buytenhek
2011-10-16 23:40 ` Kevin Cernekee
0 siblings, 1 reply; 3+ messages in thread
From: Lennert Buytenhek @ 2011-10-16 23:04 UTC (permalink / raw)
To: Kevin Paul Herbert; +Cc: linux-mtd
On Sat, Oct 15, 2011 at 05:32:42PM -0700, Kevin Paul Herbert wrote:
> Is there a reason that you did not include SECT_4K for the MX25L12805D?
> The chips that I have support it, and its in the data sheet. Was this
> an oversight or is there a problem with some chips?
An oversight. If SECT_4K works for you (I don't have hardware to test
with anymore), go ahead and submit a patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Re: [PATCH] mtd m25p80: add support for Macronix MX25L12805D
2011-10-16 23:04 ` Lennert Buytenhek
@ 2011-10-16 23:40 ` Kevin Cernekee
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Cernekee @ 2011-10-16 23:40 UTC (permalink / raw)
To: Lennert Buytenhek; +Cc: linux-mtd, Kevin Paul Herbert
On Sun, Oct 16, 2011 at 4:04 PM, Lennert Buytenhek
<buytenh@wantstofly.org> wrote:
> On Sat, Oct 15, 2011 at 05:32:42PM -0700, Kevin Paul Herbert wrote:
>
>> Is there a reason that you did not include SECT_4K for the MX25L12805D?
>> The chips that I have support it, and its in the data sheet. Was this
>> an oversight or is there a problem with some chips?
>
> An oversight. If SECT_4K works for you (I don't have hardware to test
> with anymore), go ahead and submit a patch.
There are a couple of potential pitfalls with SECT_4K:
1) It can have a significant impact on performance and filesystem
overhead. Erasing 16x 4KiB sectors may be considerably slower than
erasing one 64KiB block. On a 2MiB flash it's probably well worth the
cost, but probably not on a 32MiB flash.
2) Enabling SECT_4K after the fact may break pre-existing UBI volumes,
since UBI sets its operating parameters based on the eraseblock size
reported from MTD.
3) Some devices do support 4KiB sectors, but only for specific ranges
(not across the whole device).
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-16 23:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-16 0:32 Re: [PATCH] mtd m25p80: add support for Macronix MX25L12805D Kevin Paul Herbert
2011-10-16 23:04 ` Lennert Buytenhek
2011-10-16 23:40 ` Kevin Cernekee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.