From: Tejun Heo <tj@kernel.org>
To: Andrew Watts <akwatts@ymail.com>
Cc: linux-pm@lists.linux-foundation.org, dmitry.torokhov@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION]: hibernate/sleep regression w/ bisection
Date: Tue, 1 Nov 2011 13:19:02 -0700 [thread overview]
Message-ID: <20111101201902.GA1763@google.com> (raw)
In-Reply-To: <20111101191459.GA2748@zeus>
On Tue, Nov 01, 2011 at 02:15:16PM -0500, Andrew Watts wrote:
> On Tue, Nov 01, 2011 at 09:42:35AM -0700, Tejun Heo wrote:
> >
> > Does the following patch fix the problem?
> >
> > Thanks.
>
> Unfortunately, it does not fix the problem.
Odd... how about the following one? Thanks.
diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c
index ba70058..14d560a 100644
--- a/drivers/input/serio/serio.c
+++ b/drivers/input/serio/serio.c
@@ -299,9 +299,8 @@ static int serio_queue_event(void *object, struct module *owner,
event->owner = owner;
list_add_tail(&event->node, &serio_event_list);
- queue_work(system_long_wq, &serio_event_work);
-
out:
+ queue_work(system_long_wq, &serio_event_work);
spin_unlock_irqrestore(&serio_event_lock, flags);
return retval;
}
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Andrew Watts <akwatts@ymail.com>
Cc: linux-kernel@vger.kernel.org,
linux-pm@lists.linux-foundation.org, dmitry.torokhov@gmail.com
Subject: Re: [REGRESSION]: hibernate/sleep regression w/ bisection
Date: Tue, 1 Nov 2011 13:19:02 -0700 [thread overview]
Message-ID: <20111101201902.GA1763@google.com> (raw)
In-Reply-To: <20111101191459.GA2748@zeus>
On Tue, Nov 01, 2011 at 02:15:16PM -0500, Andrew Watts wrote:
> On Tue, Nov 01, 2011 at 09:42:35AM -0700, Tejun Heo wrote:
> >
> > Does the following patch fix the problem?
> >
> > Thanks.
>
> Unfortunately, it does not fix the problem.
Odd... how about the following one? Thanks.
diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c
index ba70058..14d560a 100644
--- a/drivers/input/serio/serio.c
+++ b/drivers/input/serio/serio.c
@@ -299,9 +299,8 @@ static int serio_queue_event(void *object, struct module *owner,
event->owner = owner;
list_add_tail(&event->node, &serio_event_list);
- queue_work(system_long_wq, &serio_event_work);
-
out:
+ queue_work(system_long_wq, &serio_event_work);
spin_unlock_irqrestore(&serio_event_lock, flags);
return retval;
}
next prev parent reply other threads:[~2011-11-01 20:19 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 12:48 [REGRESSION]: hibernate/sleep regression w/ bisection Andrew Watts
2011-11-01 16:42 ` Tejun Heo
2011-11-01 16:42 ` Tejun Heo
2011-11-01 19:15 ` Andrew Watts
2011-11-01 19:15 ` Andrew Watts
2011-11-01 20:19 ` Tejun Heo [this message]
2011-11-01 20:19 ` Tejun Heo
2011-11-02 0:24 ` Andrew Watts
2011-11-02 0:24 ` Andrew Watts
2011-11-02 5:46 ` Dmitry Torokhov
2011-11-02 5:46 ` Dmitry Torokhov
2011-11-02 15:04 ` Andrew Watts
2011-11-02 15:04 ` Andrew Watts
2011-11-02 16:02 ` Andrew Watts
2011-11-02 16:02 ` Andrew Watts
2011-11-02 16:31 ` Dmitry Torokhov
2011-11-02 16:31 ` Dmitry Torokhov
2011-11-02 17:01 ` Andrew Watts
2011-11-02 17:01 ` Andrew Watts
2011-11-02 17:08 ` Dmitry Torokhov
2011-11-02 17:08 ` Dmitry Torokhov
2011-11-03 15:59 ` Tejun Heo
2011-11-03 15:59 ` Tejun Heo
2011-11-03 18:46 ` Andrew Watts
2011-11-03 21:39 ` Tejun Heo
2011-11-03 21:39 ` Tejun Heo
2011-11-04 13:44 ` Andrew Watts
2011-11-04 16:14 ` Tejun Heo
2011-11-04 16:48 ` Jerome Glisse
2011-11-04 16:48 ` Jerome Glisse
2011-11-04 17:34 ` Andrew Watts
2011-11-04 17:35 ` Jerome Glisse
2011-11-04 17:35 ` Jerome Glisse
2011-11-04 23:08 ` Andrew Watts
2011-11-21 21:09 ` Tejun Heo
2011-11-21 21:09 ` Tejun Heo
2011-11-21 21:29 ` Jerome Glisse
2011-11-21 21:29 ` Jerome Glisse
2011-11-22 11:40 ` Andrew Watts
2011-11-22 11:40 ` Andrew Watts
2011-11-04 23:08 ` Andrew Watts
2011-11-04 17:44 ` Jerome Glisse
2011-11-04 18:45 ` Andrew Watts
2011-11-04 18:45 ` Andrew Watts
2011-11-04 17:44 ` Jerome Glisse
2011-11-04 17:34 ` Andrew Watts
2012-04-25 20:04 ` Andrew Watts
2011-11-04 16:14 ` Tejun Heo
2011-11-04 13:44 ` Andrew Watts
2011-11-03 18:46 ` Andrew Watts
-- strict thread matches above, loose matches on Subject: below --
2011-11-01 12:48 Andrew Watts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111101201902.GA1763@google.com \
--to=tj@kernel.org \
--cc=akwatts@ymail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.