From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Simon Que <sque@chromium.org>
Cc: intel-gfx@lists.freedesktop.org, olofj@chromium.org, snanda@chromium.org
Subject: Re: [PATCH v3 2/2] drivers: i915: Default max backlight brightness value
Date: Tue, 8 Nov 2011 22:47:39 +0000 [thread overview]
Message-ID: <20111108224739.GA19936@srcf.ucam.org> (raw)
In-Reply-To: <CANV8Hs273tcu+-oMiNwMVdDVroC5qY9k4g2CGeA4_RZS14WUAA@mail.gmail.com>
On Tue, Nov 08, 2011 at 02:41:56PM -0800, Simon Que wrote:
> There is a backup kernel partition that can be used for boot.
>
> Failing that, the system can boot from a recovery image over USB.
So absolutely no video code in the firmware at all? Ok. What I'd really
rather see here is some generic way for platform-specific code to pass
the correct value to the driver. You're already exposing various things
via the chromeos-acpi code, can you use that to set things up sensibly?
It's obviously possible to use the command line to transfer this
information, it's just considered pretty poor style.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-11-08 22:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 21:35 [PATCH 1/2] drivers: i915: Fix BLC PWM register setup Simon Que
2011-11-08 21:35 ` [PATCH v3 2/2] drivers: i915: Default max backlight brightness value Simon Que
2011-11-08 21:42 ` Matthew Garrett
2011-11-08 22:05 ` Simon Que
2011-11-08 22:10 ` Matthew Garrett
2011-11-08 22:27 ` Simon Que
2011-11-08 22:28 ` Matthew Garrett
2011-11-08 22:41 ` Simon Que
2011-11-08 22:47 ` Matthew Garrett [this message]
2011-11-08 23:02 ` Olof Johansson
2011-11-08 23:11 ` Matthew Garrett
2011-11-09 1:49 ` Olof Johansson
2011-11-09 2:16 ` Bryan Freed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108224739.GA19936@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=olofj@chromium.org \
--cc=snanda@chromium.org \
--cc=sque@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.