From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Olof Johansson <olof@lixom.net>
Cc: intel-gfx@lists.freedesktop.org, olofj@chromium.org,
snanda@chromium.org, Simon Que <sque@chromium.org>
Subject: Re: [PATCH v3 2/2] drivers: i915: Default max backlight brightness value
Date: Tue, 8 Nov 2011 23:11:34 +0000 [thread overview]
Message-ID: <20111108231134.GA20232@srcf.ucam.org> (raw)
In-Reply-To: <CAOesGMhM5x1Dj+rQCEskkfx1bEE5fOzVHks99tkMBOexN-vC-g@mail.gmail.com>
On Tue, Nov 08, 2011 at 03:02:00PM -0800, Olof Johansson wrote:
> How about a DMI table check that overrides whatever is setup (or not
> setup) from the video bios? We know exactly what platforms need this
> so that table would be easy to specify.
dmi's horribly unscalable. It's much better to have a communication
channel that doesn't require new code for new models of the same
platform.
> I'm not sure how well this would fit into our platform layer code, it
> would be pretty nasty to have to export the default backlight variable
> from the i915 driver and modify it from there as well, and I'm sure
> noone wants to see any kind of chromeos-specific code paths in the 915
> driver (myself included).
Well right now this path is (effectively) chromeos-specific. Refactoring
the code so we just have the register readback as a single information
source and allow the existing platform-specific code to hook in would be
conceptually cleaner. But then maybe this is grotesque over-engineering
and we should just hack this case.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-11-08 23:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 21:35 [PATCH 1/2] drivers: i915: Fix BLC PWM register setup Simon Que
2011-11-08 21:35 ` [PATCH v3 2/2] drivers: i915: Default max backlight brightness value Simon Que
2011-11-08 21:42 ` Matthew Garrett
2011-11-08 22:05 ` Simon Que
2011-11-08 22:10 ` Matthew Garrett
2011-11-08 22:27 ` Simon Que
2011-11-08 22:28 ` Matthew Garrett
2011-11-08 22:41 ` Simon Que
2011-11-08 22:47 ` Matthew Garrett
2011-11-08 23:02 ` Olof Johansson
2011-11-08 23:11 ` Matthew Garrett [this message]
2011-11-09 1:49 ` Olof Johansson
2011-11-09 2:16 ` Bryan Freed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108231134.GA20232@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=olof@lixom.net \
--cc=olofj@chromium.org \
--cc=snanda@chromium.org \
--cc=sque@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.