From: Vivek Goyal <vgoyal@redhat.com>
To: Dave Young <dyoung@redhat.com>
Cc: kexec@lists.infradead.org, ebiederm@xmission.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kdump: kill redundant code
Date: Wed, 9 Nov 2011 10:20:13 -0500 [thread overview]
Message-ID: <20111109152012.GA12537@redhat.com> (raw)
In-Reply-To: <20111109070452.GA25768@darkstar.nay.redhat.com>
On Wed, Nov 09, 2011 at 03:04:52PM +0800, Dave Young wrote:
> in while loop below, hole_end > crashk_res.end is impossible:
> while (hole_end <= crashk_res.end) {
> [snip]
> }
> Killing the check code here
>
> Signed-off-by: Dave Young <dyoung@redhat.com>
Makes sense.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
> ---
> kernel/kexec.c | 2 --
> 1 file changed, 2 deletions(-)
>
> --- linux-2.6.orig/kernel/kexec.c 2011-11-01 13:06:20.000000000 +0800
> +++ linux-2.6/kernel/kexec.c 2011-11-09 14:57:17.487022644 +0800
> @@ -500,8 +500,6 @@ static struct page *kimage_alloc_crash_c
>
> if (hole_end > KEXEC_CRASH_CONTROL_MEMORY_LIMIT)
> break;
> - if (hole_end > crashk_res.end)
> - break;
> /* See if I overlap any of the segments */
> for (i = 0; i < image->nr_segments; i++) {
> unsigned long mstart, mend;
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Dave Young <dyoung@redhat.com>
Cc: ebiederm@xmission.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kdump: kill redundant code
Date: Wed, 9 Nov 2011 10:20:13 -0500 [thread overview]
Message-ID: <20111109152012.GA12537@redhat.com> (raw)
In-Reply-To: <20111109070452.GA25768@darkstar.nay.redhat.com>
On Wed, Nov 09, 2011 at 03:04:52PM +0800, Dave Young wrote:
> in while loop below, hole_end > crashk_res.end is impossible:
> while (hole_end <= crashk_res.end) {
> [snip]
> }
> Killing the check code here
>
> Signed-off-by: Dave Young <dyoung@redhat.com>
Makes sense.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
> ---
> kernel/kexec.c | 2 --
> 1 file changed, 2 deletions(-)
>
> --- linux-2.6.orig/kernel/kexec.c 2011-11-01 13:06:20.000000000 +0800
> +++ linux-2.6/kernel/kexec.c 2011-11-09 14:57:17.487022644 +0800
> @@ -500,8 +500,6 @@ static struct page *kimage_alloc_crash_c
>
> if (hole_end > KEXEC_CRASH_CONTROL_MEMORY_LIMIT)
> break;
> - if (hole_end > crashk_res.end)
> - break;
> /* See if I overlap any of the segments */
> for (i = 0; i < image->nr_segments; i++) {
> unsigned long mstart, mend;
next prev parent reply other threads:[~2011-11-09 15:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 7:04 [PATCH] kdump: kill redundant code Dave Young
2011-11-09 7:04 ` Dave Young
2011-11-09 15:20 ` Vivek Goyal [this message]
2011-11-09 15:20 ` Vivek Goyal
2011-11-10 2:33 ` Simon Horman
2011-11-10 2:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111109152012.GA12537@redhat.com \
--to=vgoyal@redhat.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.