* [PATCH] kdump: kill redundant code
@ 2011-11-09 7:04 ` Dave Young
0 siblings, 0 replies; 6+ messages in thread
From: Dave Young @ 2011-11-09 7:04 UTC (permalink / raw)
To: ebiederm, vgoyal, kexec, linux-kernel
in while loop below, hole_end > crashk_res.end is impossible:
while (hole_end <= crashk_res.end) {
[snip]
}
Killing the check code here
Signed-off-by: Dave Young <dyoung@redhat.com>
---
kernel/kexec.c | 2 --
1 file changed, 2 deletions(-)
--- linux-2.6.orig/kernel/kexec.c 2011-11-01 13:06:20.000000000 +0800
+++ linux-2.6/kernel/kexec.c 2011-11-09 14:57:17.487022644 +0800
@@ -500,8 +500,6 @@ static struct page *kimage_alloc_crash_c
if (hole_end > KEXEC_CRASH_CONTROL_MEMORY_LIMIT)
break;
- if (hole_end > crashk_res.end)
- break;
/* See if I overlap any of the segments */
for (i = 0; i < image->nr_segments; i++) {
unsigned long mstart, mend;
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] kdump: kill redundant code
@ 2011-11-09 7:04 ` Dave Young
0 siblings, 0 replies; 6+ messages in thread
From: Dave Young @ 2011-11-09 7:04 UTC (permalink / raw)
To: ebiederm, vgoyal, kexec, linux-kernel
in while loop below, hole_end > crashk_res.end is impossible:
while (hole_end <= crashk_res.end) {
[snip]
}
Killing the check code here
Signed-off-by: Dave Young <dyoung@redhat.com>
---
kernel/kexec.c | 2 --
1 file changed, 2 deletions(-)
--- linux-2.6.orig/kernel/kexec.c 2011-11-01 13:06:20.000000000 +0800
+++ linux-2.6/kernel/kexec.c 2011-11-09 14:57:17.487022644 +0800
@@ -500,8 +500,6 @@ static struct page *kimage_alloc_crash_c
if (hole_end > KEXEC_CRASH_CONTROL_MEMORY_LIMIT)
break;
- if (hole_end > crashk_res.end)
- break;
/* See if I overlap any of the segments */
for (i = 0; i < image->nr_segments; i++) {
unsigned long mstart, mend;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kdump: kill redundant code
2011-11-09 7:04 ` Dave Young
@ 2011-11-09 15:20 ` Vivek Goyal
-1 siblings, 0 replies; 6+ messages in thread
From: Vivek Goyal @ 2011-11-09 15:20 UTC (permalink / raw)
To: Dave Young; +Cc: kexec, ebiederm, linux-kernel
On Wed, Nov 09, 2011 at 03:04:52PM +0800, Dave Young wrote:
> in while loop below, hole_end > crashk_res.end is impossible:
> while (hole_end <= crashk_res.end) {
> [snip]
> }
> Killing the check code here
>
> Signed-off-by: Dave Young <dyoung@redhat.com>
Makes sense.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
> ---
> kernel/kexec.c | 2 --
> 1 file changed, 2 deletions(-)
>
> --- linux-2.6.orig/kernel/kexec.c 2011-11-01 13:06:20.000000000 +0800
> +++ linux-2.6/kernel/kexec.c 2011-11-09 14:57:17.487022644 +0800
> @@ -500,8 +500,6 @@ static struct page *kimage_alloc_crash_c
>
> if (hole_end > KEXEC_CRASH_CONTROL_MEMORY_LIMIT)
> break;
> - if (hole_end > crashk_res.end)
> - break;
> /* See if I overlap any of the segments */
> for (i = 0; i < image->nr_segments; i++) {
> unsigned long mstart, mend;
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kdump: kill redundant code
@ 2011-11-09 15:20 ` Vivek Goyal
0 siblings, 0 replies; 6+ messages in thread
From: Vivek Goyal @ 2011-11-09 15:20 UTC (permalink / raw)
To: Dave Young; +Cc: ebiederm, kexec, linux-kernel
On Wed, Nov 09, 2011 at 03:04:52PM +0800, Dave Young wrote:
> in while loop below, hole_end > crashk_res.end is impossible:
> while (hole_end <= crashk_res.end) {
> [snip]
> }
> Killing the check code here
>
> Signed-off-by: Dave Young <dyoung@redhat.com>
Makes sense.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
> ---
> kernel/kexec.c | 2 --
> 1 file changed, 2 deletions(-)
>
> --- linux-2.6.orig/kernel/kexec.c 2011-11-01 13:06:20.000000000 +0800
> +++ linux-2.6/kernel/kexec.c 2011-11-09 14:57:17.487022644 +0800
> @@ -500,8 +500,6 @@ static struct page *kimage_alloc_crash_c
>
> if (hole_end > KEXEC_CRASH_CONTROL_MEMORY_LIMIT)
> break;
> - if (hole_end > crashk_res.end)
> - break;
> /* See if I overlap any of the segments */
> for (i = 0; i < image->nr_segments; i++) {
> unsigned long mstart, mend;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kdump: kill redundant code
2011-11-09 15:20 ` Vivek Goyal
@ 2011-11-10 2:33 ` Simon Horman
-1 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2011-11-10 2:33 UTC (permalink / raw)
To: Vivek Goyal; +Cc: kexec, Dave Young, ebiederm, linux-kernel
On Wed, Nov 09, 2011 at 10:20:13AM -0500, Vivek Goyal wrote:
> On Wed, Nov 09, 2011 at 03:04:52PM +0800, Dave Young wrote:
> > in while loop below, hole_end > crashk_res.end is impossible:
> > while (hole_end <= crashk_res.end) {
> > [snip]
> > }
> > Killing the check code here
> >
> > Signed-off-by: Dave Young <dyoung@redhat.com>
>
> Makes sense.
>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
Indeed it does. I wonder if this was always so redundant.
Acked-by: Simon Horman <horms@verge.net.au>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kdump: kill redundant code
@ 2011-11-10 2:33 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2011-11-10 2:33 UTC (permalink / raw)
To: Vivek Goyal; +Cc: Dave Young, kexec, ebiederm, linux-kernel
On Wed, Nov 09, 2011 at 10:20:13AM -0500, Vivek Goyal wrote:
> On Wed, Nov 09, 2011 at 03:04:52PM +0800, Dave Young wrote:
> > in while loop below, hole_end > crashk_res.end is impossible:
> > while (hole_end <= crashk_res.end) {
> > [snip]
> > }
> > Killing the check code here
> >
> > Signed-off-by: Dave Young <dyoung@redhat.com>
>
> Makes sense.
>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
Indeed it does. I wonder if this was always so redundant.
Acked-by: Simon Horman <horms@verge.net.au>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-11-10 2:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-09 7:04 [PATCH] kdump: kill redundant code Dave Young
2011-11-09 7:04 ` Dave Young
2011-11-09 15:20 ` Vivek Goyal
2011-11-09 15:20 ` Vivek Goyal
2011-11-10 2:33 ` Simon Horman
2011-11-10 2:33 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.