[lm-sensors] [PATCH] Drivers: hwmon: it87: Add support for ITE 8728

[lm-sensors] [PATCH] Drivers: hwmon: it87: Add support for ITE 8728

[Frank T. Lofaro Jr.]

[-- Attachment #1.1: Type: text/plain, Size: 1330 bytes --]

This patch allows the ITE 8728 chip to be detected and used.
The chip appears to be compatible with the 8721.

Signed-off-by: Frank T. Lofaro Jr. <ftlofaro@yahoo.com>
---
 drivers/hwmon/it87.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
index d912649..0b21d18 100644
--- a/drivers/hwmon/it87.c
+++ b/drivers/hwmon/it87.c
@@ -17,6 +17,7 @@
  *            IT8720F  Super I/O chip w/LPC interface
  *            IT8721F  Super I/O chip w/LPC interface
  *            IT8726F  Super I/O chip w/LPC interface
+ *            IT8728F  Super I/O chip w/LPC interface
  *            IT8758E  Super I/O chip w/LPC interface
  *            Sis950   A clone of the IT8705F
  *
@@ -135,6 +136,7 @@ static inline void superio_exit(void)
 #define IT8720F_DEVID 0x8720
 #define IT8721F_DEVID 0x8721
 #define IT8726F_DEVID 0x8726
+#define IT8728F_DEVID 0x8728
 #define IT87_ACT_REG  0x30
 #define IT87_BASE_REG 0x60
 
@@ -1603,6 +1605,7 @@ static int __init it87_find(unsigned short *address,
                sio_data->type = it8720;
                break;
        case IT8721F_DEVID:
+       case IT8728F_DEVID:
                sio_data->type = it8721;
                break;
        case 0xffff:    /* No device at all */
-- 
1.7.7.2

[-- Attachment #1.2: Type: text/html, Size: 2445 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] Drivers: hwmon: it87: Add support for ITE

[Guenter Roeck]

On Fri, 2011-11-04 at 00:44 -0400, Frank T. Lofaro Jr. wrote:
> This patch allows the ITE 8728 chip to be detected and used.
> The chip appears to be compatible with the 8721.
> 

Can anyone confirm that those chips are actually compatible ?

Thanks,
Guenter

Signed-off-by: Frank T. Lofaro Jr. <ftlofaro@yahoo.com>
> ---
>  drivers/hwmon/it87.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
> index d912649..0b21d18 100644
> --- a/drivers/hwmon/it87.c
> +++ b/drivers/hwmon/it87.c
> @@ -17,6 +17,7 @@
>   *            IT8720F  Super I/O chip w/LPC interface
>   *            IT8721F  Super I/O chip w/LPC interface
>   *            IT8726F  Super I/O chip w/LPC interface
> + *            IT8728F  Super I/O chip w/LPC interface
>   *            IT8758E  Super I/O chip w/LPC interface
>   *            Sis950   A clone of the IT8705F
>   *
> @@ -135,6 +136,7 @@ static inline void superio_exit(void)
>  #define IT8720F_DEVID 0x8720
>  #define IT8721F_DEVID 0x8721
>  #define IT8726F_DEVID 0x8726
> +#define IT8728F_DEVID 0x8728
>  #define IT87_ACT_REG  0x30
>  #define IT87_BASE_REG 0x60
>  
> @@ -1603,6 +1605,7 @@ static int __init it87_find(unsigned short
> *address,
>                 sio_data->type = it8720;
>                 break;
>         case IT8721F_DEVID:
> +       case IT8728F_DEVID:
>                 sio_data->type = it8721;
>                 break;
>         case 0xffff:    /* No device at all */
> -- 
> 1.7.7.2
> 
> 



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [PATCH] Drivers: hwmon: it87: Add support for ITE 8728

[Guenter Roeck]

On Fri, 2011-11-04 at 00:44 -0400, Frank T. Lofaro Jr. wrote:
> This patch allows the ITE 8728 chip to be detected and used.
> The chip appears to be compatible with the 8721.
> 

Can anyone confirm that those chips are actually compatible ?

Thanks,
Guenter

Signed-off-by: Frank T. Lofaro Jr. <ftlofaro@yahoo.com>
> ---
>  drivers/hwmon/it87.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
> index d912649..0b21d18 100644
> --- a/drivers/hwmon/it87.c
> +++ b/drivers/hwmon/it87.c
> @@ -17,6 +17,7 @@
>   *            IT8720F  Super I/O chip w/LPC interface
>   *            IT8721F  Super I/O chip w/LPC interface
>   *            IT8726F  Super I/O chip w/LPC interface
> + *            IT8728F  Super I/O chip w/LPC interface
>   *            IT8758E  Super I/O chip w/LPC interface
>   *            Sis950   A clone of the IT8705F
>   *
> @@ -135,6 +136,7 @@ static inline void superio_exit(void)
>  #define IT8720F_DEVID 0x8720
>  #define IT8721F_DEVID 0x8721
>  #define IT8726F_DEVID 0x8726
> +#define IT8728F_DEVID 0x8728
>  #define IT87_ACT_REG  0x30
>  #define IT87_BASE_REG 0x60
>  
> @@ -1603,6 +1605,7 @@ static int __init it87_find(unsigned short
> *address,
>                 sio_data->type = it8720;
>                 break;
>         case IT8721F_DEVID:
> +       case IT8728F_DEVID:
>                 sio_data->type = it8721;
>                 break;
>         case 0xffff:    /* No device at all */
> -- 
> 1.7.7.2
> 
> 

Re: [lm-sensors] [PATCH] Drivers: hwmon: it87: Add support for ITE

[Jean Delvare]

On Mon, 7 Nov 2011 10:00:45 -0800, Guenter Roeck wrote:
> On Fri, 2011-11-04 at 00:44 -0400, Frank T. Lofaro Jr. wrote:
> > This patch allows the ITE 8728 chip to be detected and used.
> > The chip appears to be compatible with the 8721.

Frank, can we see the output of "sensors" on your system with your
patch applied?

> Can anyone confirm that those chips are actually compatible ?

The datasheet is not publicly available, unfortunately. The info I have
is that temperature and fan parts are likely to be compatible. Not so
sure about the voltages, although the ADC resolution is the same (12
mV.)

> > @@ -1603,6 +1605,7 @@ static int __init it87_find(unsigned short
> > *address,
> >                 sio_data->type = it8720;
> >                 break;
> >         case IT8721F_DEVID:
> > +       case IT8728F_DEVID:
> >                 sio_data->type = it8721;
> >                 break;
> >         case 0xffff:    /* No device at all */

One thing for sure: I want to play it safe and introduce a separate
chip type for the IT8728F. Two advantages: we can tell who has an
IT8728F from user reports easily, and we can add chip tweaks later
easily without breaking user configurations.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [PATCH] Drivers: hwmon: it87: Add support for ITE 8728

[Jean Delvare]

On Mon, 7 Nov 2011 10:00:45 -0800, Guenter Roeck wrote:
> On Fri, 2011-11-04 at 00:44 -0400, Frank T. Lofaro Jr. wrote:
> > This patch allows the ITE 8728 chip to be detected and used.
> > The chip appears to be compatible with the 8721.

Frank, can we see the output of "sensors" on your system with your
patch applied?

> Can anyone confirm that those chips are actually compatible ?

The datasheet is not publicly available, unfortunately. The info I have
is that temperature and fan parts are likely to be compatible. Not so
sure about the voltages, although the ADC resolution is the same (12
mV.)

> > @@ -1603,6 +1605,7 @@ static int __init it87_find(unsigned short
> > *address,
> >                 sio_data->type = it8720;
> >                 break;
> >         case IT8721F_DEVID:
> > +       case IT8728F_DEVID:
> >                 sio_data->type = it8721;
> >                 break;
> >         case 0xffff:    /* No device at all */

One thing for sure: I want to play it safe and introduce a separate
chip type for the IT8728F. Two advantages: we can tell who has an
IT8728F from user reports easily, and we can add chip tweaks later
easily without breaking user configurations.

-- 
Jean Delvare

Re: [lm-sensors] [PATCH] Drivers: hwmon: it87: Add support for ITE

[Gustavo De Nardin (spuk)]

> On Fri, 2011-11-04 at 00:44 -0400, Frank T. Lofaro Jr. wrote:
> > This patch allows the ITE 8728 chip to be detected and used.
> > The chip appears to be compatible with the 8721.
> > 
> 
> Can anyone confirm that those chips are actually compatible ?

Unlike forcing the other chips' ids, with force_id=0x8721 PWM control seems
to work reasonably, with pwm1_enable=1, pwm1=0 yields around 1132 RPM on the
CPU fan, and pwm1=255 yields around 3260 RPM.  Should pwm1=0 actually stop
the fan?  I get what (empirically) seem to be consistent logarithmic
increase in RPM when increasing pwm1 value, anyway.

But the sensors values read with 'it87 force_id=0x8721' don't seem ok, I get
this (first 'it87 force_id=0x8721', then 'asus_atk0110 new_if=1', which
seems to provide good readings):

it8721-isa-0290
Adapter: ISA adapter
in0:          +0.95 V  (min =  +2.78 V, max =  +1.14 V)  ALARM
in1:          +1.50 V  (min =  +0.00 V, max =  +3.01 V)
in2:          +1.88 V  (min =  +2.66 V, max =  +2.27 V)  ALARM
in3:          +2.05 V  (min =  +2.68 V, max =  +0.67 V)  ALARM
in4:          +2.03 V  (min =  +3.04 V, max =  +1.42 V)  ALARM
in5:          +3.05 V  (min =  +3.04 V, max =  +3.01 V)  ALARM
in6:          +2.05 V  (min =  +2.77 V, max =  +1.87 V)  ALARM
3VSB:         +6.07 V  (min =  +1.10 V, max =  +4.56 V)  ALARM
Vbat:         +3.34 V
fan1:        3292 RPM  (min =   10 RPM)
fan2:           0 RPM  (min =   10 RPM)  ALARM
fan3:           0 RPM  (min =   13 RPM)  ALARM
temp1:        +33.0°C  (low  = -65.0°C, high = -10.0°C)  sensor = thermistor
temp2:        +40.0°C  (low  = -19.0°C, high = +127.0°C)  sensor =
thermistor
temp3:       -128.0°C  (low  = +119.0°C, high =  -2.0°C)  sensor = disabled
intrusion0:  OK

atk0110-acpi-0
Adapter: ACPI interface
Vcore Voltage:      +0.95 V  (min =  +0.80 V, max =  +1.60 V)
+3.3V Voltage:      +3.34 V  (min =  +2.97 V, max =  +3.63 V)
+5V Voltage:        +5.13 V  (min =  +4.50 V, max =  +5.50 V)
+12V Voltage:      +12.11 V  (min = +10.20 V, max = +13.80 V)
CPU Fan Speed:     3276 RPM  (min =  600 RPM)
Chassis Fan Speed:    0 RPM  (min =  600 RPM)
CPU Temperature:    +33.0°C  (high = +60.0°C, crit = +95.0°C)
MB Temperature:     +40.0°C  (high = +45.0°C, crit = +75.0°C)


This is on an Asus M5A78L-M/USB3 mainboard.

t'


> 
> Thanks,
> Guenter
> 
> Signed-off-by: Frank T. Lofaro Jr. <ftlofaro at yahoo.com>
> > ---
> >  drivers/hwmon/it87.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
> > index d912649..0b21d18 100644
> > --- a/drivers/hwmon/it87.c
> > +++ b/drivers/hwmon/it87.c
> > @@ -17,6 +17,7 @@
> >   *            IT8720F  Super I/O chip w/LPC interface
> >   *            IT8721F  Super I/O chip w/LPC interface
> >   *            IT8726F  Super I/O chip w/LPC interface
> > + *            IT8728F  Super I/O chip w/LPC interface
> >   *            IT8758E  Super I/O chip w/LPC interface
> >   *            Sis950   A clone of the IT8705F
> >   *
> > @@ -135,6 +136,7 @@ static inline void superio_exit(void)
> >  #define IT8720F_DEVID 0x8720
> >  #define IT8721F_DEVID 0x8721
> >  #define IT8726F_DEVID 0x8726
> > +#define IT8728F_DEVID 0x8728
> >  #define IT87_ACT_REG  0x30
> >  #define IT87_BASE_REG 0x60
> >  
> > @@ -1603,6 +1605,7 @@ static int __init it87_find(unsigned short
> > *address,
> >                 sio_data->type = it8720;
> >                 break;
> >         case IT8721F_DEVID:
> > +       case IT8728F_DEVID:
> >                 sio_data->type = it8721;
> >                 break;
> >         case 0xffff:    /* No device at all */
> > -- 
> > 1.7.7.2

-- 
::question = (bool) _2b||!_2b;

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] Drivers: hwmon: it87: Add support for ITE

[Gustavo De Nardin]

T24gMTQgTm92ZW1iZXIgMjAxMSAxOToxNCwgR3VzdGF2byBEZSBOYXJkaW4gKHNwdWspIDxndXN0
YXZvZG5AZ21haWwuY29tPiB3cm90ZToKPj4gT24gRnJpLCAyMDExLTExLTA0IGF0IDAwOjQ0IC0w
NDAwLCBGcmFuayBULiBMb2Zhcm8gSnIuIHdyb3RlOgo+PiA+IFRoaXMgcGF0Y2ggYWxsb3dzIHRo
ZSBJVEUgODcyOCBjaGlwIHRvIGJlIGRldGVjdGVkIGFuZCB1c2VkLgo+PiA+IFRoZSBjaGlwIGFw
cGVhcnMgdG8gYmUgY29tcGF0aWJsZSB3aXRoIHRoZSA4NzIxLgo+Pgo+PiBDYW4gYW55b25lIGNv
bmZpcm0gdGhhdCB0aG9zZSBjaGlwcyBhcmUgYWN0dWFsbHkgY29tcGF0aWJsZSA/Cj4KPiBVbmxp
a2UgZm9yY2luZyB0aGUgb3RoZXIgY2hpcHMnIGlkcywgd2l0aCBmb3JjZV9pZD0weDg3MjEgUFdN
IGNvbnRyb2wgc2VlbXMKPiB0byB3b3JrIHJlYXNvbmFibHksIHdpdGggcHdtMV9lbmFibGU9MSwg
cHdtMT0wIHlpZWxkcyBhcm91bmQgMTEzMiBSUE0gb24gdGhlCj4gQ1BVIGZhbiwgYW5kIHB3bTE9
MjU1IHlpZWxkcyBhcm91bmQgMzI2MCBSUE0uIMKgU2hvdWxkIHB3bTE9MCBhY3R1YWxseSBzdG9w
Cj4gdGhlIGZhbj8gwqBJIGdldCB3aGF0IChlbXBpcmljYWxseSkgc2VlbSB0byBiZSBjb25zaXN0
ZW50IGxvZ2FyaXRobWljCj4gaW5jcmVhc2UgaW4gUlBNIHdoZW4gaW5jcmVhc2luZyBwd20xIHZh
bHVlLCBhbnl3YXkuCj4KPiBCdXQgdGhlIHNlbnNvcnMgdmFsdWVzIHJlYWQgd2l0aCAnaXQ4NyBm
b3JjZV9pZD0weDg3MjEnIGRvbid0IHNlZW0gb2ssIEkgZ2V0Cj4gdGhpcyAoZmlyc3QgJ2l0ODcg
Zm9yY2VfaWQ9MHg4NzIxJywgdGhlbiAnYXN1c19hdGswMTEwIG5ld19pZj0xJywgd2hpY2gKPiBz
ZWVtcyB0byBwcm92aWRlIGdvb2QgcmVhZGluZ3MpOgotLTg8LS1zbmlwLS04PC0tCj4KPiBUaGlz
IGlzIG9uIGFuIEFzdXMgTTVBNzhMLU0vVVNCMyBtYWluYm9hcmQuCgpTb3JyeSwgZm9yZ290IHRv
IGFkZCBzb2Z0d2FyZSB2ZXJzaW9uczogQXJjaCBMaW51eCB3aXRoIGxtX3NlbnNvcnMKMy4zLjEt
MiBhbmQga2VybmVsIDMuMS4wLTQtQVJDSC4KCnQnCgo+Pgo+PiBUaGFua3MsCj4+IEd1ZW50ZXIK
Pj4KPj4gU2lnbmVkLW9mZi1ieTogRnJhbmsgVC4gTG9mYXJvIEpyLiA8ZnRsb2Zhcm8gYXQgeWFo
b28uY29tPgo+PiA+IC0tLQo+PiA+IMKgZHJpdmVycy9od21vbi9pdDg3LmMgfCDCoCDCoDMgKysr
Cj4+ID4gwqAxIGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkK
Pj4gPgo+PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2h3bW9uL2l0ODcuYyBiL2RyaXZlcnMvaHdt
b24vaXQ4Ny5jCj4+ID4gaW5kZXggZDkxMjY0OS4uMGIyMWQxOCAxMDA2NDQKPj4gPiAtLS0gYS9k
cml2ZXJzL2h3bW9uL2l0ODcuYwo+PiA+ICsrKyBiL2RyaXZlcnMvaHdtb24vaXQ4Ny5jCj4+ID4g
QEAgLTE3LDYgKzE3LDcgQEAKPj4gPiDCoCAqIMKgIMKgIMKgIMKgIMKgIMKgSVQ4NzIwRiDCoFN1
cGVyIEkvTyBjaGlwIHcvTFBDIGludGVyZmFjZQo+PiA+IMKgICogwqAgwqAgwqAgwqAgwqAgwqBJ
VDg3MjFGIMKgU3VwZXIgSS9PIGNoaXAgdy9MUEMgaW50ZXJmYWNlCj4+ID4gwqAgKiDCoCDCoCDC
oCDCoCDCoCDCoElUODcyNkYgwqBTdXBlciBJL08gY2hpcCB3L0xQQyBpbnRlcmZhY2UKPj4gPiAr
ICogwqAgwqAgwqAgwqAgwqAgwqBJVDg3MjhGIMKgU3VwZXIgSS9PIGNoaXAgdy9MUEMgaW50ZXJm
YWNlCj4+ID4gwqAgKiDCoCDCoCDCoCDCoCDCoCDCoElUODc1OEUgwqBTdXBlciBJL08gY2hpcCB3
L0xQQyBpbnRlcmZhY2UKPj4gPiDCoCAqIMKgIMKgIMKgIMKgIMKgIMKgU2lzOTUwIMKgIEEgY2xv
bmUgb2YgdGhlIElUODcwNUYKPj4gPiDCoCAqCj4+ID4gQEAgLTEzNSw2ICsxMzYsNyBAQCBzdGF0
aWMgaW5saW5lIHZvaWQgc3VwZXJpb19leGl0KHZvaWQpCj4+ID4gwqAjZGVmaW5lIElUODcyMEZf
REVWSUQgMHg4NzIwCj4+ID4gwqAjZGVmaW5lIElUODcyMUZfREVWSUQgMHg4NzIxCj4+ID4gwqAj
ZGVmaW5lIElUODcyNkZfREVWSUQgMHg4NzI2Cj4+ID4gKyNkZWZpbmUgSVQ4NzI4Rl9ERVZJRCAw
eDg3MjgKPj4gPiDCoCNkZWZpbmUgSVQ4N19BQ1RfUkVHIMKgMHgzMAo+PiA+IMKgI2RlZmluZSBJ
VDg3X0JBU0VfUkVHIDB4NjAKPj4gPgo+PiA+IEBAIC0xNjAzLDYgKzE2MDUsNyBAQCBzdGF0aWMg
aW50IF9faW5pdCBpdDg3X2ZpbmQodW5zaWduZWQgc2hvcnQKPj4gPiAqYWRkcmVzcywKPj4gPiDC
oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBzaW9fZGF0YS0+dHlwZSA9IGl0ODcyMDsKPj4gPiDCoCDC
oCDCoCDCoCDCoCDCoCDCoCDCoCBicmVhazsKPj4gPiDCoCDCoCDCoCDCoCBjYXNlIElUODcyMUZf
REVWSUQ6Cj4+ID4gKyDCoCDCoCDCoCBjYXNlIElUODcyOEZfREVWSUQ6Cj4+ID4gwqAgwqAgwqAg
wqAgwqAgwqAgwqAgwqAgc2lvX2RhdGEtPnR5cGUgPSBpdDg3MjE7Cj4+ID4gwqAgwqAgwqAgwqAg
wqAgwqAgwqAgwqAgYnJlYWs7Cj4+ID4gwqAgwqAgwqAgwqAgY2FzZSAweGZmZmY6IMKgIMKgLyog
Tm8gZGV2aWNlIGF0IGFsbCAqLwo+PiA+IC0tCj4+ID4gMS43LjcuMgo+Cj4gLS0KPiA6OnF1ZXN0
aW9uID0gKGJvb2wpIF8yYnx8IV8yYjsKPgoKCgotLSAKKG5pbCkKCl9fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0Cmxt
LXNlbnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxt
YW4vbGlzdGluZm8vbG0tc2Vuc29ycw=

Re: [lm-sensors] [PATCH] Drivers: hwmon: it87: Add support for ITE

[Jean Delvare]

On Mon, 14 Nov 2011 19:14:16 -0200, Gustavo De Nardin (spuk) wrote:
> > On Fri, 2011-11-04 at 00:44 -0400, Frank T. Lofaro Jr. wrote:
> > > This patch allows the ITE 8728 chip to be detected and used.
> > > The chip appears to be compatible with the 8721.
> > > 
> > 
> > Can anyone confirm that those chips are actually compatible ?
> 
> Unlike forcing the other chips' ids, with force_id=0x8721 PWM control seems
> to work reasonably, with pwm1_enable=1, pwm1=0 yields around 1132 RPM on the
> CPU fan, and pwm1=255 yields around 3260 RPM.  Should pwm1=0 actually stop
> the fan?  I get what (empirically) seem to be consistent logarithmic
> increase in RPM when increasing pwm1 value, anyway.

If this is a 4-wire fan then your results are expected. pwm=0 always
stops 3-wire fans (no power -> stopped) but typically 4-wire fans have
a minimum speed (speed control is separate from power.)

> But the sensors values read with 'it87 force_id=0x8721' don't seem ok, I get
> this (first 'it87 force_id=0x8721', then 'asus_atk0110 new_if=1', which
> seems to provide good readings):
> 
> it8721-isa-0290
> Adapter: ISA adapter
> in0:          +0.95 V  (min =  +2.78 V, max =  +1.14 V)  ALARM
> in1:          +1.50 V  (min =  +0.00 V, max =  +3.01 V)
> in2:          +1.88 V  (min =  +2.66 V, max =  +2.27 V)  ALARM
> in3:          +2.05 V  (min =  +2.68 V, max =  +0.67 V)  ALARM
> in4:          +2.03 V  (min =  +3.04 V, max =  +1.42 V)  ALARM
> in5:          +3.05 V  (min =  +3.04 V, max =  +3.01 V)  ALARM
> in6:          +2.05 V  (min =  +2.77 V, max =  +1.87 V)  ALARM
> 3VSB:         +6.07 V  (min =  +1.10 V, max =  +4.56 V)  ALARM
> Vbat:         +3.34 V
> fan1:        3292 RPM  (min =   10 RPM)
> fan2:           0 RPM  (min =   10 RPM)  ALARM
> fan3:           0 RPM  (min =   13 RPM)  ALARM
> temp1:        +33.0°C  (low  = -65.0°C, high = -10.0°C)  sensor = thermistor
> temp2:        +40.0°C  (low  = -19.0°C, high = +127.0°C)  sensor =
> thermistor
> temp3:       -128.0°C  (low  = +119.0°C, high =  -2.0°C)  sensor = disabled
> intrusion0:  OK
> 
> atk0110-acpi-0
> Adapter: ACPI interface
> Vcore Voltage:      +0.95 V  (min =  +0.80 V, max =  +1.60 V)
> +3.3V Voltage:      +3.34 V  (min =  +2.97 V, max =  +3.63 V)
> +5V Voltage:        +5.13 V  (min =  +4.50 V, max =  +5.50 V)
> +12V Voltage:      +12.11 V  (min = +10.20 V, max = +13.80 V)
> CPU Fan Speed:     3276 RPM  (min =  600 RPM)
> Chassis Fan Speed:    0 RPM  (min =  600 RPM)
> CPU Temperature:    +33.0°C  (high = +60.0°C, crit = +95.0°C)
> MB Temperature:     +40.0°C  (high = +45.0°C, crit = +75.0°C)

This isn't necessarily bad. It is expected that you need voltage
scaling for the it87 which you don't need for the atk0110 interface.
AFAIK it is also expected that the limits aren't set as the atk0110
interface uses its own software limits (Luca can you please confirm?)

So it's really a matter of finding the right scaling factors. Easiest
way in your case if probably to extract them from the DSDT table. See
http://www.lm-sensors.org/wiki/AsusFormulaHacking for some information
on this. If you provide the DSDT to myself and Luca we should be able
to figure it out.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] Drivers: hwmon: it87: Add support for ITE

[Luca Tettamanti]

T24gTW9uLCBOb3YgMTQsIDIwMTEgYXQgMTA6NDUgUE0sIEplYW4gRGVsdmFyZSA8a2hhbGlAbGlu
dXgtZnIub3JnPiB3cm90ZToKPiBPbiBNb24sIDE0IE5vdiAyMDExIDE5OjE0OjE2IC0wMjAwLCBH
dXN0YXZvIERlIE5hcmRpbiAoc3B1aykgd3JvdGU6Cj4+ID4gT24gRnJpLCAyMDExLTExLTA0IGF0
IDAwOjQ0IC0wNDAwLCBGcmFuayBULiBMb2Zhcm8gSnIuIHdyb3RlOgo+PiA+ID4gVGhpcyBwYXRj
aCBhbGxvd3MgdGhlIElURSA4NzI4IGNoaXAgdG8gYmUgZGV0ZWN0ZWQgYW5kIHVzZWQuCj4+ID4g
PiBUaGUgY2hpcCBhcHBlYXJzIHRvIGJlIGNvbXBhdGlibGUgd2l0aCB0aGUgODcyMS4KPj4gPiA+
Cj4+ID4KPj4gPiBDYW4gYW55b25lIGNvbmZpcm0gdGhhdCB0aG9zZSBjaGlwcyBhcmUgYWN0dWFs
bHkgY29tcGF0aWJsZSA/Cj4+Cj4+IFVubGlrZSBmb3JjaW5nIHRoZSBvdGhlciBjaGlwcycgaWRz
LCB3aXRoIGZvcmNlX2lkPTB4ODcyMSBQV00gY29udHJvbCBzZWVtcwo+PiB0byB3b3JrIHJlYXNv
bmFibHksIHdpdGggcHdtMV9lbmFibGU9MSwgcHdtMT0wIHlpZWxkcyBhcm91bmQgMTEzMiBSUE0g
b24gdGhlCj4+IENQVSBmYW4sIGFuZCBwd20xPTI1NSB5aWVsZHMgYXJvdW5kIDMyNjAgUlBNLiDC
oFNob3VsZCBwd20xPTAgYWN0dWFsbHkgc3RvcAo+PiB0aGUgZmFuPyDCoEkgZ2V0IHdoYXQgKGVt
cGlyaWNhbGx5KSBzZWVtIHRvIGJlIGNvbnNpc3RlbnQgbG9nYXJpdGhtaWMKPj4gaW5jcmVhc2Ug
aW4gUlBNIHdoZW4gaW5jcmVhc2luZyBwd20xIHZhbHVlLCBhbnl3YXkuCj4KPiBJZiB0aGlzIGlz
IGEgNC13aXJlIGZhbiB0aGVuIHlvdXIgcmVzdWx0cyBhcmUgZXhwZWN0ZWQuIHB3bT0wIGFsd2F5
cwo+IHN0b3BzIDMtd2lyZSBmYW5zIChubyBwb3dlciAtPiBzdG9wcGVkKSBidXQgdHlwaWNhbGx5
IDQtd2lyZSBmYW5zIGhhdmUKPiBhIG1pbmltdW0gc3BlZWQgKHNwZWVkIGNvbnRyb2wgaXMgc2Vw
YXJhdGUgZnJvbSBwb3dlci4pCj4KPj4gQnV0IHRoZSBzZW5zb3JzIHZhbHVlcyByZWFkIHdpdGgg
J2l0ODcgZm9yY2VfaWQ9MHg4NzIxJyBkb24ndCBzZWVtIG9rLCBJIGdldAo+PiB0aGlzIChmaXJz
dCAnaXQ4NyBmb3JjZV9pZD0weDg3MjEnLCB0aGVuICdhc3VzX2F0azAxMTAgbmV3X2lmPTEnLCB3
aGljaAo+PiBzZWVtcyB0byBwcm92aWRlIGdvb2QgcmVhZGluZ3MpOgoKUGxlYXNlIHNlbmQgbWUg
dGhlIG91dHB1dCBvZiAiZG1pZGVjb2RlIC10IDIiIHNvIEkgY2FuIG92ZXJyaWRlIHRoZQpkZWZh
dWx0IGRldGVjdGlvbiBsb2dpYy4uLiB0aGlzIHdpbGwgYWxsb3cgdGhlIGRyaXZlciAoYXRrMDEx
MCkgdG8Kd29yayBvdXQgb2YgdGhlIGJveCBvbiB5b3VyIGJvYXJkLgoKPj4gYXRrMDExMC1hY3Bp
LTAKPj4gQWRhcHRlcjogQUNQSSBpbnRlcmZhY2UKPj4gVmNvcmUgVm9sdGFnZTogwqAgwqAgwqAr
MC45NSBWIMKgKG1pbiA9IMKgKzAuODAgViwgbWF4ID0gwqArMS42MCBWKQo+PiArMy4zViBWb2x0
YWdlOiDCoCDCoCDCoCszLjM0IFYgwqAobWluID0gwqArMi45NyBWLCBtYXggPSDCoCszLjYzIFYp
Cj4+ICs1ViBWb2x0YWdlOiDCoCDCoCDCoCDCoCs1LjEzIFYgwqAobWluID0gwqArNC41MCBWLCBt
YXggPSDCoCs1LjUwIFYpCj4+ICsxMlYgVm9sdGFnZTogwqAgwqAgwqArMTIuMTEgViDCoChtaW4g
PSArMTAuMjAgViwgbWF4ID0gKzEzLjgwIFYpCj4+IENQVSBGYW4gU3BlZWQ6IMKgIMKgIDMyNzYg
UlBNIMKgKG1pbiA9IMKgNjAwIFJQTSkKPj4gQ2hhc3NpcyBGYW4gU3BlZWQ6IMKgIMKgMCBSUE0g
wqAobWluID0gwqA2MDAgUlBNKQo+PiBDUFUgVGVtcGVyYXR1cmU6IMKgIMKgKzMzLjDCsEMgwqAo
aGlnaCA9ICs2MC4wwrBDLCBjcml0ID0gKzk1LjDCsEMpCj4+IE1CIFRlbXBlcmF0dXJlOiDCoCDC
oCArNDAuMMKwQyDCoChoaWdoID0gKzQ1LjDCsEMsIGNyaXQgPSArNzUuMMKwQykKPgo+IFRoaXMg
aXNuJ3QgbmVjZXNzYXJpbHkgYmFkLiBJdCBpcyBleHBlY3RlZCB0aGF0IHlvdSBuZWVkIHZvbHRh
Z2UKPiBzY2FsaW5nIGZvciB0aGUgaXQ4NyB3aGljaCB5b3UgZG9uJ3QgbmVlZCBmb3IgdGhlIGF0
azAxMTAgaW50ZXJmYWNlLgo+IEFGQUlLIGl0IGlzIGFsc28gZXhwZWN0ZWQgdGhhdCB0aGUgbGlt
aXRzIGFyZW4ndCBzZXQgYXMgdGhlIGF0azAxMTAKPiBpbnRlcmZhY2UgdXNlcyBpdHMgb3duIHNv
ZnR3YXJlIGxpbWl0cyAoTHVjYSBjYW4geW91IHBsZWFzZSBjb25maXJtPykKClNvcnQgb2YuIE9u
IG9sZGVyIG1vZGVscyB0aGUgQklPUyBkaWQgcHJvZ3JhbSB0aGUgbGltaXRzLCBteSBiZXN0Cmd1
ZXNzIGFib3V0IG5ld2VyIGJvYXJkcyBpcyB0aGF0IHRoZSBFQyBkb2VzIHNvbWUga2luZCBvZiBw
b2xsaW5nLgoKTHVjYQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX18KbG0tc2Vuc29ycyBtYWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZwpo
dHRwOi8vbGlzdHMubG0tc2Vuc29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz

Re: [lm-sensors] [PATCH] Drivers: hwmon: it87: Add support for ITE

[Gustavo De Nardin (spuk)]

* Luca Tettamanti <kronos.it@gmail.com> [2011-11-15 10:52 +0100]:
> On Mon, Nov 14, 2011 at 10:45 PM, Jean Delvare <khali@linux-fr.org> wrote:
> > On Mon, 14 Nov 2011 19:14:16 -0200, Gustavo De Nardin (spuk) wrote:
> >
> >> But the sensors values read with 'it87 force_id=0x8721' don't seem ok, I get
> >> this (first 'it87 force_id=0x8721', then 'asus_atk0110 new_if=1', which
> >> seems to provide good readings):
> 
> Please send me the output of "dmidecode -t 2" so I can override the
> default detection logic... this will allow the driver (atk0110) to
> work out of the box on your board.

Here it is:
-------8<----------8<----------
# dmidecode 2.11
SMBIOS 2.5 present.

Handle 0x0002, DMI type 2, 15 bytes
Base Board Information
        Manufacturer: ASUSTeK Computer INC.
        Product Name: M5A78L-M/USB3
        Version: Rev X.0x
        Serial Number: 110203870000896
        Asset Tag: To Be Filled By O.E.M.
        Features:
                Board is a hosting board
                Board is replaceable
        Location In Chassis: To Be Filled By O.E.M.
        Chassis Handle: 0x0003
        Type: Motherboard
        Contained Object Handles: 0
-------8<----------8<----------

Thanks.

-- 
::question = (bool) _2b||!_2b;

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] Drivers: hwmon: it87: Add support for ITE

[Gustavo De Nardin (spuk)]

* Jean Delvare <khali@linux-fr.org> [2011-11-14 22:45 +0100]:
> On Mon, 14 Nov 2011 19:14:16 -0200, Gustavo De Nardin (spuk) wrote:
> > > On Fri, 2011-11-04 at 00:44 -0400, Frank T. Lofaro Jr. wrote:
> > > > This patch allows the ITE 8728 chip to be detected and used.
> > > > The chip appears to be compatible with the 8721.
> > > > 
> > > 
> > > Can anyone confirm that those chips are actually compatible ?
> > 
> > Unlike forcing the other chips' ids, with force_id=0x8721 PWM control seems
> > to work reasonably, with pwm1_enable=1, pwm1=0 yields around 1132 RPM on the
> > CPU fan, and pwm1%5 yields around 3260 RPM.  Should pwm1=0 actually stop
> > the fan?  I get what (empirically) seem to be consistent logarithmic
> > increase in RPM when increasing pwm1 value, anyway.
> 
> If this is a 4-wire fan then your results are expected. pwm=0 always
> stops 3-wire fans (no power -> stopped) but typically 4-wire fans have
> a minimum speed (speed control is separate from power.)

Yes, this is a 4-wire fan. The chassis fan connector is 3-wire though, and I
can't seem to control the speed of a 3-wired fan by writing to pwm2.


> So it's really a matter of finding the right scaling factors. Easiest
> way in your case if probably to extract them from the DSDT table. See
> http://www.lm-sensors.org/wiki/AsusFormulaHacking for some information
> on this. If you provide the DSDT to myself and Luca we should be able
> to figure it out.

Here: http://spuk.denardin.org/Asus_M5A78L-M-v0603_DSDT.bin

No hurry from me, I'm gonna use asus_atk0110 for reading, and it87 only for
PWM control or now.

I'm trying making sense of the formula in the RVLT method. How can I use
isadump to get the raw values for checking the formula?

Thanks.

t'

-- 
::question = (bool) _2b||!_2b;

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] Drivers: hwmon: it87: Add support for ITE

[Jean Delvare]

On Tue, 15 Nov 2011 13:49:46 -0200, Gustavo De Nardin (spuk) wrote:
> * Jean Delvare <khali@linux-fr.org> [2011-11-14 22:45 +0100]:
> > On Mon, 14 Nov 2011 19:14:16 -0200, Gustavo De Nardin (spuk) wrote:
> > > Unlike forcing the other chips' ids, with force_id=0x8721 PWM control seems
> > > to work reasonably, with pwm1_enable=1, pwm1=0 yields around 1132 RPM on the
> > > CPU fan, and pwm1%5 yields around 3260 RPM.  Should pwm1=0 actually stop
> > > the fan?  I get what (empirically) seem to be consistent logarithmic
> > > increase in RPM when increasing pwm1 value, anyway.
> > 
> > If this is a 4-wire fan then your results are expected. pwm=0 always
> > stops 3-wire fans (no power -> stopped) but typically 4-wire fans have
> > a minimum speed (speed control is separate from power.)
> 
> Yes, this is a 4-wire fan. The chassis fan connector is 3-wire though, and I
> can't seem to control the speed of a 3-wired fan by writing to pwm2.

It's up to the board designer to route the PWM pins to one or more
fans. Sometimes they do, sometimes they don't. Unfortunately this is
often not documented

> > So it's really a matter of finding the right scaling factors. Easiest
> > way in your case if probably to extract them from the DSDT table. See
> > http://www.lm-sensors.org/wiki/AsusFormulaHacking for some information
> > on this. If you provide the DSDT to myself and Luca we should be able
> > to figure it out.
> 
> Here: http://spuk.denardin.org/Asus_M5A78L-M-v0603_DSDT.bin
> 
> No hurry from me, I'm gonna use asus_atk0110 for reading, and it87 only for
> PWM control or now.

Ick, no, don't do that. Actually normally you can't, the drivers won't
let you do that. it87 will refuse to load if
acpi_enforce_resources=strict and asus_atk0110 will refuse to load if
not. You did not manage to load both at the same time, did you?

> I'm trying making sense of the formula in the RVLT method. How can I use
> isadump to get the raw values for checking the formula?

First you have to find the base I/O address of the chip. sensors tells
you it's 0x290. So the dump can be obtained with:

# isadump 0x295 0x296

This is preferably done with neither it87 not asus_atk0110 module
loaded. See it87.c for voltage register definitions:

#define IT87_REG_VIN(nr)       (0x20 + (nr))

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] Drivers: hwmon: it87: Add support for ITE

[Jean Delvare]

Hi Gustavo,

On Mon, 14 Nov 2011 19:14:16 -0200, Gustavo De Nardin (spuk) wrote:
> > On Fri, 2011-11-04 at 00:44 -0400, Frank T. Lofaro Jr. wrote:
> > > This patch allows the ITE 8728 chip to be detected and used.
> > > The chip appears to be compatible with the 8721.
> > 
> > Can anyone confirm that those chips are actually compatible ?
> 
> Unlike forcing the other chips' ids, with force_id=0x8721 PWM control seems
> to work reasonably, with pwm1_enable=1, pwm1=0 yields around 1132 RPM on the
> CPU fan, and pwm1=255 yields around 3260 RPM.  Should pwm1=0 actually stop
> the fan?  I get what (empirically) seem to be consistent logarithmic
> increase in RPM when increasing pwm1 value, anyway.
> 
> But the sensors values read with 'it87 force_id=0x8721' don't seem ok, I get
> this (first 'it87 force_id=0x8721', then 'asus_atk0110 new_if=1', which
> seems to provide good readings):
> 
> it8721-isa-0290
> Adapter: ISA adapter
> in0:          +0.95 V  (min =  +2.78 V, max =  +1.14 V)  ALARM
> in1:          +1.50 V  (min =  +0.00 V, max =  +3.01 V)
> in2:          +1.88 V  (min =  +2.66 V, max =  +2.27 V)  ALARM
> in3:          +2.05 V  (min =  +2.68 V, max =  +0.67 V)  ALARM
> in4:          +2.03 V  (min =  +3.04 V, max =  +1.42 V)  ALARM
> in5:          +3.05 V  (min =  +3.04 V, max =  +3.01 V)  ALARM
> in6:          +2.05 V  (min =  +2.77 V, max =  +1.87 V)  ALARM
> 3VSB:         +6.07 V  (min =  +1.10 V, max =  +4.56 V)  ALARM
> Vbat:         +3.34 V
> fan1:        3292 RPM  (min =   10 RPM)
> fan2:           0 RPM  (min =   10 RPM)  ALARM
> fan3:           0 RPM  (min =   13 RPM)  ALARM
> temp1:        +33.0°C  (low  = -65.0°C, high = -10.0°C)  sensor = thermistor
> temp2:        +40.0°C  (low  = -19.0°C, high = +127.0°C)  sensor =
> thermistor
> temp3:       -128.0°C  (low  = +119.0°C, high =  -2.0°C)  sensor = disabled
> intrusion0:  OK
> 
> atk0110-acpi-0
> Adapter: ACPI interface
> Vcore Voltage:      +0.95 V  (min =  +0.80 V, max =  +1.60 V)
> +3.3V Voltage:      +3.34 V  (min =  +2.97 V, max =  +3.63 V)
> +5V Voltage:        +5.13 V  (min =  +4.50 V, max =  +5.50 V)
> +12V Voltage:      +12.11 V  (min = +10.20 V, max = +13.80 V)

According to the DSDT code, these are in0, in4, in3 and in2, in this
order. So we can start with:

chip "it8728-isa-0290"

   label  in0  "Vcore"
   label  in2  "+12V"
   label  in3  "+5V"
   label  in4  "+3.3V"

Then the DSDT table gives the the following scaling factors, in order:
(0+1)/1, (0x0289+0x03E8)/0x03E8, (0x0F+0x0A)/0x0A and
(0xFF+0x2F)/0x2F. This translates to:

   compute in2  @ * ( 302/  82), @ / ( 302/  47)
   compute in3  @ * (  25/  10), @ / (  25/  10)
   compute in4  @ * (1649/1000), @ / (1649/1000)

in1 could be the south bridge or memory voltage (I doubt the BIOS
prints it? If you can over- or under-clock the memory voltage, that's
one way to know.) in5 is probably unused (too close from the ADC's
limit). in6 seems to be scaled down to around 2V, so it could be -12V
or 5VSB.

   ignore in5

Then, while Vbat is reasonable, 3VSB is not. The driver applies a
scaling factor of 2 that was correct for the IT8721F, but doesn't work
for you.

> CPU Fan Speed:     3276 RPM  (min =  600 RPM)
> Chassis Fan Speed:    0 RPM  (min =  600 RPM)

Obviously the first one is fan1, and I have no reason to believe the
second isn't fan2.

   label  fan1  "CPU Fan"
   label  fan2  "Chassis Fan"

> CPU Temperature:    +33.0°C  (high = +60.0°C, crit = +95.0°C)
> MB Temperature:     +40.0°C  (high = +45.0°C, crit = +75.0°C)

Obviously these are temp1 and temp2:

   label  temp1  "CPU Temp"
   label  temp2  "M/B Temp"

So all in all this means that the IT8728F indeed appears to be
compatible with the IT8721F, except for the 3VSB scaling factor (or
3VSB is incorrect on your system.) I guess we can solve this problem
later as we gather more information from several boards. Obviously,
best would be to get a datasheet, but apparently it's not going to
happen.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors