All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Donggeun Kim <dg77.kim@samsung.com>
Cc: Paul Bolle <pebolle@tiscali.nl>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
	"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] [PATCH v7] hwmon: Add driver for EXYNOS4 TMU
Date: Thu, 17 Nov 2011 09:50:17 +0000	[thread overview]
Message-ID: <20111117095017.GA22540@ericsson.com> (raw)
In-Reply-To: <4EC4999F.8030604@samsung.com>

On Thu, Nov 17, 2011 at 12:20:31AM -0500, Donggeun Kim wrote:
[ ... ]
> >>>  
> >>> +config SENSORS_EXYNOS4_TMU
> >>> +	tristate "Temperature sensor on Samsung EXYNOS4"
> >>> +	depends on EXYNOS4_DEV_TMU
> >>
> >> It doesn't look like that Kconfig symbol is part of the tree just yet.
> >> That means people will not be able to build this driver from the
> >> mainline tree. Why is this dependency needed? In a (rather quick) scan
> >> of the code of this driver I couldn't spot anything not yet available in
> >> the tree.
> >>
> > I have to defer to the driver author for that. Maybe the dependency was
> > renamed at some point, or removed altogether.
> > 
> The dependency will be renamed to 'ARCH_EXYNOS4'.
> 
Please submit a patch.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Donggeun Kim <dg77.kim@samsung.com>
Cc: Paul Bolle <pebolle@tiscali.nl>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
	"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7] hwmon: Add driver for EXYNOS4 TMU
Date: Thu, 17 Nov 2011 01:50:17 -0800	[thread overview]
Message-ID: <20111117095017.GA22540@ericsson.com> (raw)
In-Reply-To: <4EC4999F.8030604@samsung.com>

On Thu, Nov 17, 2011 at 12:20:31AM -0500, Donggeun Kim wrote:
[ ... ]
> >>>  
> >>> +config SENSORS_EXYNOS4_TMU
> >>> +	tristate "Temperature sensor on Samsung EXYNOS4"
> >>> +	depends on EXYNOS4_DEV_TMU
> >>
> >> It doesn't look like that Kconfig symbol is part of the tree just yet.
> >> That means people will not be able to build this driver from the
> >> mainline tree. Why is this dependency needed? In a (rather quick) scan
> >> of the code of this driver I couldn't spot anything not yet available in
> >> the tree.
> >>
> > I have to defer to the driver author for that. Maybe the dependency was
> > renamed at some point, or removed altogether.
> > 
> The dependency will be renamed to 'ARCH_EXYNOS4'.
> 
Please submit a patch.

Thanks,
Guenter

  reply	other threads:[~2011-11-17  9:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-07  9:49 [lm-sensors] [PATCH v7] hwmon: Add driver for EXYNOS4 TMU Donggeun Kim
2011-09-07 16:06 ` Guenter Roeck
2011-11-15 20:34 ` Paul Bolle
2011-11-15 20:34   ` Paul Bolle
2011-11-15 21:24   ` [lm-sensors] " Guenter Roeck
2011-11-15 21:24     ` Guenter Roeck
2011-11-17  5:20     ` [lm-sensors] " Donggeun Kim
2011-11-17  5:20       ` Donggeun Kim
2011-11-17  9:50       ` Guenter Roeck [this message]
2011-11-17  9:50         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111117095017.GA22540@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=dg77.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=pebolle@tiscali.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.