From: Donggeun Kim <dg77.kim@samsung.com>
To: guenter.roeck@ericsson.com
Cc: Paul Bolle <pebolle@tiscali.nl>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] [PATCH v7] hwmon: Add driver for EXYNOS4 TMU
Date: Thu, 17 Nov 2011 05:20:31 +0000 [thread overview]
Message-ID: <4EC4999F.8030604@samsung.com> (raw)
In-Reply-To: <1321392253.2309.379.camel@groeck-laptop>
T24gMjAxMeuFhCAxMeyblCAxNuydvCAwNjoyNCwgR3VlbnRlciBSb2VjayB3cm90ZToKPiBPbiBU
dWUsIDIwMTEtMTEtMTUgYXQgMTU6MzQgLTA1MDAsIFBhdWwgQm9sbGUgd3JvdGU6Cj4+IChUaGlz
IGlzIGFuIGF0dGVtcHQgdG8gZG8gYSBiaXQgb2YgcmV2aWV3IGFmdGVyIHRoZSBmYWN0LiBTZWUs
IHRoaXMKPj4gYXBwZWFycyB0byBiZSB0byB0aGUgcGF0Y2ggdGhhdCBlbmRlZCB1cCBhcyBjb21t
aXQKPj4gOWQ5N2U1YzgxZTE1YWZhZWY2NWQwMGYwNzdmODYzYzk0Zjc1MDgzOSBpbiB0aGUgbWFp
bmxpbmUgdHJlZS4gU2luY2UKPj4gdGhhdCB0cmVlIGlzIGF0IHYzLjItcmMyIG5vdyB0aGlzIG1p
Z2h0IGJlIGluIHRpbWUgZm9yIHYzLjIuIElmIG15Cj4+IGNvbW1lbnRzIGhhdmUgbWVyaXQsIHRo
YXQgaXMuKQo+Pgo+PiBPbiBXZWQsIDIwMTEtMDktMDcgYXQgMTg6NDkgKzA5MDAsIERvbmdnZXVu
IEtpbSB3cm90ZToKPj4+IFRoaXMgcGF0Y2ggYWxsb3dzIHRvIHJlYWQgdGVtcGVyYXR1cmUKPj4+
IGZyb20gVE1VKFRoZXJtYWwgTWFuYWdlbWVudCBVbml0KSBvZiBTQU1TVU5HIEVYWU5PUzQgc2Vy
aWVzIG9mIFNvQy4KPj4gWy4uLl0KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2h3bW9uL0tjb25m
aWcgYi9kcml2ZXJzL2h3bW9uL0tjb25maWcKPj4+IGluZGV4IDBiNjJjM2MuLmM2ZmI3NjEgMTAw
NjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2h3bW9uL0tjb25maWcKPj4+ICsrKyBiL2RyaXZlcnMvaHdt
b24vS2NvbmZpZwo+Pj4gQEAgLTMwMyw2ICszMDMsMTYgQEAgY29uZmlnIFNFTlNPUlNfRFMxNjIx
Cj4+PiAgCSAgVGhpcyBkcml2ZXIgY2FuIGFsc28gYmUgYnVpbHQgYXMgYSBtb2R1bGUuICBJZiBz
bywgdGhlIG1vZHVsZQo+Pj4gIAkgIHdpbGwgYmUgY2FsbGVkIGRzMTYyMS4KPj4+ICAKPj4+ICtj
b25maWcgU0VOU09SU19FWFlOT1M0X1RNVQo+Pj4gKwl0cmlzdGF0ZSAiVGVtcGVyYXR1cmUgc2Vu
c29yIG9uIFNhbXN1bmcgRVhZTk9TNCIKPj4+ICsJZGVwZW5kcyBvbiBFWFlOT1M0X0RFVl9UTVUK
Pj4KPj4gSXQgZG9lc24ndCBsb29rIGxpa2UgdGhhdCBLY29uZmlnIHN5bWJvbCBpcyBwYXJ0IG9m
IHRoZSB0cmVlIGp1c3QgeWV0Lgo+PiBUaGF0IG1lYW5zIHBlb3BsZSB3aWxsIG5vdCBiZSBhYmxl
IHRvIGJ1aWxkIHRoaXMgZHJpdmVyIGZyb20gdGhlCj4+IG1haW5saW5lIHRyZWUuIFdoeSBpcyB0
aGlzIGRlcGVuZGVuY3kgbmVlZGVkPyBJbiBhIChyYXRoZXIgcXVpY2spIHNjYW4KPj4gb2YgdGhl
IGNvZGUgb2YgdGhpcyBkcml2ZXIgSSBjb3VsZG4ndCBzcG90IGFueXRoaW5nIG5vdCB5ZXQgYXZh
aWxhYmxlIGluCj4+IHRoZSB0cmVlLgo+Pgo+IEkgaGF2ZSB0byBkZWZlciB0byB0aGUgZHJpdmVy
IGF1dGhvciBmb3IgdGhhdC4gTWF5YmUgdGhlIGRlcGVuZGVuY3kgd2FzCj4gcmVuYW1lZCBhdCBz
b21lIHBvaW50LCBvciByZW1vdmVkIGFsdG9nZXRoZXIuCj4gClRoZSBkZXBlbmRlbmN5IHdpbGwg
YmUgcmVuYW1lZCB0byAnQVJDSF9FWFlOT1M0Jy4KClRoYW5rcywKRG9uZ2dldW4KCgoKX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbG0tc2Vuc29ycyBtYWls
aW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZwpodHRwOi8vbGlzdHMubG0tc2Vuc29y
cy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz
WARNING: multiple messages have this Message-ID (diff)
From: Donggeun Kim <dg77.kim@samsung.com>
To: guenter.roeck@ericsson.com
Cc: Paul Bolle <pebolle@tiscali.nl>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7] hwmon: Add driver for EXYNOS4 TMU
Date: Thu, 17 Nov 2011 14:20:31 +0900 [thread overview]
Message-ID: <4EC4999F.8030604@samsung.com> (raw)
In-Reply-To: <1321392253.2309.379.camel@groeck-laptop>
On 2011년 11월 16일 06:24, Guenter Roeck wrote:
> On Tue, 2011-11-15 at 15:34 -0500, Paul Bolle wrote:
>> (This is an attempt to do a bit of review after the fact. See, this
>> appears to be to the patch that ended up as commit
>> 9d97e5c81e15afaef65d00f077f863c94f750839 in the mainline tree. Since
>> that tree is at v3.2-rc2 now this might be in time for v3.2. If my
>> comments have merit, that is.)
>>
>> On Wed, 2011-09-07 at 18:49 +0900, Donggeun Kim wrote:
>>> This patch allows to read temperature
>>> from TMU(Thermal Management Unit) of SAMSUNG EXYNOS4 series of SoC.
>> [...]
>>> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
>>> index 0b62c3c..c6fb761 100644
>>> --- a/drivers/hwmon/Kconfig
>>> +++ b/drivers/hwmon/Kconfig
>>> @@ -303,6 +303,16 @@ config SENSORS_DS1621
>>> This driver can also be built as a module. If so, the module
>>> will be called ds1621.
>>>
>>> +config SENSORS_EXYNOS4_TMU
>>> + tristate "Temperature sensor on Samsung EXYNOS4"
>>> + depends on EXYNOS4_DEV_TMU
>>
>> It doesn't look like that Kconfig symbol is part of the tree just yet.
>> That means people will not be able to build this driver from the
>> mainline tree. Why is this dependency needed? In a (rather quick) scan
>> of the code of this driver I couldn't spot anything not yet available in
>> the tree.
>>
> I have to defer to the driver author for that. Maybe the dependency was
> renamed at some point, or removed altogether.
>
The dependency will be renamed to 'ARCH_EXYNOS4'.
Thanks,
Donggeun
next prev parent reply other threads:[~2011-11-17 5:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 9:49 [lm-sensors] [PATCH v7] hwmon: Add driver for EXYNOS4 TMU Donggeun Kim
2011-09-07 16:06 ` Guenter Roeck
2011-11-15 20:34 ` Paul Bolle
2011-11-15 20:34 ` Paul Bolle
2011-11-15 21:24 ` [lm-sensors] " Guenter Roeck
2011-11-15 21:24 ` Guenter Roeck
2011-11-17 5:20 ` Donggeun Kim [this message]
2011-11-17 5:20 ` Donggeun Kim
2011-11-17 9:50 ` [lm-sensors] " Guenter Roeck
2011-11-17 9:50 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC4999F.8030604@samsung.com \
--to=dg77.kim@samsung.com \
--cc=guenter.roeck@ericsson.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=myungjoo.ham@samsung.com \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.