* [Ocfs2-devel] [PATCH] ocfs2: send correct UUID to cleancache initialization
@ 2011-10-17 23:47 ` Dan Magenheimer
0 siblings, 0 replies; 4+ messages in thread
From: Dan Magenheimer @ 2011-10-17 23:47 UTC (permalink / raw)
To: ocfs2-devel; +Cc: linux-kernel, Joel Becker, Steven Whitehouse, Sunil Mushran
ocfs2: Fix cleancache initialization call to correctly pass uuid
As reported by Steven Whitehouse in https://lkml.org/lkml/2011/5/27/221
the ocfs2 volume UUID is incorrectly passed to cleancache.
As a result, shared-ephemeral tmem pools will not actually
be created; instead they will be private (unshared) which
misses out on a major benefit of tmem.
Reported-by: Steven Whitehouse <swhiteho@redhat.com>
Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
--- a/fs/ocfs2/super.c
+++ b/fs/ocfs2/super.c
@@ -2374,7 +2374,7 @@ static int ocfs2_initialize_super(struct super_block *sb,
mlog_errno(status);
goto bail;
}
- cleancache_init_shared_fs((char *)&uuid_net_key, sb);
+ cleancache_init_shared_fs((char *)&di->id2.i_super.s_uuid, sb);
bail:
return status;
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ocfs2: send correct UUID to cleancache initialization
@ 2011-10-17 23:47 ` Dan Magenheimer
0 siblings, 0 replies; 4+ messages in thread
From: Dan Magenheimer @ 2011-10-17 23:47 UTC (permalink / raw)
To: ocfs2-devel; +Cc: linux-kernel, Joel Becker, Steven Whitehouse, Sunil Mushran
ocfs2: Fix cleancache initialization call to correctly pass uuid
As reported by Steven Whitehouse in https://lkml.org/lkml/2011/5/27/221
the ocfs2 volume UUID is incorrectly passed to cleancache.
As a result, shared-ephemeral tmem pools will not actually
be created; instead they will be private (unshared) which
misses out on a major benefit of tmem.
Reported-by: Steven Whitehouse <swhiteho@redhat.com>
Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
--- a/fs/ocfs2/super.c
+++ b/fs/ocfs2/super.c
@@ -2374,7 +2374,7 @@ static int ocfs2_initialize_super(struct super_block *sb,
mlog_errno(status);
goto bail;
}
- cleancache_init_shared_fs((char *)&uuid_net_key, sb);
+ cleancache_init_shared_fs((char *)&di->id2.i_super.s_uuid, sb);
bail:
return status;
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2: send correct UUID to cleancache initialization
2011-10-17 23:47 ` Dan Magenheimer
@ 2011-11-17 9:50 ` Joel Becker
-1 siblings, 0 replies; 4+ messages in thread
From: Joel Becker @ 2011-11-17 9:50 UTC (permalink / raw)
To: Dan Magenheimer
Cc: ocfs2-devel, linux-kernel, Steven Whitehouse, Sunil Mushran
On Mon, Oct 17, 2011 at 04:47:17PM -0700, Dan Magenheimer wrote:
> ocfs2: Fix cleancache initialization call to correctly pass uuid
>
> As reported by Steven Whitehouse in https://lkml.org/lkml/2011/5/27/221
> the ocfs2 volume UUID is incorrectly passed to cleancache.
> As a result, shared-ephemeral tmem pools will not actually
> be created; instead they will be private (unshared) which
> misses out on a major benefit of tmem.
>
> Reported-by: Steven Whitehouse <swhiteho@redhat.com>
> Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>
This patch is now in the 'fixes' branch of ocfs2.git.
Joel
>
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -2374,7 +2374,7 @@ static int ocfs2_initialize_super(struct super_block *sb,
> mlog_errno(status);
> goto bail;
> }
> - cleancache_init_shared_fs((char *)&uuid_net_key, sb);
> + cleancache_init_shared_fs((char *)&di->id2.i_super.s_uuid, sb);
>
> bail:
> return status;
--
"Well-timed silence hath more eloquence than speech."
- Martin Fraquhar Tupper
http://www.jlbec.org/
jlbec at evilplan.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ocfs2: send correct UUID to cleancache initialization
@ 2011-11-17 9:50 ` Joel Becker
0 siblings, 0 replies; 4+ messages in thread
From: Joel Becker @ 2011-11-17 9:50 UTC (permalink / raw)
To: Dan Magenheimer
Cc: ocfs2-devel, linux-kernel, Steven Whitehouse, Sunil Mushran
On Mon, Oct 17, 2011 at 04:47:17PM -0700, Dan Magenheimer wrote:
> ocfs2: Fix cleancache initialization call to correctly pass uuid
>
> As reported by Steven Whitehouse in https://lkml.org/lkml/2011/5/27/221
> the ocfs2 volume UUID is incorrectly passed to cleancache.
> As a result, shared-ephemeral tmem pools will not actually
> be created; instead they will be private (unshared) which
> misses out on a major benefit of tmem.
>
> Reported-by: Steven Whitehouse <swhiteho@redhat.com>
> Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>
This patch is now in the 'fixes' branch of ocfs2.git.
Joel
>
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -2374,7 +2374,7 @@ static int ocfs2_initialize_super(struct super_block *sb,
> mlog_errno(status);
> goto bail;
> }
> - cleancache_init_shared_fs((char *)&uuid_net_key, sb);
> + cleancache_init_shared_fs((char *)&di->id2.i_super.s_uuid, sb);
>
> bail:
> return status;
--
"Well-timed silence hath more eloquence than speech."
- Martin Fraquhar Tupper
http://www.jlbec.org/
jlbec@evilplan.org
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-17 9:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-17 23:47 [Ocfs2-devel] [PATCH] ocfs2: send correct UUID to cleancache initialization Dan Magenheimer
2011-10-17 23:47 ` Dan Magenheimer
2011-11-17 9:50 ` [Ocfs2-devel] " Joel Becker
2011-11-17 9:50 ` Joel Becker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.