All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Hugh Dickins <hughd@google.com>
Cc: Cong Wang <amwang@redhat.com>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	Pekka Enberg <penberg@kernel.org>,
	Dave Hansen <dave@linux.vnet.ibm.com>,
	Lennart Poettering <lennart@poettering.net>,
	Kay Sievers <kay.sievers@vrfy.org>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Christoph Hellwig <hch@infradead.org>,
	linux-mm@kvack.org
Subject: Re: [V2 PATCH] tmpfs: add fallocate support
Date: Mon, 21 Nov 2011 05:11:55 -0500	[thread overview]
Message-ID: <20111121101155.GC17887@infradead.org> (raw)
In-Reply-To: <alpine.LSU.2.00.1111201300340.1264@sister.anvils>

On Sun, Nov 20, 2011 at 01:22:10PM -0800, Hugh Dickins wrote:
> First question that springs to mind (to which I shall easily find
> an answer): is it actually acceptable for fallocate() to return
> -ENOSPC when it has already completed a part of the work?

No, it must undo all allocations if it returns ENOSPC.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Hugh Dickins <hughd@google.com>
Cc: Cong Wang <amwang@redhat.com>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	Pekka Enberg <penberg@kernel.org>,
	Dave Hansen <dave@linux.vnet.ibm.com>,
	Lennart Poettering <lennart@poettering.net>,
	Kay Sievers <kay.sievers@vrfy.org>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Christoph Hellwig <hch@infradead.org>,
	linux-mm@kvack.org
Subject: Re: [V2 PATCH] tmpfs: add fallocate support
Date: Mon, 21 Nov 2011 05:11:55 -0500	[thread overview]
Message-ID: <20111121101155.GC17887@infradead.org> (raw)
In-Reply-To: <alpine.LSU.2.00.1111201300340.1264@sister.anvils>

On Sun, Nov 20, 2011 at 01:22:10PM -0800, Hugh Dickins wrote:
> First question that springs to mind (to which I shall easily find
> an answer): is it actually acceptable for fallocate() to return
> -ENOSPC when it has already completed a part of the work?

No, it must undo all allocations if it returns ENOSPC.


  reply	other threads:[~2011-11-21 10:12 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-18 10:39 [V2 PATCH] tmpfs: add fallocate support Cong Wang
2011-11-18 10:39 ` Cong Wang
2011-11-19 10:03 ` Christoph Hellwig
2011-11-19 10:03   ` Christoph Hellwig
2011-11-19 14:14   ` Kay Sievers
2011-11-19 14:14     ` Kay Sievers
2011-11-20 21:39     ` Hugh Dickins
2011-11-21 10:11       ` Christoph Hellwig
2011-11-21 10:11         ` Christoph Hellwig
2011-11-21 22:13         ` Hugh Dickins
2011-11-21 22:13           ` Hugh Dickins
2011-11-22  5:50         ` Cong Wang
2011-11-22  5:50           ` Cong Wang
2011-11-21 10:06     ` Christoph Hellwig
2011-11-21 10:06       ` Christoph Hellwig
2011-11-22  5:39       ` Cong Wang
2011-11-22  5:39         ` Cong Wang
2011-11-20 21:22 ` Hugh Dickins
2011-11-20 21:22   ` Hugh Dickins
2011-11-21 10:11   ` Christoph Hellwig [this message]
2011-11-21 10:11     ` Christoph Hellwig
2011-11-22  5:39   ` Cong Wang
2011-11-22  5:39     ` Cong Wang
2011-11-22 22:06 ` Andrew Morton
2011-11-22 22:06   ` Andrew Morton
2011-11-23  4:30   ` Cong Wang
2011-11-23  4:30     ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111121101155.GC17887@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=amwang@redhat.com \
    --cc=dave@linux.vnet.ibm.com \
    --cc=hughd@google.com \
    --cc=kay.sievers@vrfy.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=lennart@poettering.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.