All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	Pekka Enberg <penberg@kernel.org>,
	Hugh Dickins <hughd@google.com>,
	Dave Hansen <dave@linux.vnet.ibm.com>,
	Lennart Poettering <lennart@poettering.net>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	linux-mm@kvack.org
Subject: Re: [V2 PATCH] tmpfs: add fallocate support
Date: Tue, 22 Nov 2011 13:39:51 +0800	[thread overview]
Message-ID: <4ECB35A7.9050709@redhat.com> (raw)
In-Reply-To: <20111121100622.GA17887@infradead.org>

ao? 2011a1'11ae??21ae?JPY 18:06, Christoph Hellwig a??e??:
> On Sat, Nov 19, 2011 at 03:14:48PM +0100, Kay Sievers wrote:
>> On Sat, Nov 19, 2011 at 11:03, Christoph Hellwig<hch@infradead.org>  wrote:
>>> On Fri, Nov 18, 2011 at 06:39:50PM +0800, Cong Wang wrote:
>>>> It seems that systemd needs tmpfs to support fallocate,
>>>> see http://lkml.org/lkml/2011/10/20/275. This patch adds
>>>> fallocate support to tmpfs.
>>>
>>> What for exactly? ??Please explain why preallocating on tmpfs would
>>> make any sense.
>>
>> To be able to safely use mmap(), regarding SIGBUS, on files on the
>> /dev/shm filesystem. The glibc fallback loop for -ENOSYS on fallocate
>> is just ugly.
>
> That is the kind of information which needs to be in the changelog.
>

I will fix the changelog.

Thanks, Christoph and Kay.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Cong Wang <amwang@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	Pekka Enberg <penberg@kernel.org>,
	Hugh Dickins <hughd@google.com>,
	Dave Hansen <dave@linux.vnet.ibm.com>,
	Lennart Poettering <lennart@poettering.net>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	linux-mm@kvack.org
Subject: Re: [V2 PATCH] tmpfs: add fallocate support
Date: Tue, 22 Nov 2011 13:39:51 +0800	[thread overview]
Message-ID: <4ECB35A7.9050709@redhat.com> (raw)
In-Reply-To: <20111121100622.GA17887@infradead.org>

于 2011年11月21日 18:06, Christoph Hellwig 写道:
> On Sat, Nov 19, 2011 at 03:14:48PM +0100, Kay Sievers wrote:
>> On Sat, Nov 19, 2011 at 11:03, Christoph Hellwig<hch@infradead.org>  wrote:
>>> On Fri, Nov 18, 2011 at 06:39:50PM +0800, Cong Wang wrote:
>>>> It seems that systemd needs tmpfs to support fallocate,
>>>> see http://lkml.org/lkml/2011/10/20/275. This patch adds
>>>> fallocate support to tmpfs.
>>>
>>> What for exactly? ??Please explain why preallocating on tmpfs would
>>> make any sense.
>>
>> To be able to safely use mmap(), regarding SIGBUS, on files on the
>> /dev/shm filesystem. The glibc fallback loop for -ENOSYS on fallocate
>> is just ugly.
>
> That is the kind of information which needs to be in the changelog.
>

I will fix the changelog.

Thanks, Christoph and Kay.

  reply	other threads:[~2011-11-22  5:40 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-18 10:39 [V2 PATCH] tmpfs: add fallocate support Cong Wang
2011-11-18 10:39 ` Cong Wang
2011-11-19 10:03 ` Christoph Hellwig
2011-11-19 10:03   ` Christoph Hellwig
2011-11-19 14:14   ` Kay Sievers
2011-11-19 14:14     ` Kay Sievers
2011-11-20 21:39     ` Hugh Dickins
2011-11-21 10:11       ` Christoph Hellwig
2011-11-21 10:11         ` Christoph Hellwig
2011-11-21 22:13         ` Hugh Dickins
2011-11-21 22:13           ` Hugh Dickins
2011-11-22  5:50         ` Cong Wang
2011-11-22  5:50           ` Cong Wang
2011-11-21 10:06     ` Christoph Hellwig
2011-11-21 10:06       ` Christoph Hellwig
2011-11-22  5:39       ` Cong Wang [this message]
2011-11-22  5:39         ` Cong Wang
2011-11-20 21:22 ` Hugh Dickins
2011-11-20 21:22   ` Hugh Dickins
2011-11-21 10:11   ` Christoph Hellwig
2011-11-21 10:11     ` Christoph Hellwig
2011-11-22  5:39   ` Cong Wang
2011-11-22  5:39     ` Cong Wang
2011-11-22 22:06 ` Andrew Morton
2011-11-22 22:06   ` Andrew Morton
2011-11-23  4:30   ` Cong Wang
2011-11-23  4:30     ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ECB35A7.9050709@redhat.com \
    --to=amwang@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave@linux.vnet.ibm.com \
    --cc=hch@infradead.org \
    --cc=hughd@google.com \
    --cc=kay.sievers@vrfy.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=lennart@poettering.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.