Re: [PATCH 2/5] xen: Add privcmd device driver

[Bastian Blank <bastian@waldi.eu.org>]

On Mon, Nov 28, 2011 at 02:22:05PM -0400, Konrad Rzeszutek Wilk wrote:
> On Sun, Nov 27, 2011 at 11:07:05PM +0100, Bastian Blank wrote:
> > Access to arbitrary hypercalls is currently provided via xenfs. This
> > adds a standard character device to handle this. The support in xenfs
> Ok, what is the benefit of that? You mentioned in the prologue "about a
> year ago I started", but you didn't provide any links to the
> conversation. Could you include the details please?

<20100605162947.GA31336@wavehammer.waldi.eu.org>

> It looks like you are doing a move of the file. Can you use 'git mv'
> instead please.

I did actually. But git format-patch need an option to provide diffs of
moves.

> If it breaks compile build, you can modify the Kconfig to inhibit the
> build (say make it dependent on a symbol that won't be turned on).

No, it does not break the build.

> > +config XEN_PRIVCMD
> > +	tristate
> > +	depends on XEN_DOM0
> 
> Would it be possible for HVM domains that have the backend drivers in
> them (so blkback for example) to use these hypercalls? If so should this
> XEN_DOM0 be perhaps changed to something else?

The depends is wrong, privcmd can be used in any domain. Currently it
can be only activated through XENFS, but this should be changed.

Bastian

-- 
Love sometimes expresses itself in sacrifice.
		-- Kirk, "Metamorphosis", stardate 3220.3