Re: [PATCH 5/5] xen: Add xenbusd device driver

[Bastian Blank <bastian@waldi.eu.org>]

On Mon, Nov 28, 2011 at 02:37:23PM -0400, Konrad Rzeszutek Wilk wrote:
> On Sun, Nov 27, 2011 at 11:07:08PM +0100, Bastian Blank wrote:
> > +obj-$(CONFIG_XEN_DOM0) += xenbus_dev_backend.o
> I think this needs to depend on XEN_BACKEND ?

Right.

> > +		case IOCTL_XENBUSD_EVTCHN:
> > +			if (xen_store_evtchn > 0)
> > +				return xen_store_evtchn;
> > +			return -EINVAL;
> 
> Not -ENODEV? After all, the command arguments were OK, it is just that
> the eventchannel has not been set.

Ups.

> > +	if (!xen_initial_domain())
> 
> With the disgregated domains (and the patches that Daniel posted), I
> think this needs to relax a bit. Perhaps just make it 'xen_domain'?

Right now, xenstored needs to run where the communication ring is
located. And this ring is allocated in dom0. How would any domU run
without xenstored available?

> > +#define IOCTL_XENBUSD_EVTCHN				\
> > +	_IOC(_IOC_NONE, 'X', 0, 0)
> _IOC_READ ?

No. It does not communicate via the parameter, only the return value.

Bastian

-- 
Schshschshchsch.
		-- The Gorn, "Arena", stardate 3046.2