Re: [PATCH 1/5] xen/sys/hypervisor: Export guest_properties/is_initial_domain

[Konrad Rzeszutek Wilk <konrad@darnok.org>]

On Mon, Nov 28, 2011 at 07:38:30PM +0100, Bastian Blank wrote:
> On Mon, Nov 28, 2011 at 02:14:39PM -0400, Konrad Rzeszutek Wilk wrote:
> > On Sun, Nov 27, 2011 at 11:07:04PM +0100, Bastian Blank wrote:
> > > diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c
> > > index 1e0fe01..d0916e8 100644
> > > --- a/drivers/xen/sys-hypervisor.c
> > > +++ b/drivers/xen/sys-hypervisor.c
> > > @@ -355,6 +355,35 @@ static void xen_properties_destroy(void)
> > >  	sysfs_remove_group(hypervisor_kobj, &xen_properties_group);
> > >  }
> > >  
> > > +/* xen guest properties info */
> > 
> > Properties is plural, but this is a single attribute.
> 
> Just like the old /proc/xen/capabilites, it only supported one attribute
> ever. However it could export a flag for hvm domain.
> 
> >                      Perhaps the name 'is_initial_domain' would be a
> > better name?
> 
> It is already called this was.

Ah yes. Somehow I was thinking it was guest_properties.
> 
> >              What is the purpose of this attribute?
> 
> Replace /proc/xen/capabilities. See
> <20100605162947.GA31336@wavehammer.waldi.eu.org>
> 
> >                                                     Who/what tools
> > benefit from this?
> 
> The init scripts are the only users.
> 
> Bastian
> 
> -- 
> Deflector shields just came on, Captain.