From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [Bridge] [PATCH] bridge: master device stuck in no-carrier state forever when in user-stp mode
Date: Tue, 29 Nov 2011 16:06:56 -0800 [thread overview]
Message-ID: <20111129160656.7a96375e@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20111129.185433.1527626185550800872.davem@davemloft.net>
On Tue, 29 Nov 2011 18:54:33 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
> From: Vitalii Demianets <vitas@nppfactor.kiev.ua>
> Date: Fri, 25 Nov 2011 12:16:37 +0200
>
> > When in user-stp mode, bridge master do not follow state of its slaves, so
> > after the following sequence of events it can stuck forever in no-carrier
> > state:
> > 1) turn stp off
> > 2) put all slaves down - master device will follow their state and also go in
> > no-carrier state
> > 3) turn stp on with bridge-stp script returning 0 (go to the user-stp mode)
> > Now bridge master won't follow slaves' state and will never reach running
> > state.
> >
> > This patch solves the problem by making user-stp and kernel-stp behavior
> > similar regarding master following slaves' states.
> >
> > Signed-off-by: Vitalii Demianets <vitas@nppfactor.kiev.ua>
>
> Stephen, please review this patch, thanks.
Agree that it is a problem, but want to fix the code up. The logic
can be done slightly cleaner.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH] bridge: master device stuck in no-carrier state forever when in user-stp mode
Date: Tue, 29 Nov 2011 16:06:56 -0800 [thread overview]
Message-ID: <20111129160656.7a96375e@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20111129.185433.1527626185550800872.davem@davemloft.net>
On Tue, 29 Nov 2011 18:54:33 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
> From: Vitalii Demianets <vitas@nppfactor.kiev.ua>
> Date: Fri, 25 Nov 2011 12:16:37 +0200
>
> > When in user-stp mode, bridge master do not follow state of its slaves, so
> > after the following sequence of events it can stuck forever in no-carrier
> > state:
> > 1) turn stp off
> > 2) put all slaves down - master device will follow their state and also go in
> > no-carrier state
> > 3) turn stp on with bridge-stp script returning 0 (go to the user-stp mode)
> > Now bridge master won't follow slaves' state and will never reach running
> > state.
> >
> > This patch solves the problem by making user-stp and kernel-stp behavior
> > similar regarding master following slaves' states.
> >
> > Signed-off-by: Vitalii Demianets <vitas@nppfactor.kiev.ua>
>
> Stephen, please review this patch, thanks.
Agree that it is a problem, but want to fix the code up. The logic
can be done slightly cleaner.
next prev parent reply other threads:[~2011-11-30 0:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 10:16 [Bridge] [PATCH] bridge: master device stuck in no-carrier state forever when in user-stp mode Vitalii Demianets
2011-11-25 10:16 ` Vitalii Demianets
2011-11-29 23:54 ` [Bridge] " David Miller
2011-11-29 23:54 ` David Miller
2011-11-30 0:06 ` Stephen Hemminger [this message]
2011-11-30 0:06 ` Stephen Hemminger
2011-12-01 18:44 ` [Bridge] " Stephen Hemminger
2011-12-01 18:44 ` Stephen Hemminger
2011-12-01 19:05 ` [Bridge] " David Miller
2011-12-01 19:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111129160656.7a96375e@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.