From: Wei Wang2 <wei.wang2@amd.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] AMD IOMMU v2: minor cleanup
Date: Fri, 2 Dec 2011 14:15:33 +0100 [thread overview]
Message-ID: <201112021415.34215.wei.wang2@amd.com> (raw)
In-Reply-To: <16f5f59b-7d8e-4e8f-a178-be3f2ccf338a@sausexedgep01.amd.com>
On Thursday 01 December 2011 12:56:36 Jan Beulich wrote:
> Despite this array living in an __init function, having such be an
> automatic variable is rather inefficient in terms of generated code.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/drivers/passthrough/amd/iommu_detect.c
> +++ b/xen/drivers/passthrough/amd/iommu_detect.c
> @@ -66,7 +66,7 @@ void __init get_iommu_features(struct am
> {
> u32 low, high;
> int i = 0 ;
> - char * feature_str[] = {
> + static const char *__initdata feature_str[] = {
> "- Prefetch Pages Command",
> "- Peripheral Page Service Request",
> "- X2APIC Supported",
Acked, thanks,
Wei
next parent reply other threads:[~2011-12-02 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <16f5f59b-7d8e-4e8f-a178-be3f2ccf338a@sausexedgep01.amd.com>
2011-12-02 13:15 ` Wei Wang2 [this message]
2011-12-01 11:56 [PATCH] AMD IOMMU v2: minor cleanup Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112021415.34215.wei.wang2@amd.com \
--to=wei.wang2@amd.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.