* [PATCH] AMD IOMMU v2: minor cleanup
@ 2011-12-01 11:56 Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: Jan Beulich @ 2011-12-01 11:56 UTC (permalink / raw)
To: xen-devel@lists.xensource.com; +Cc: Wei Wang2
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
Despite this array living in an __init function, having such be an
automatic variable is rather inefficient in terms of generated code.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/drivers/passthrough/amd/iommu_detect.c
+++ b/xen/drivers/passthrough/amd/iommu_detect.c
@@ -66,7 +66,7 @@ void __init get_iommu_features(struct am
{
u32 low, high;
int i = 0 ;
- char * feature_str[] = {
+ static const char *__initdata feature_str[] = {
"- Prefetch Pages Command",
"- Peripheral Page Service Request",
"- X2APIC Supported",
[-- Attachment #2: amd-iommu-v2-cleanup.patch --]
[-- Type: text/plain, Size: 629 bytes --]
AMD IOMMU v2: minor cleanup
Despite this array living in an __init function, having such be an
automatic variable is rather inefficient in terms of generated code.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/drivers/passthrough/amd/iommu_detect.c
+++ b/xen/drivers/passthrough/amd/iommu_detect.c
@@ -66,7 +66,7 @@ void __init get_iommu_features(struct am
{
u32 low, high;
int i = 0 ;
- char * feature_str[] = {
+ static const char *__initdata feature_str[] = {
"- Prefetch Pages Command",
"- Peripheral Page Service Request",
"- X2APIC Supported",
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] AMD IOMMU v2: minor cleanup
[not found] <16f5f59b-7d8e-4e8f-a178-be3f2ccf338a@sausexedgep01.amd.com>
@ 2011-12-02 13:15 ` Wei Wang2
0 siblings, 0 replies; 2+ messages in thread
From: Wei Wang2 @ 2011-12-02 13:15 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel@lists.xensource.com
On Thursday 01 December 2011 12:56:36 Jan Beulich wrote:
> Despite this array living in an __init function, having such be an
> automatic variable is rather inefficient in terms of generated code.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/drivers/passthrough/amd/iommu_detect.c
> +++ b/xen/drivers/passthrough/amd/iommu_detect.c
> @@ -66,7 +66,7 @@ void __init get_iommu_features(struct am
> {
> u32 low, high;
> int i = 0 ;
> - char * feature_str[] = {
> + static const char *__initdata feature_str[] = {
> "- Prefetch Pages Command",
> "- Peripheral Page Service Request",
> "- X2APIC Supported",
Acked, thanks,
Wei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-02 13:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <16f5f59b-7d8e-4e8f-a178-be3f2ccf338a@sausexedgep01.amd.com>
2011-12-02 13:15 ` [PATCH] AMD IOMMU v2: minor cleanup Wei Wang2
2011-12-01 11:56 Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.