All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Sam Ravnborg <sam.ravnborg@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH-RFC v2 10/10] sparc: switch to GENERIC_PCI_IOMAP
Date: Sun, 04 Dec 2011 14:34:49 +0000	[thread overview]
Message-ID: <20111204143448.GA21535@redhat.com> (raw)
In-Reply-To: <63292221aef2eb299e7dba860b3ee38c2ed05eb8.1322163031.git.mst@redhat.com>

sparc copied pci_iomap from generic code, probably to avoid
pulling the rest of iomap.c in.  Since that's in
a separate file now, we can reuse the common implementation.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---

Changes from v1:
	remove ifdef __KERNEL__ from files
	not exported to userspace.

 arch/sparc/Kconfig             |    1 +
 arch/sparc/include/asm/io_32.h |    2 +-
 arch/sparc/include/asm/io_64.h |    2 +-
 arch/sparc/lib/iomap.c         |   23 -----------------------
 4 files changed, 3 insertions(+), 25 deletions(-)

diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index f92602e..a4644f5 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -28,6 +28,7 @@ config SPARC
 	select HAVE_GENERIC_HARDIRQS
 	select GENERIC_IRQ_SHOW
 	select USE_GENERIC_SMP_HELPERS if SMP
+	select GENERIC_PCI_IOMAP
 
 config SPARC32
 	def_bool !64BIT
diff --git a/arch/sparc/include/asm/io_32.h b/arch/sparc/include/asm/io_32.h
index c2ced21..2006e5d 100644
--- a/arch/sparc/include/asm/io_32.h
+++ b/arch/sparc/include/asm/io_32.h
@@ -7,6 +7,7 @@
 
 #include <asm/page.h>      /* IO address mapping routines need this */
 #include <asm/system.h>
+#include <asm-generic/pci_iomap.h>
 
 #define page_to_phys(page)	(page_to_pfn(page) << PAGE_SHIFT)
 
@@ -324,7 +325,6 @@ extern void ioport_unmap(void __iomem *);
 
 /* Create a virtual mapping cookie for a PCI BAR (memory or IO) */
 struct pci_dev;
-extern void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long max);
 extern void pci_iounmap(struct pci_dev *dev, void __iomem *);
 
 /*
diff --git a/arch/sparc/include/asm/io_64.h b/arch/sparc/include/asm/io_64.h
index 9c89654..9481e5a 100644
--- a/arch/sparc/include/asm/io_64.h
+++ b/arch/sparc/include/asm/io_64.h
@@ -8,6 +8,7 @@
 #include <asm/page.h>      /* IO address mapping routines need this */
 #include <asm/system.h>
 #include <asm/asi.h>
+#include <asm-generic/pci_iomap.h>
 
 /* PC crapola... */
 #define __SLOW_DOWN_IO	do { } while (0)
@@ -514,7 +515,6 @@ extern void ioport_unmap(void __iomem *);
 
 /* Create a virtual mapping cookie for a PCI BAR (memory or IO) */
 struct pci_dev;
-extern void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long max);
 extern void pci_iounmap(struct pci_dev *dev, void __iomem *);
 
 static inline int sbus_can_dma_64bit(void)
diff --git a/arch/sparc/lib/iomap.c b/arch/sparc/lib/iomap.c
index 9ef37e1..c4d42a5 100644
--- a/arch/sparc/lib/iomap.c
+++ b/arch/sparc/lib/iomap.c
@@ -18,31 +18,8 @@ void ioport_unmap(void __iomem *addr)
 EXPORT_SYMBOL(ioport_map);
 EXPORT_SYMBOL(ioport_unmap);
 
-/* Create a virtual mapping cookie for a PCI BAR (memory or IO) */
-void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long maxlen)
-{
-	resource_size_t start = pci_resource_start(dev, bar);
-	resource_size_t len = pci_resource_len(dev, bar);
-	unsigned long flags = pci_resource_flags(dev, bar);
-
-	if (!len || !start)
-		return NULL;
-	if (maxlen && len > maxlen)
-		len = maxlen;
-	if (flags & IORESOURCE_IO)
-		return ioport_map(start, len);
-	if (flags & IORESOURCE_MEM) {
-		if (flags & IORESOURCE_CACHEABLE)
-			return ioremap(start, len);
-		return ioremap_nocache(start, len);
-	}
-	/* What? */
-	return NULL;
-}
-
 void pci_iounmap(struct pci_dev *dev, void __iomem * addr)
 {
 	/* nothing to do */
 }
-EXPORT_SYMBOL(pci_iomap);
 EXPORT_SYMBOL(pci_iounmap);
-- 
1.7.5.53.gc233e

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Sam Ravnborg <sam.ravnborg@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH-RFC v2 10/10] sparc: switch to GENERIC_PCI_IOMAP
Date: Sun, 4 Dec 2011 16:34:49 +0200	[thread overview]
Message-ID: <20111204143448.GA21535@redhat.com> (raw)
In-Reply-To: <63292221aef2eb299e7dba860b3ee38c2ed05eb8.1322163031.git.mst@redhat.com>

sparc copied pci_iomap from generic code, probably to avoid
pulling the rest of iomap.c in.  Since that's in
a separate file now, we can reuse the common implementation.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---

Changes from v1:
	remove ifdef __KERNEL__ from files
	not exported to userspace.

 arch/sparc/Kconfig             |    1 +
 arch/sparc/include/asm/io_32.h |    2 +-
 arch/sparc/include/asm/io_64.h |    2 +-
 arch/sparc/lib/iomap.c         |   23 -----------------------
 4 files changed, 3 insertions(+), 25 deletions(-)

diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index f92602e..a4644f5 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -28,6 +28,7 @@ config SPARC
 	select HAVE_GENERIC_HARDIRQS
 	select GENERIC_IRQ_SHOW
 	select USE_GENERIC_SMP_HELPERS if SMP
+	select GENERIC_PCI_IOMAP
 
 config SPARC32
 	def_bool !64BIT
diff --git a/arch/sparc/include/asm/io_32.h b/arch/sparc/include/asm/io_32.h
index c2ced21..2006e5d 100644
--- a/arch/sparc/include/asm/io_32.h
+++ b/arch/sparc/include/asm/io_32.h
@@ -7,6 +7,7 @@
 
 #include <asm/page.h>      /* IO address mapping routines need this */
 #include <asm/system.h>
+#include <asm-generic/pci_iomap.h>
 
 #define page_to_phys(page)	(page_to_pfn(page) << PAGE_SHIFT)
 
@@ -324,7 +325,6 @@ extern void ioport_unmap(void __iomem *);
 
 /* Create a virtual mapping cookie for a PCI BAR (memory or IO) */
 struct pci_dev;
-extern void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long max);
 extern void pci_iounmap(struct pci_dev *dev, void __iomem *);
 
 /*
diff --git a/arch/sparc/include/asm/io_64.h b/arch/sparc/include/asm/io_64.h
index 9c89654..9481e5a 100644
--- a/arch/sparc/include/asm/io_64.h
+++ b/arch/sparc/include/asm/io_64.h
@@ -8,6 +8,7 @@
 #include <asm/page.h>      /* IO address mapping routines need this */
 #include <asm/system.h>
 #include <asm/asi.h>
+#include <asm-generic/pci_iomap.h>
 
 /* PC crapola... */
 #define __SLOW_DOWN_IO	do { } while (0)
@@ -514,7 +515,6 @@ extern void ioport_unmap(void __iomem *);
 
 /* Create a virtual mapping cookie for a PCI BAR (memory or IO) */
 struct pci_dev;
-extern void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long max);
 extern void pci_iounmap(struct pci_dev *dev, void __iomem *);
 
 static inline int sbus_can_dma_64bit(void)
diff --git a/arch/sparc/lib/iomap.c b/arch/sparc/lib/iomap.c
index 9ef37e1..c4d42a5 100644
--- a/arch/sparc/lib/iomap.c
+++ b/arch/sparc/lib/iomap.c
@@ -18,31 +18,8 @@ void ioport_unmap(void __iomem *addr)
 EXPORT_SYMBOL(ioport_map);
 EXPORT_SYMBOL(ioport_unmap);
 
-/* Create a virtual mapping cookie for a PCI BAR (memory or IO) */
-void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long maxlen)
-{
-	resource_size_t start = pci_resource_start(dev, bar);
-	resource_size_t len = pci_resource_len(dev, bar);
-	unsigned long flags = pci_resource_flags(dev, bar);
-
-	if (!len || !start)
-		return NULL;
-	if (maxlen && len > maxlen)
-		len = maxlen;
-	if (flags & IORESOURCE_IO)
-		return ioport_map(start, len);
-	if (flags & IORESOURCE_MEM) {
-		if (flags & IORESOURCE_CACHEABLE)
-			return ioremap(start, len);
-		return ioremap_nocache(start, len);
-	}
-	/* What? */
-	return NULL;
-}
-
 void pci_iounmap(struct pci_dev *dev, void __iomem * addr)
 {
 	/* nothing to do */
 }
-EXPORT_SYMBOL(pci_iomap);
 EXPORT_SYMBOL(pci_iounmap);
-- 
1.7.5.53.gc233e

  reply	other threads:[~2011-12-04 14:34 UTC|newest]

Thread overview: 113+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1322163031.git.mst@redhat.com>
2011-11-24 20:15 ` [PATCH-RFC 01/10] lib: move GENERIC_IOMAP to lib/Kconfig Michael S. Tsirkin
2011-11-24 20:15   ` Michael S. Tsirkin
2011-11-24 20:15   ` Michael S. Tsirkin
2011-11-24 20:15   ` Michael S. Tsirkin
2011-11-24 20:15   ` Michael S. Tsirkin
2011-11-24 20:15   ` Michael S. Tsirkin
2011-11-25  8:41   ` Jesper Nilsson
2011-11-25  8:41     ` Jesper Nilsson
2011-11-25  8:41     ` Jesper Nilsson
2011-11-28 20:12   ` Richard Kuo
2011-11-28 20:12     ` Richard Kuo
2011-11-28 20:12     ` Richard Kuo
2011-11-28 20:12     ` Richard Kuo
2011-11-24 20:17 ` [PATCH-RFC 02/10] lib: add GENERIC_PCI_IOMAP Michael S. Tsirkin
2011-11-24 20:17   ` Michael S. Tsirkin
2011-11-24 20:17   ` Michael S. Tsirkin
2011-11-24 20:17   ` Michael S. Tsirkin
2011-11-24 20:17   ` Michael S. Tsirkin
2011-11-24 20:17   ` Michael S. Tsirkin
2011-11-24 22:07   ` Arnd Bergmann
2011-11-24 22:07     ` Arnd Bergmann
2011-11-24 22:07     ` Arnd Bergmann
2011-11-24 22:07     ` Arnd Bergmann
2011-11-25  0:54   ` Stephen Rothwell
2011-11-25  0:54     ` Stephen Rothwell
2011-11-25  0:54     ` Stephen Rothwell
2011-11-25  0:59     ` Stephen Rothwell
2011-11-25  0:59       ` Stephen Rothwell
2011-11-25  0:59       ` Stephen Rothwell
2011-11-27 17:12     ` Michael S. Tsirkin
2011-11-27 17:12       ` Michael S. Tsirkin
2011-11-27 17:12       ` Michael S. Tsirkin
2011-11-27 17:12       ` Michael S. Tsirkin
2011-11-28 19:21   ` [PATCH-RFC 02/10 v2] " Michael S. Tsirkin
2011-11-24 20:17 ` [PATCH-RFC 03/10] alpha: switch to GENERIC_PCI_IOMAP Michael S. Tsirkin
2011-11-24 20:17   ` Michael S. Tsirkin
2011-11-24 20:17   ` Michael S. Tsirkin
2011-11-24 20:17   ` Michael S. Tsirkin
2011-11-24 20:17   ` Michael S. Tsirkin
2011-11-24 20:17   ` Michael S. Tsirkin
2011-12-04 10:50   ` Michael S. Tsirkin
2011-12-06 16:45   ` Raúl Porcel
2011-11-24 20:17 ` [PATCH-RFC 04/10] arm: " Michael S. Tsirkin
2011-11-24 20:17   ` Michael S. Tsirkin
2011-11-24 20:17   ` Michael S. Tsirkin
2011-11-24 20:17   ` Michael S. Tsirkin
2011-11-24 20:17   ` Michael S. Tsirkin
2011-11-24 20:17   ` Michael S. Tsirkin
2011-12-04 10:47   ` Michael S. Tsirkin
2011-12-04 21:25     ` Russell King - ARM Linux
2011-11-24 20:18 ` [PATCH-RFC 05/10] microblaze: " Michael S. Tsirkin
2011-11-24 20:18   ` Michael S. Tsirkin
2011-11-24 20:18   ` Michael S. Tsirkin
2011-11-24 20:18   ` Michael S. Tsirkin
2011-11-24 20:18   ` Michael S. Tsirkin
2011-11-24 20:18   ` Michael S. Tsirkin
2011-11-24 20:18 ` [PATCH-RFC 06/10] mips: " Michael S. Tsirkin
2011-11-24 20:18   ` Michael S. Tsirkin
2011-11-24 20:18   ` Michael S. Tsirkin
2011-11-24 20:18   ` Michael S. Tsirkin
2011-11-24 20:18   ` Michael S. Tsirkin
2011-11-24 20:18   ` Michael S. Tsirkin
2011-12-04 10:47   ` Michael S. Tsirkin
2012-01-28 22:38   ` Kevin Cernekee
2012-01-28 22:38     ` Kevin Cernekee
2012-01-28 22:38     ` Kevin Cernekee
2012-01-28 22:38     ` Kevin Cernekee
2012-01-29 22:45     ` Michael S. Tsirkin
2012-01-29 22:45       ` Michael S. Tsirkin
2012-01-29 22:45       ` Michael S. Tsirkin
2012-01-29 22:45       ` Michael S. Tsirkin
2011-11-24 20:19 ` [PATCH-RFC 07/10] parisc: " Michael S. Tsirkin
2011-11-24 20:19   ` Michael S. Tsirkin
2011-11-24 20:19   ` Michael S. Tsirkin
2011-11-24 20:19   ` Michael S. Tsirkin
2011-11-24 20:19   ` Michael S. Tsirkin
2011-11-24 20:19   ` Michael S. Tsirkin
2011-12-04 10:48   ` Michael S. Tsirkin
2011-12-04 14:22     ` James Bottomley
2011-12-04 14:30       ` Michael S. Tsirkin
2011-12-04 14:32         ` James Bottomley
2011-12-04 14:42           ` Michael S. Tsirkin
2011-12-05 15:33             ` James Bottomley
2011-12-05 16:24               ` Michael S. Tsirkin
2011-12-05 16:46                 ` James Bottomley
2011-12-05 18:23         ` Grant Grundler
2011-12-06 11:06           ` Michael S. Tsirkin
2011-12-06 16:18             ` Grant Grundler
2011-12-06 16:24               ` Michael S. Tsirkin
2011-12-16  2:11                 ` Grant Grundler
2011-11-24 20:19 ` [PATCH-RFC 08/10] powerpc: " Michael S. Tsirkin
2011-11-24 20:19   ` Michael S. Tsirkin
2011-11-24 20:19   ` Michael S. Tsirkin
2011-11-24 20:19   ` Michael S. Tsirkin
2011-11-24 20:19   ` Michael S. Tsirkin
2011-11-24 20:19   ` Michael S. Tsirkin
2011-12-04 10:48   ` Michael S. Tsirkin
2011-12-04 20:52     ` Benjamin Herrenschmidt
2011-12-05  6:03       ` Michael S. Tsirkin
2011-11-24 20:20 ` [PATCH-RFC 09/10] sh: " Michael S. Tsirkin
2011-11-24 20:20   ` Michael S. Tsirkin
2011-11-24 20:20   ` Michael S. Tsirkin
2011-11-24 20:20   ` Michael S. Tsirkin
2011-11-24 20:20   ` Michael S. Tsirkin
2011-11-24 20:20   ` Michael S. Tsirkin
2011-11-24 20:21 ` [PATCH-RFC 10/10] sparc: " Michael S. Tsirkin
2011-11-24 20:21   ` Michael S. Tsirkin
2011-11-24 20:21   ` Michael S. Tsirkin
2011-11-24 20:21   ` Michael S. Tsirkin
2011-11-24 20:21   ` Michael S. Tsirkin
2011-11-24 20:21   ` Michael S. Tsirkin
2011-12-04 14:34   ` Michael S. Tsirkin [this message]
2011-12-04 14:34     ` [PATCH-RFC v2 " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111204143448.GA21535@redhat.com \
    --to=mst@redhat.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam.ravnborg@gmail.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.