From: "Michael S. Tsirkin" <mst@redhat.com>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
linux-mips@linux-mips.org, linux-m68k@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux@openrisc.net, linux-pci@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Kumar Gala <galak@kernel.crashing.org>,
Chen Liqin <liqin.chen@sunplusct.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, Guan Xuetao <gxt@mprc.pku.edu.cn>,
Lennox Wu <lennox.wu@gmail.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Russell King <linux@arm.linux.org.uk>,
linux-hexagon@vger.kernel.org, Helge Deller <deller@gmx.de>,
x86@kernel.org, "James E.J. Bottomley" <jejb@parisc-linux.org>,
Ingo Molnar <mingo@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-arch@vger.kernel.org, Arend van Spriel <arend@broadcom.com>
Subject: Re: [PATCH-RFC 06/10] mips: switch to GENERIC_PCI_IOMAP
Date: Mon, 30 Jan 2012 00:45:07 +0200 [thread overview]
Message-ID: <20120129223339.GA22666@redhat.com> (raw)
In-Reply-To: <CAJiQ=7BPzhWWzU3_nDv3j=ZB4f=iOzeyLyd2L0_3UFaMiLujpw@mail.gmail.com>
On Sat, Jan 28, 2012 at 02:38:10PM -0800, Kevin Cernekee wrote:
> On Thu, Nov 24, 2011 at 12:18 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > mips copied pci_iomap from generic code, probably to avoid
> > pulling the rest of iomap.c in. Since that's in
> > a separate file now, we can reuse the common implementation.
>
> [snip]
>
> > - if (flags & IORESOURCE_IO)
> > - return ioport_map_pci(dev, start, len);
>
> While investigating a new warning on the 3.3-rc1 MIPS build (unused
> static function ioport_map_pci()), I noticed that this patch has shown
> up in Linus' tree as commit eab90291d35438bcebf7c3dc85be66d0f24e3002.
>
> I am not completely clear on the implications it has on mapping PCI I/O regions:
Yes, my bad, I missed the difference between ioport_map_pci
and ioport_map for both MIPS and SH.
I'll post a patch to fix this, which is probably preferable
to reintroducing the code duplication where it might
trip us up again.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Mikael Starvik <starvik@axis.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Richard Kuo <rkuo@codeaurora.org>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Michal Simek <monstr@monstr.eu>, Jonas Bonn <jonas@southpole.se>,
Kyle McMartin <kyle@mcmartin.ca>, Helge Deller <deller@gmx.de>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Chen Liqin <liqin.chen@sunplusct.com>,
Lennox Wu <lennox.wu@gmail.com>, Paul Mundt <lethal@linux-sh.org>,
"David S. Miller" <davem@davemloft.net>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Paul Bolle <pebolle@tiscali.nl>, Olof Johansson <olof@lixom.net>,
Rob Herring <rob.herring@calxeda.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Kumar Gala <galak@kernel.crashing.org>,
Michael Ellerman <michael@ellerman.id.au>,
Fabio Baltieri <fabio.baltieri@gmail.com>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
"John W. Linville" <linville@tuxdriver.com>,
Lasse Collin <lasse.collin@tukaani.org>,
Arend van Spriel <arend@broadcom.com>,
Franky Lin <frankyl@broadcom.com>,
linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-cris-kernel@axis.com,
linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-m68k@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au,
linux-mips@linux-mips.org, linux@openrisc.net,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH-RFC 06/10] mips: switch to GENERIC_PCI_IOMAP
Date: Mon, 30 Jan 2012 00:45:07 +0200 [thread overview]
Message-ID: <20120129223339.GA22666@redhat.com> (raw)
In-Reply-To: <CAJiQ=7BPzhWWzU3_nDv3j=ZB4f=iOzeyLyd2L0_3UFaMiLujpw@mail.gmail.com>
On Sat, Jan 28, 2012 at 02:38:10PM -0800, Kevin Cernekee wrote:
> On Thu, Nov 24, 2011 at 12:18 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > mips copied pci_iomap from generic code, probably to avoid
> > pulling the rest of iomap.c in. Since that's in
> > a separate file now, we can reuse the common implementation.
>
> [snip]
>
> > - if (flags & IORESOURCE_IO)
> > - return ioport_map_pci(dev, start, len);
>
> While investigating a new warning on the 3.3-rc1 MIPS build (unused
> static function ioport_map_pci()), I noticed that this patch has shown
> up in Linus' tree as commit eab90291d35438bcebf7c3dc85be66d0f24e3002.
>
> I am not completely clear on the implications it has on mapping PCI I/O regions:
Yes, my bad, I missed the difference between ioport_map_pci
and ioport_map for both MIPS and SH.
I'll post a patch to fix this, which is probably preferable
to reintroducing the code duplication where it might
trip us up again.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
linux-mips@linux-mips.org, linux-m68k@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux@openrisc.net, linux-pci@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Kumar Gala <galak@kernel.crashing.org>,
Chen Liqin <liqin.chen@sunplusct.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, Guan Xuetao <gxt@mprc.pku.edu.cn>,
Lennox Wu <lennox.wu@gmail.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Russell King <linux@arm.linux.org.uk>,
linux-hexagon@vger.kernel.org, Helge Deller <deller@gmx.de>,
x86@kernel.org, "James E.J. Bottomley" <jejb@parisc-linux.org>,
Ingo Molnar <mingo@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-arch@vger.kernel.org, Arend van Spriel <arend@broadcom.com>,
Subject: Re: [PATCH-RFC 06/10] mips: switch to GENERIC_PCI_IOMAP
Date: Mon, 30 Jan 2012 00:45:07 +0200 [thread overview]
Message-ID: <20120129223339.GA22666@redhat.com> (raw)
In-Reply-To: <CAJiQ=7BPzhWWzU3_nDv3j=ZB4f=iOzeyLyd2L0_3UFaMiLujpw@mail.gmail.com>
On Sat, Jan 28, 2012 at 02:38:10PM -0800, Kevin Cernekee wrote:
> On Thu, Nov 24, 2011 at 12:18 PM, Michael S. Tsirkin <mst@redhat.com> wro=
te:
> > mips copied pci_iomap from generic code, probably to avoid
> > pulling the rest of iomap.c in. =A0Since that's in
> > a separate file now, we can reuse the common implementation.
> =
> [snip]
> =
> > - =A0 =A0 =A0 if (flags & IORESOURCE_IO)
> > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 return ioport_map_pci(dev, start, len);
> =
> While investigating a new warning on the 3.3-rc1 MIPS build (unused
> static function ioport_map_pci()), I noticed that this patch has shown
> up in Linus' tree as commit eab90291d35438bcebf7c3dc85be66d0f24e3002.
> =
> I am not completely clear on the implications it has on mapping PCI I/O r=
egions:
Yes, my bad, I missed the difference between ioport_map_pci
and ioport_map for both MIPS and SH.
I'll post a patch to fix this, which is probably preferable
to reintroducing the code duplication where it might
trip us up again.
-- =
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
linux-mips@linux-mips.org, linux-m68k@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
linux@openrisc.net, linux-pci@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Chen Liqin <liqin.chen@sunplusct.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, Guan Xuetao <gxt@mprc.pku.edu.cn>,
Lennox Wu <lennox.wu@gmail.com>, Jonas Bonn <jonas@southpole.se>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Russell King <linux@arm.linux.org.uk>,
linux-hexagon@vger.kernel.org, Helge Deller <deller@gmx.de>,
x86@kernel.org, "James E.J. Bottomley" <jejb@parisc-linux.org>,
Ingo Molnar <mingo@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-arch@vger.kernel.org, Arend van Spriel <arend@broadcom.com>,
Matt Turner <mattst88@gmail.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Lasse Collin <lasse.collin@tukaani.org>,
Arnd Bergmann <arnd@arndb.de>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
microblaze-uclinux@itee.uq.edu.au,
Paul Bolle <pebolle@tiscali.nl>,
Rob Herring <rob.herring@calxeda.com>,
Mikael Starvik <starvik@axis.com>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Franky Lin <frankyl@broadcom.com>,
Thomas Gleixner <tglx@linutronix.de>,
Fabio Baltieri <fabio.baltieri@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Richard Henderson <rth@twiddle.net>,
Michael Ellerman <michael@ellerman.id.au>,
Michal Simek <monstr@monstr.eu>, Tony Luck <tony.luck@intel.com>,
linux-parisc@vger.kernel.org, linux-cris-kernel@axis.com,
Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
Richard Kuo <rkuo@codeaurora.org>,
Kyle McMartin <kyle@mcmartin.ca>,
Paul Mundt <lethal@linux-sh.org>,
linux-alpha@vger.kernel.org, Olof Johansson <olof@lixom.net>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH-RFC 06/10] mips: switch to GENERIC_PCI_IOMAP
Date: Mon, 30 Jan 2012 00:45:07 +0200 [thread overview]
Message-ID: <20120129223339.GA22666@redhat.com> (raw)
In-Reply-To: <CAJiQ=7BPzhWWzU3_nDv3j=ZB4f=iOzeyLyd2L0_3UFaMiLujpw@mail.gmail.com>
On Sat, Jan 28, 2012 at 02:38:10PM -0800, Kevin Cernekee wrote:
> On Thu, Nov 24, 2011 at 12:18 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > mips copied pci_iomap from generic code, probably to avoid
> > pulling the rest of iomap.c in. Since that's in
> > a separate file now, we can reuse the common implementation.
>
> [snip]
>
> > - if (flags & IORESOURCE_IO)
> > - return ioport_map_pci(dev, start, len);
>
> While investigating a new warning on the 3.3-rc1 MIPS build (unused
> static function ioport_map_pci()), I noticed that this patch has shown
> up in Linus' tree as commit eab90291d35438bcebf7c3dc85be66d0f24e3002.
>
> I am not completely clear on the implications it has on mapping PCI I/O regions:
Yes, my bad, I missed the difference between ioport_map_pci
and ioport_map for both MIPS and SH.
I'll post a patch to fix this, which is probably preferable
to reintroducing the code duplication where it might
trip us up again.
--
MST
next prev parent reply other threads:[~2012-01-29 22:45 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1322163031.git.mst@redhat.com>
2011-11-24 20:15 ` [PATCH-RFC 01/10] lib: move GENERIC_IOMAP to lib/Kconfig Michael S. Tsirkin
2011-11-24 20:15 ` Michael S. Tsirkin
2011-11-24 20:15 ` Michael S. Tsirkin
2011-11-24 20:15 ` Michael S. Tsirkin
2011-11-24 20:15 ` Michael S. Tsirkin
2011-11-24 20:15 ` Michael S. Tsirkin
2011-11-25 8:41 ` Jesper Nilsson
2011-11-25 8:41 ` Jesper Nilsson
2011-11-25 8:41 ` Jesper Nilsson
2011-11-28 20:12 ` Richard Kuo
2011-11-28 20:12 ` Richard Kuo
2011-11-28 20:12 ` Richard Kuo
2011-11-28 20:12 ` Richard Kuo
2011-11-24 20:17 ` [PATCH-RFC 02/10] lib: add GENERIC_PCI_IOMAP Michael S. Tsirkin
2011-11-24 20:17 ` Michael S. Tsirkin
2011-11-24 20:17 ` Michael S. Tsirkin
2011-11-24 20:17 ` Michael S. Tsirkin
2011-11-24 20:17 ` Michael S. Tsirkin
2011-11-24 20:17 ` Michael S. Tsirkin
2011-11-24 22:07 ` Arnd Bergmann
2011-11-24 22:07 ` Arnd Bergmann
2011-11-24 22:07 ` Arnd Bergmann
2011-11-24 22:07 ` Arnd Bergmann
2011-11-25 0:54 ` Stephen Rothwell
2011-11-25 0:54 ` Stephen Rothwell
2011-11-25 0:54 ` Stephen Rothwell
2011-11-25 0:59 ` Stephen Rothwell
2011-11-25 0:59 ` Stephen Rothwell
2011-11-25 0:59 ` Stephen Rothwell
2011-11-27 17:12 ` Michael S. Tsirkin
2011-11-27 17:12 ` Michael S. Tsirkin
2011-11-27 17:12 ` Michael S. Tsirkin
2011-11-27 17:12 ` Michael S. Tsirkin
2011-11-28 19:21 ` [PATCH-RFC 02/10 v2] " Michael S. Tsirkin
2011-11-24 20:17 ` [PATCH-RFC 03/10] alpha: switch to GENERIC_PCI_IOMAP Michael S. Tsirkin
2011-11-24 20:17 ` Michael S. Tsirkin
2011-11-24 20:17 ` Michael S. Tsirkin
2011-11-24 20:17 ` Michael S. Tsirkin
2011-11-24 20:17 ` Michael S. Tsirkin
2011-11-24 20:17 ` Michael S. Tsirkin
2011-12-04 10:50 ` Michael S. Tsirkin
2011-12-06 16:45 ` Raúl Porcel
2011-11-24 20:17 ` [PATCH-RFC 04/10] arm: " Michael S. Tsirkin
2011-11-24 20:17 ` Michael S. Tsirkin
2011-11-24 20:17 ` Michael S. Tsirkin
2011-11-24 20:17 ` Michael S. Tsirkin
2011-11-24 20:17 ` Michael S. Tsirkin
2011-11-24 20:17 ` Michael S. Tsirkin
2011-12-04 10:47 ` Michael S. Tsirkin
2011-12-04 21:25 ` Russell King - ARM Linux
2011-11-24 20:18 ` [PATCH-RFC 05/10] microblaze: " Michael S. Tsirkin
2011-11-24 20:18 ` Michael S. Tsirkin
2011-11-24 20:18 ` Michael S. Tsirkin
2011-11-24 20:18 ` Michael S. Tsirkin
2011-11-24 20:18 ` Michael S. Tsirkin
2011-11-24 20:18 ` Michael S. Tsirkin
2011-11-24 20:18 ` [PATCH-RFC 06/10] mips: " Michael S. Tsirkin
2011-11-24 20:18 ` Michael S. Tsirkin
2011-11-24 20:18 ` Michael S. Tsirkin
2011-11-24 20:18 ` Michael S. Tsirkin
2011-11-24 20:18 ` Michael S. Tsirkin
2011-11-24 20:18 ` Michael S. Tsirkin
2011-12-04 10:47 ` Michael S. Tsirkin
2012-01-28 22:38 ` Kevin Cernekee
2012-01-28 22:38 ` Kevin Cernekee
2012-01-28 22:38 ` Kevin Cernekee
2012-01-28 22:38 ` Kevin Cernekee
2012-01-29 22:45 ` Michael S. Tsirkin [this message]
2012-01-29 22:45 ` Michael S. Tsirkin
2012-01-29 22:45 ` Michael S. Tsirkin
2012-01-29 22:45 ` Michael S. Tsirkin
2011-11-24 20:19 ` [PATCH-RFC 07/10] parisc: " Michael S. Tsirkin
2011-11-24 20:19 ` Michael S. Tsirkin
2011-11-24 20:19 ` Michael S. Tsirkin
2011-11-24 20:19 ` Michael S. Tsirkin
2011-11-24 20:19 ` Michael S. Tsirkin
2011-11-24 20:19 ` Michael S. Tsirkin
2011-12-04 10:48 ` Michael S. Tsirkin
2011-12-04 14:22 ` James Bottomley
2011-12-04 14:30 ` Michael S. Tsirkin
2011-12-04 14:32 ` James Bottomley
2011-12-04 14:42 ` Michael S. Tsirkin
2011-12-05 15:33 ` James Bottomley
2011-12-05 16:24 ` Michael S. Tsirkin
2011-12-05 16:46 ` James Bottomley
2011-12-05 18:23 ` Grant Grundler
2011-12-06 11:06 ` Michael S. Tsirkin
2011-12-06 16:18 ` Grant Grundler
2011-12-06 16:24 ` Michael S. Tsirkin
2011-12-16 2:11 ` Grant Grundler
2011-11-24 20:19 ` [PATCH-RFC 08/10] powerpc: " Michael S. Tsirkin
2011-11-24 20:19 ` Michael S. Tsirkin
2011-11-24 20:19 ` Michael S. Tsirkin
2011-11-24 20:19 ` Michael S. Tsirkin
2011-11-24 20:19 ` Michael S. Tsirkin
2011-11-24 20:19 ` Michael S. Tsirkin
2011-12-04 10:48 ` Michael S. Tsirkin
2011-12-04 20:52 ` Benjamin Herrenschmidt
2011-12-05 6:03 ` Michael S. Tsirkin
2011-11-24 20:20 ` [PATCH-RFC 09/10] sh: " Michael S. Tsirkin
2011-11-24 20:20 ` Michael S. Tsirkin
2011-11-24 20:20 ` Michael S. Tsirkin
2011-11-24 20:20 ` Michael S. Tsirkin
2011-11-24 20:20 ` Michael S. Tsirkin
2011-11-24 20:20 ` Michael S. Tsirkin
2011-11-24 20:21 ` [PATCH-RFC 10/10] sparc: " Michael S. Tsirkin
2011-11-24 20:21 ` Michael S. Tsirkin
2011-11-24 20:21 ` Michael S. Tsirkin
2011-11-24 20:21 ` Michael S. Tsirkin
2011-11-24 20:21 ` Michael S. Tsirkin
2011-11-24 20:21 ` Michael S. Tsirkin
2011-12-04 14:34 ` [PATCH-RFC v2 " Michael S. Tsirkin
2011-12-04 14:34 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120129223339.GA22666@redhat.com \
--to=mst@redhat.com \
--cc=arend@broadcom.com \
--cc=benh@kernel.crashing.org \
--cc=cernekee@gmail.com \
--cc=deller@gmx.de \
--cc=galak@kernel.crashing.org \
--cc=geert@linux-m68k.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=jejb@parisc-linux.org \
--cc=jesper.nilsson@axis.com \
--cc=lennox.wu@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@openrisc.net \
--cc=liqin.chen@sunplusct.com \
--cc=mingo@redhat.com \
--cc=nicolas.pitre@linaro.org \
--cc=paulus@samba.org \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.