From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
"Austin, Brian" <Brian.Austin@cirrus.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Mike Frysinger <vapier@gentoo.org>,
"qi.wang@intel.com" <qi.wang@intel.com>,
Liam Girdwood <lrg@ti.com>, Takashi Iwai <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kok.howg.ewe@intel.com" <kok.howg.ewe@intel.com>,
Daniel Mack <zonque@gmail.com>,
"yong.y.wang@intel.com" <yong.y.wang@intel.com>,
"joel.clark@intel.com" <joel.clark@intel.com>
Subject: Re: [PATCH v2] soc/lapis: add machine driver
Date: Tue, 6 Dec 2011 10:25:19 +0000 [thread overview]
Message-ID: <20111206102519.GD28840@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CANKRQniQSUWyaKUcn24ungmAu0ABHhBZ1=YhGz5jAp02X=KTAA@mail.gmail.com>
On Tue, Dec 06, 2011 at 11:37:52AM +0900, Tomoya MORINAGA wrote:
> Thanks. However, i2c access code is not included in Samsung.
> Though OMAP includes i2c access code like below,
> omap/sdp3430.c: twl_i2c_read_u8(TWL4030_MODULE_INTBR, &pin_mux,
> omap/sdp3430.c: twl_i2c_write_u8(TWL4030_MODULE_INTBR, pin_mux,
> this code doesn't seem applicable for me.
> Could you show best practice for i2c access of machine driver?
I2C access by machine drivers is not good practice. If you must do it
for some reason use the standard ASoC functions to read and write
registers.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: "Austin, Brian" <Brian.Austin@cirrus.com>,
Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Mike Frysinger <vapier@gentoo.org>,
"qi.wang@intel.com" <qi.wang@intel.com>,
Takashi Iwai <tiwai@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"yong.y.wang@intel.com" <yong.y.wang@intel.com>,
"kok.howg.ewe@intel.com" <kok.howg.ewe@intel.com>,
Daniel Mack <zonque@gmail.com>, Liam Girdwood <lrg@ti.com>,
"joel.clark@intel.com" <joel.clark@intel.com>
Subject: Re: [alsa-devel] [PATCH v2] soc/lapis: add machine driver
Date: Tue, 6 Dec 2011 10:25:19 +0000 [thread overview]
Message-ID: <20111206102519.GD28840@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CANKRQniQSUWyaKUcn24ungmAu0ABHhBZ1=YhGz5jAp02X=KTAA@mail.gmail.com>
On Tue, Dec 06, 2011 at 11:37:52AM +0900, Tomoya MORINAGA wrote:
> Thanks. However, i2c access code is not included in Samsung.
> Though OMAP includes i2c access code like below,
> omap/sdp3430.c: twl_i2c_read_u8(TWL4030_MODULE_INTBR, &pin_mux,
> omap/sdp3430.c: twl_i2c_write_u8(TWL4030_MODULE_INTBR, pin_mux,
> this code doesn't seem applicable for me.
> Could you show best practice for i2c access of machine driver?
I2C access by machine drivers is not good practice. If you must do it
for some reason use the standard ASoC functions to read and write
registers.
next prev parent reply other threads:[~2011-12-06 10:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 9:45 [PATCH v2] soc/lapis: add machine driver Tomoya MORINAGA
2011-12-02 15:34 ` Mark Brown
2011-12-05 5:28 ` Tomoya MORINAGA
2011-12-05 18:25 ` Mark Brown
2011-12-05 9:33 ` Tomoya MORINAGA
2011-12-05 18:32 ` Mark Brown
2011-12-06 2:02 ` Tomoya MORINAGA
2011-12-06 2:02 ` Tomoya MORINAGA
2011-12-06 2:11 ` [alsa-devel] " Austin, Brian
2011-12-06 2:37 ` Tomoya MORINAGA
2011-12-06 2:37 ` [alsa-devel] " Tomoya MORINAGA
2011-12-06 10:25 ` Mark Brown [this message]
2011-12-06 10:25 ` Mark Brown
2011-12-07 4:42 ` Tomoya MORINAGA
2011-12-07 13:23 ` Mark Brown
2011-12-07 13:23 ` Mark Brown
2011-12-09 8:38 ` Tomoya MORINAGA
2011-12-09 8:43 ` Mark Brown
2011-12-09 8:43 ` Mark Brown
2011-12-09 9:37 ` Tomoya MORINAGA
2011-12-09 9:37 ` Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206102519.GD28840@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Brian.Austin@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=qi.wang@intel.com \
--cc=tiwai@suse.de \
--cc=tomoya.rohm@gmail.com \
--cc=vapier@gentoo.org \
--cc=yong.y.wang@intel.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.